App\Domain\Publisher\ArticleFromURL

Complexity

Total Complexity

10

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getResult()	0	3	1
A	__construct()	0	9	2
B	process()	0	52	7

<?php
/**
 * This file is part of dispositif/wikibot application
 * 2019 © Philippe M. <dispositif@gmail.com>
 * For the full copyright and MIT license information, please view the LICENSE file.
 */

declare(strict_types=1);

namespace App\Domain\Publisher;

use App\Application\PublisherAction;
use App\Domain\Models\Wiki\ArticleOrLienBriseInterface;
use App\Domain\WikiTemplateFactory;
use Exception;
use Throwable;

/**
 * news URL to {{Article}}.
 * Class ArticleFromURL
 *
 * @package App\Application\Examples
 */
class ArticleFromURL
{
    private $publisherAction;
    /**
     * @var ArticleOrLienBriseInterface|null
     */
    private $article;
    /**
     * @var string
     */
    private $url;

    public function __construct(PublisherAction $publisher)
    {
        $this->publisherAction = $publisher;
        $this->url = $publisher->getUrl();
        try {
            $this->article = $this->process();
        } catch (Exception $e) {
            dump($e);
            die;

Using exit here is not recommended.

        }
    }

    /**
     * @throws Exception
     */
    private function process(): ?ArticleOrLienBriseInterface
    {
        $mapper = PublisherMapperFactory::fromURL($this->url);
        if (!$mapper) {
            return null;
        }
        sleep(10);
        $arrayLD = [];

The assignment to $arrayLD is dead and can be removed.

        try {
            $html = $this->publisherAction->getHTMLSource();
            $htmlData = $this->publisherAction->extractWebData($html);
        } catch (Throwable $e) {
            if (strpos($e->getMessage(), '404') !== false) {
                dump('****** lien brisé !!!!');
                $lienBrise = WikiTemplateFactory::create('lien brisé');
                $lienBrise->hydrate(['url' => $this->url, 'titre' => 'Article de presse', 'brisé le' => date('d-m-Y')]);

                return $lienBrise; // ok

The expression return $lienBrise could return the type App\Domain\Models\Wiki\GoogleLivresTemplate|App\Domain\Models\Wiki\LienWebTemplate|App\Domain\Models\Wiki\OuvrageTemplate which is incompatible with the type-hinted return App\Domain\Models\Wiki\ArticleOrLienBriseInterface|null. Consider adding an additional type-check to rule them out.

            }
            echo "*** Erreur ".$e->getMessage()."\n";

            return null;
        }

        if (empty($htmlData)) {
            echo "*** Pas de data Json-LD ou meta\n";

            return null;
        }
        $htmlData['url'] = $this->url;

        try {
            $articleData = $mapper->process($htmlData);
        } catch (Throwable $e) {
            echo sprintf(
                "SKIP : %s %s:%s \n",
                $e->getMessage(),
                $e->getFile(),
                $e->getLine()
            );

            return null;
        }

        if (!empty($articleData)) {
            $article = WikiTemplateFactory::create('article');
            $article->hydrate($articleData);

            return $article; // ok

The expression return $article could return the type App\Domain\Models\Wiki\GoogleLivresTemplate|App\Domain\Models\Wiki\LienWebTemplate|App\Domain\Models\Wiki\OuvrageTemplate which is incompatible with the type-hinted return App\Domain\Models\Wiki\ArticleOrLienBriseInterface|null. Consider adding an additional type-check to rule them out.

        }

        return null;
    }

    public function getResult(): ?ArticleOrLienBriseInterface
    {
        return $this->article;
    }

}