CirrusSearch::getPageTitles() - Code Metrics - Inspection of "Fix LanguageData 'turc' => 'tr'" - Dispositif/Wikibot - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 4ef148...eba0dc )

by Dispositif

created 2020-03-29 15:26 UTC

CirrusSearch::getPageTitles() A

↳ Parent: CirrusSearch

Complexity

Conditions	5
Paths	5

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	12
c	0
b	0
f	0
nc	5
nop	0
dl	0
loc	22
rs	9.5555

<?php
/**
 * This file is part of dispositif/wikibot application
 * 2019 © Philippe M. <[email protected]>
 * For the full copyright and MIT license information, please view the LICENSE file.
 */

declare(strict_types=1);


namespace App\Infrastructure;

use App\Domain\Exceptions\ConfigException;

/**
 * Dirty.
 * Class CirrusSearch
 *
 * @package App\Infrastructure
 */
class CirrusSearch implements PageListInterface
{
    /**
     * @var string
     */
    private $url;

    /**
     * CirrusSearch constructor.
     *
     * @param string|null $url
     */
    public function __construct(?string $url = null)
    {
        $this->url = $url;
    }

    public function setUrl(string $url)
    {
        $this->url = $url;
    }

    /**
     * TODO: use Wiki API library or Guzzle
     *
     * @return array
     * @throws ConfigException
     */
    public function getPageTitles(): array
    {
        if (!$this->url) {
            throw new ConfigException('CirrusSearch null URL');
        }

        $json = file_get_contents($this->url);
        if (false === $json) {
            return [];
        }

        $myArray = json_decode($json, true);
        $result = $myArray['query']['search'];
        if (empty($result)) {
            return [];
        }

        foreach ($result as $res) {
            $titles[] = trim($res['title']);
        }

        return $titles;

    }
}


1			<?php
2			/**
3			* This file is part of dispositif/wikibot application
4			* 2019 © Philippe M. <[email protected]>
5			* For the full copyright and MIT license information, please view the LICENSE file.
6			*/
7
8			declare(strict_types=1);
9
10
11			namespace App\Infrastructure;
12
13			use App\Domain\Exceptions\ConfigException;
14
15			/**
16			* Dirty.
17			* Class CirrusSearch
18			*
19			* @package App\Infrastructure
20			*/
21			class CirrusSearch implements PageListInterface
22			{
23			/**
24			* @var string
25			*/
26			private $url;
27
28			/**
29			* CirrusSearch constructor.
30			*
31			* @param string\|null $url
32			*/
33			public function __construct(?string $url = null)
34			{
35			$this->url = $url;
36			}
37
38			public function setUrl(string $url)
39			{
40			$this->url = $url;
41			}
42
43			/**
44			* TODO: use Wiki API library or Guzzle
45			*
46			* @return array
47			* @throws ConfigException
48			*/
49			public function getPageTitles(): array
50			{
51			if (!$this->url) {
52			throw new ConfigException('CirrusSearch null URL');
53			}
54
55			$json = file_get_contents($this->url);
56			if (false === $json) {
57			return [];
58			}
59
60			$myArray = json_decode($json, true);
61			$result = $myArray['query']['search'];
62			if (empty($result)) {
63			return [];
64			}
65
66			foreach ($result as $res) {
67			$titles[] = trim($res['title']);
68			}
69
70			return $titles;
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-03-24 10:34 UTC by Report Bug Copy Issue Report The variable `$titles` seems to be defined by a `foreach` iteration on line `66`. Are you sure the iterator is never empty, otherwise this variable is not defined? Loading history...
71			}
72			}
73

Dispositif / Wikibot

Push — dev ( 4ef148...eba0dc )

CirrusSearch::getPageTitles() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like