App\Infrastructure\WstatImport

Complexity

Total Complexity

15

Size/Duplication

Total Lines	119
Duplicated Lines	0 %

Importance

Changes	8
Bugs	3	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	parsingWstatData()	0	23	5
A	import()	0	8	2
A	getUrl()	0	5	1
A	__construct()	0	18	2
A	getData()	0	24	4
A	getPageTitles()	0	2	1

<?php
/**
 * This file is part of dispositif/wikibot application
 * 2019 : Philippe M. <dispositif@gmail.com>
 * For the full copyright and MIT license information, please view the LICENSE file.
 */

declare(strict_types=1);

namespace App\Infrastructure;

use Exception;
use GuzzleHttp\Client;

/**
 * Data import from https://wstat.fr (frwiki daily dump parsing).
 * https://wstat.fr/template/index.php?title=Ouvrage&query=inclusions&param=isbn&start=50000&limit=50&format=json
 * Class WstatImport.
 */
class WstatImport implements PageListInterface
{
    const MAX_IMPORT = 50000;

    private $params = [];

    private $max = 100;

    private $client;

    public function __construct(Client $client, ?array $params = null, ?int $max = 500)
    {
        $this->client = $client;
        $this->max = min(self::MAX_IMPORT, $max);

        //example
        // "nom de page" : https://wstat.fr/template/index.php?title=Ouvrage&query=inclusions-title&start=105000&limit=5000
        // "modèle complet" : https://wstat.fr/template/index.php?title=Ouvrage&query=inclusions&start=105000&limit=5000
        if (!$params) {
            $params = [
                'title' => 'Ouvrage',
                'query' => 'inclusions-title',
//                'param' => 'isbn',
                'start' => 50000,
                'limit' => 5000,
            ];
        }
        $this->params = $params;
    }

    public function getUrl()
    {
        $this->params['format'] = 'json';

        return 'https://wstat.fr/template/index.php?'.http_build_query($this->params);
    }

    /**
     * @return array [ ['title' => ..., 'template' => ...] ]
     *
     * @throws Exception
     */
    public function getData(): array
    {
        $data = [];
        $flag = true;
        while ($flag) {
            $json = $this->import($this->getUrl());
            $raw = json_decode($json, true);
            if (empty($raw)) {
                return [];
            }
            $data = array_merge($data, $this->parsingWstatData($raw));
            echo count($data)." titles\n";
            if ($this->max <= 0) {
                $flag = false;

The assignment to $flag is dead and can be removed.

                break;
            }

            // next page initialisation
            $this->params['start'] = (intval($this->params['start']) + $this->params['limit']);
            sleep(3);
        }

        return $data;
    }

    /**
     * Explode raw string.
     *
     * @param array $raw
     *
     * @return array [['title' => ..., 'template' => ...]]
     */
    private function parsingWstatData(array $raw): array
    {
        // Generator ?
        // Alexandre S. Giffard|{{Ouvrage|langue=|auteur1=|prénom...
        $data = [];
        foreach ($raw as $line) {
            // end of page ?
            if ('<!-- + -->' === $line) {
                continue;
            }
            $this->max = ($this->max - 1);

            // validate and explode wstat data
            $pos = mb_strpos($line, '|', 0);
            if (false === $pos || 0 === $pos) {
                continue;
            }
            $title = trim(mb_substr($line, 0, $pos));
            $template = trim(mb_substr($line, $pos + 1));
            $data[] = ['title' => $title, 'template' => $template];
        }

        return (array) $data;
    }

    /**
     * @param string $url
     *
     * @return string
     *
     * @throws Exception
     */
    private function import(string $url)
    {
        $response = $this->client->get($url);
        if (200 !== $response->getStatusCode()) {
            throw new Exception(sprintf('Error code: %s reason: %s', $response->getStatusCode(), $response->getReasonPhrase()));
        }

        return $response->getBody()->getContents();
    }

    public function getPageTitles(): array
    {
        // TODO: Implement getPageTitles() method.
    }

In this branch, the function will implicitly return null which is incompatible with the type-hinted return array. Consider adding a return statement or allowing null as return value.

}