App\Application\AbstractBotTaskWorker

Complexity

Total Complexity

19

Size/Duplication

Total Lines	161
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	run()	0	6	2
A	getTitles()	0	7	2
A	checkAllowedEdition()	0	17	3
A	__construct()	0	9	2
A	getText()	0	8	2
B	titleProcess()	0	30	7
A	doEdition()	0	9	1

<?php
/**
 * This file is part of dispositif/wikibot application
 * 2019 © Philippe M. <dispositif@gmail.com>
 * For the full copyright and MIT license information, please view the LICENSE file.
 */

declare(strict_types=1);

namespace App\Application;

use App\Infrastructure\PageListInterface;
use Mediawiki\Api\MediawikiFactory;
use Mediawiki\Api\UsageException;
use Mediawiki\DataModel\EditInfo;

abstract class AbstractBotTaskWorker
{
    const TASK_NAME           = "bot : Amélioration bibliographique";
    const SLEEP_AFTER_EDITION = 60;
    /**
     * @var PageListInterface
     */
    protected $pageListGenerator;
    /**
     * @var WikiBotConfig
     */
    protected $bot;
    /**
     * @var MediawikiFactory
     */
    protected $wiki;
    /**
     * @var WikiPageAction
     */
    protected $pageAction;
    // TODO : move taskName, botFlag... to to WikiBotConfig
    protected $taskName;
    protected $minorFlag = false;
    protected $botFlag = false;
    protected $modeAuto = false;

    /**
     * Goo2ouvrageWorker constructor.
     *
     * @param WikiBotConfig     $bot
     * @param MediawikiFactory  $wiki
     * @param PageListInterface $pagesGen
     */
    public function __construct(WikiBotConfig $bot, MediawikiFactory $wiki, ?PageListInterface $pagesGen = null)
    {
        $this->wiki = $wiki;
        $this->bot = $bot;
        if ($pagesGen) {
            $this->pageListGenerator = $pagesGen;
        }

        $this->run();
    }

    public function run()
    {
        $titles = $this->getTitles();

        foreach ($titles as $title) {
            $this->titleProcess($title);
        }
    }

    protected function getTitles(): array
    {
        if ($this->pageListGenerator) {
            return $this->pageListGenerator->getPageTitles();
        }

        return [];
    }

    /**
     * @param string $title
     *
     * @throws UsageException
     * @throws Throwable
     */
    protected function titleProcess(string $title): void
    {
        echo "$title \n";
        sleep(2);

        $this->taskName = static::TASK_NAME;

        $text = $this->getText($title);
        if (!$this->checkAllowedEdition($title, $text)) {

It seems like $text can also be of type null; however, parameter $text of App\Application\AbstractBotTaskWorker::checkAllowedEdition() does only seem to accept string, maybe add an additional type check?

            return;
        }

        $newText = $this->processDomain($title, $text);

        if (empty($newText) || $newText === $text) {
            echo "Skip identique ou vide\n";

            return;
        }

        if (!$this->modeAuto) {
            $ask = readline("*** ÉDITION ? [y/n/auto]");
            if ('auto' === $ask) {
                $this->modeAuto = true;
            } elseif ('y' !== $ask) {
                return;
            }
        }

        $this->doEdition($newText);
    }

    /**
     * todo DI
     *
     * @param string $title
     *
     * @return string|null
     * @throws Exception
     * @throws \Exception
     */
    protected function getText(string $title): ?string
    {
        $this->pageAction = new WikiPageAction($this->wiki, $title); // throw Exception
        if ($this->pageAction->getNs() !== 0) {
            throw new Exception("La page n'est pas dans Main (ns!==0)");

The type App\Application\Exception was not found. Did you mean Exception? If so, make sure to prefix the type with \.

        }

        return $this->pageAction->getText();
    }

    /**
     * Controle droit d'edition.
     *
     * @param string $title
     * @param string $text
     *
     * @return bool
     * @throws UsageException
     */
    protected function checkAllowedEdition(string $title, string $text): bool
    {
        // CONTROLES EDITION
        $this->bot->checkStopOnTalkpage(true);

        if (WikiBotConfig::isEditionRestricted($text)) {
            echo "SKIP : protection/3R.\n";

            return false;
        }
        if ($this->bot->minutesSinceLastEdit($title) < 4) {
            echo "SKIP : édition humaine dans les dernières 4 minutes.\n";

            return false;
        }

        return true;
    }

    /**
     * return $newText for editing
     */
    abstract protected function processDomain(string $title, ?string $text): ?string;

    protected function doEdition(string $newText): void
    {
        $result = $this->pageAction->editPage(
            $newText,
            new EditInfo($this->taskName, $this->minorFlag, $this->botFlag)
        );
        dump($result);
        echo "Sleep ".(string)static::SLEEP_AFTER_EDITION."\n";
        sleep(static::SLEEP_AFTER_EDITION);
    }
}