App\Domain\Publisher\Wikidata2Ouvrage

Complexity

Total Complexity

19

Size/Duplication

Total Lines	130
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
B	completeTitleLink()	0	17	7
A	__construct()	0	11	1
A	getOuvrage()	0	3	1
A	complete()	0	11	2
A	wikiURL2title()	0	9	1
B	completeAuthorLink()	0	20	7

<?php
/**
 * This file is part of dispositif/wikibot application (@github)
 * 2019/2020 © Philippe M. <dispositif@gmail.com>
 * For the full copyright and MIT license information, please view the license file.
 */

declare(strict_types=1);

namespace App\Domain\Publisher;

use App\Domain\Models\Wiki\OuvrageTemplate;
use App\Domain\Utils\TextUtil;
use App\Domain\Utils\WikiTextUtil;
use App\Infrastructure\WikidataAdapter;
use Exception;

/**
 * Complete un OuvrageTemplate à partir des données Infos[] en faisant
 * des requêtes vers Wikidata (ISBN => article du titre livre et ISNI => article
 * de l'auteur).
 * Class Wikidata2Ouvrage
 *
 * @package App\Domain\Publisher
 */
class Wikidata2Ouvrage
{

    private $ouvrage;
    /**
     * @var array
     */
    private $infos;
    private $adapter;
    public $log = [];
    /**
     * @var array|null
     */
    private $data;
    /**
     * @var string|null
     */
    private $title; // article title

    /**
     * Wikidata2Ouvrage constructor.
     *
     * @param WikidataAdapter $wdAdapter
     * @param OuvrageTemplate $ouvrage
     * @param string|null     $title
     *
     * @throws Exception
     */
    public function __construct(WikidataAdapter $wdAdapter, OuvrageTemplate $ouvrage, ?string $title = null)
    {
        $this->adapter = $wdAdapter;

        $clone = clone $ouvrage;
        $this->title = $title;
        $this->infos = $clone->getInfos();
        $clone->setInfos([]); // suppression Infos
        $clone->setDataSource('WikiData');
        $this->ouvrage = $clone;
        $this->complete();
    }

    public function getOuvrage(): OuvrageTemplate
    {
        return $this->ouvrage;
    }

    /**
     * quick and dirty.
     *
     * @throws Exception
     */
    private function complete(): void
    {
        $this->data = $this->adapter->getDataByInfos($this->infos);

        if (empty($this->data)) {
            return;
        }


        $this->completeAuthorLink();
        $this->completeTitleLink();
    }

    /**
     * @return void
     * @throws Exception
     */
    private function completeAuthorLink(): void
    {
        // Note : auteur1 non wikifié puisque venant de BnF
        if (!empty($this->data['articleAuthor']) && !empty($this->data['articleAuthor']['value'])
            && !empty(
                $this->ouvrage->getParam('lien auteur1')
                && !empty($this->title)
            )
        ) {
            // ajout wikilien auteur1
            $lienTitre = $this->wikiURL2title($this->data['articleAuthor']['value']);

            if (empty($lienTitre) || TextUtil::mb_ucfirst($lienTitre) === TextUtil::mb_ucfirst($this->title)) {

It seems like $this->title can also be of type null; however, parameter $str of App\Domain\Utils\TextUtil::mb_ucfirst() does only seem to accept string, maybe add an additional type check?

                // skip wikilink if this is the article title
                return;
            }

            $this->ouvrage->setParam('lien auteur1', $lienTitre);
            dump('Wikidata2Ouvrage: +lien auteur1='.$lienTitre);
            $this->log[] = '+lien auteur1';
        }
    }

    /**
     * TODO : move to WikiTextUtil ?
     * "https://fr.wikipedia.org/wiki/Michel_Houellebecq" => "Michel Houellebecq".
     *
     * @param $wikiURL
     *
     * @return string|null
     */
    private function wikiURL2title($wikiURL): ?string
    {
        $lienTitre = str_replace(
            ['https://fr.wikipedia.org/wiki/', '_'],
            ['', ' '],
            $wikiURL
        );

        return trim(urldecode($lienTitre));
    }

    /**
     * @throws Exception
     */
    private function completeTitleLink(): void
    {
        if (!empty($this->data['articleBook']) && !empty($this->data['articleBook']['value'])
            && !empty($this->ouvrage->getParam('lien titre'))
            && false === WikiTextUtil::isWikify($this->ouvrage->getParam('titre'))

It seems like $this->ouvrage->getParam('titre') can also be of type null; however, parameter $text of App\Domain\Utils\WikiTextUtil::isWikify() does only seem to accept string, maybe add an additional type check?

            && !empty($this->title)
        ) {
            // ajout wikilien titre
            // "https://fr.wikipedia.org/wiki/La_Carte_et_le_Territoire"
            $lienTitre = $this->wikiURL2title($this->data['articleBook']['value']);
            if (TextUtil::mb_ucfirst($lienTitre) === TextUtil::mb_ucfirst($this->title)) {
                // skip wikilink if this is the article title
                return;
            }
            $this->ouvrage->setParam('lien titre', $lienTitre);
            dump('Wikidata2Ouvrage: +lien titre='.$lienTitre);
            $this->log[] = '+lien titre';
        }
    }

}