App\Application\Http\ExternHttpClient

Complexity

Total Complexity

7

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	getHTML()	0	20	3
A	isWebURL()	0	7	3

<?php

/**
 * This file is part of dispositif/wikibot application (@github)
 * 2019/2020 © Philippe M. <dispositif@gmail.com>
 * For the full copyright and MIT license information, please view the license file.
 */
declare(strict_types=1);

namespace App\Application\Http;

use DomainException;
use GuzzleHttp\Client;
use Psr\Log\LoggerInterface;

class ExternHttpClient implements HttpClientInterface
{
    private $mapper;

The private property $mapper is not used, and could be removed.

    /**
     * @var Client
     */
    private $client;
    /**
     * @var Logger

The type App\Application\Http\Logger was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    private $log;

    public function __construct(?LoggerInterface $log = null)
    {
        $this->log = $log;

It seems like $log can also be of type Psr\Log\LoggerInterface. However, the property $log is declared as type App\Application\Http\Logger. Maybe add an additional type check?

        $this->client = new Client(
            [
                'timeout' => 60,
                'allow_redirects' => true,
                'headers' => ['User-Agent' => getenv('USER_AGENT')],
                //                'proxy'           => '192.168.16.1:10',
            ]
        );
    }

    /**
     * import source from URL with Guzzle.
     * todo abstract + refac async request
     *
     * @param string $url
     *
     * @return string|null
     */
    public function getHTML(string $url): ?string
    {
        // todo : check banned domains ?
        // todo : check DNS record => ban ?
        // todo : accept non-ascii URL ?
        // idn_to_ascii($url);
        // idn_to_ascii('teßt.com',IDNA_NONTRANSITIONAL_TO_ASCII,INTL_IDNA_VARIANT_UTS46)
        // checkdnsrr($string, "A") // check DNS record
        if (!self::isWebURL($url)) {
            throw new DomainException('URL not compatible : '.$url);
        }
        $response = $this->client->get($url);

        if (200 !== $response->getStatusCode()) {
            $this->log->error('HTTP error '.$response->getStatusCode().' '.$response->getReasonPhrase);

Accessing getReasonPhrase on the interface Psr\Http\Message\ResponseInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            return null;
        }

        return (string)$response->getBody()->getContents() ?? '';
    }

    public static function isWebURL(string $url): bool
    {
        if (!filter_var($url, FILTER_VALIDATE_URL) || !preg_match('#^https?://#i', $url)) {
            return false;
        }

        return true;
    }

}