CitationsAllCompletedValidator::isCitationCompleted() - Code Metrics - Inspection of "WIP refac OuvrageEditWorker (2)" - Dispositif/Wikibot - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — dev3 (ae391d)

by Dispositif

created 2023-04-22 19:21 UTC

isCitationCompleted() A

↳ Parent: CitationsAllCompletedValidator

Complexity

Conditions	4
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
dl	0
loc	11
rs	10
c	1
b	0
f	0
cc	4
nc	2
nop	1

<?php
/*
 * This file is part of dispositif/wikibot application (@github)
 * 2019-2023 © Philippe M./Irønie  <[email protected]>
 * For the full copyright and MIT license information, view the license file.
 */

declare(strict_types=1);

namespace App\Application\OuvrageEdit\Validators;

use App\Application\InfrastructurePorts\DbAdapterInterface;

class CitationsAllCompletedValidator implements ValidatorInterface
{
    /**
     * @var array
     */
    protected $citationCollection;
    /**
     * @var DbAdapterInterface
     */
    protected $db;

    public function __construct(array $citationCollection, DbAdapterInterface $db)
    {
        $this->citationCollection = $citationCollection;
        $this->db = $db;
    }

    public function validate(): bool
    {
        foreach ($this->citationCollection as $citation) {
            if (!$this->isCitationCompleted($citation)) {
                $this->log->warning("SKIP : Amélioration incomplet de l'article. sleep 10min");

                sleep(600); // todo move/event

                return false;
            }
        }
        return true;
    }

    protected function isCitationCompleted(array $pageOuvrage): bool
    {
        // hack temporaire pour éviter articles dont CompleteProcess incomplet
        if (
            empty($pageOuvrage['opti'])
            || empty($pageOuvrage['optidate'])
            || $pageOuvrage['optidate'] < $this->db->getOptiValidDate()
        ) {
            return false;
        }
        return true;
    }
}

1			<?php
2			/*
3			* This file is part of dispositif/wikibot application (@github)
4			* 2019-2023 © Philippe M./Irønie <[email protected]>
5			* For the full copyright and MIT license information, view the license file.
6			*/
7
8			declare(strict_types=1);
9
10			namespace App\Application\OuvrageEdit\Validators;
11
12			use App\Application\InfrastructurePorts\DbAdapterInterface;
13
14			class CitationsAllCompletedValidator implements ValidatorInterface
15			{
16			/**
17			* @var array
18			*/
19			protected $citationCollection;
20			/**
21			* @var DbAdapterInterface
22			*/
23			protected $db;
24
25			public function __construct(array $citationCollection, DbAdapterInterface $db)
26			{
27			$this->citationCollection = $citationCollection;
28			$this->db = $db;
29			}
30
31			public function validate(): bool
32			{
33			foreach ($this->citationCollection as $citation) {
34			if (!$this->isCitationCompleted($citation)) {
35			$this->log->warning("SKIP : Amélioration incomplet de l'article. sleep 10min");
			0 ignored issues – show Bug Best Practice introduced 2023-04-22 19:23 UTC by Report Bug Copy Issue Report The property `log` does not exist on `App\Application\OuvrageE...nsAllCompletedValidator`. Did you maybe forget to declare it? Loading history...
36			sleep(600); // todo move/event
37
38			return false;
39			}
40			}
41			return true;
42			}
43
44			protected function isCitationCompleted(array $pageOuvrage): bool
45			{
46			// hack temporaire pour éviter articles dont CompleteProcess incomplet
47			if (
48			empty($pageOuvrage['opti'])
49			\|\| empty($pageOuvrage['optidate'])
50			\|\| $pageOuvrage['optidate'] < $this->db->getOptiValidDate()
51			) {
52			return false;
53			}
54			return true;
55			}
56			}

Dispositif / Wikibot

Branch — dev3 (ae391d)

isCitationCompleted() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like