App\Application\GoogleBooksWorker

Complexity

Total Complexity

1

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	processDomain()	0	5	1

<?php

/**
 * This file is part of dispositif/wikibot application
 * 2019 : Philippe M. <dispositif@gmail.com>
 * For the full copyright and MIT license information, please view the LICENSE file.
 */
declare(strict_types=1);

namespace App\Application;

use App\Domain\GoogleTransformer;
use Throwable;

/**
 * todo Refac duplication
 * externe goo
 * Class GoogleBooksWorker
 *
 * @package App\Application\Examples
 */
class GoogleBooksWorker extends AbstractBotTaskWorker
{
    const TASK_NAME           = "Amélioration bibliographique : lien Google Books ⇒ {ouvrage}"; // 😎
    const SLEEP_AFTER_EDITION = 300;
    protected $botFlag = false;

    protected $modeAuto = true;

    /**
     * @param string      $title
     * @param string|null $text
     *
     * @return string|null
     * @throws Throwable
     */
    protected function processDomain(string $title, ?string $text): ?string
    {
        $ref = new GoogleTransformer();

        return $ref->process($text);

It seems like $text can also be of type null; however, parameter $text of App\Domain\GoogleTransformer::process() does only seem to accept string, maybe add an additional type check?

    }
}