ExternRefTransformer::process() - Code Metrics - Inspection of "Fix hint typing, style (scrutiziner)" - Dispositif/Wikibot - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 7abd3d...61ab03 )

by Dispositif

created 2020-04-17 12:01 UTC

ExternRefTransformer::process() C

↳ Parent: ExternRefTransformer

Complexity

Conditions	12
Paths	26

Size

Total Lines	59
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	12
eloc	34
c	0
b	0
f	0
nc	26
nop	1
dl	0
loc	59
rs	6.9666

How to fix Long Method Complexity

<?php
/**
 * This file is part of dispositif/wikibot application (@github)
 * 2019/2020 © Philippe M. <[email protected]>
 * For the full copyright and MIT license information, please view the license file.
 */

declare(strict_types=1);

namespace App\Application;

use App\Domain\ExternDomains;
use App\Domain\ExternPageFactory;
use App\Domain\Models\Wiki\AbstractWikiTemplate;
use App\Domain\Models\Wiki\ArticleTemplate;
use App\Domain\Models\Wiki\LienWebTemplate;
use App\Domain\Models\Wiki\OuvrageTemplate;
use App\Domain\Publisher\ExternMapper;
use App\Domain\Utils\WikiTextUtil;
use App\Domain\WikiTemplateFactory;
use App\Infrastructure\Logger;
use Codedungeon\PHPCliColors\Color;
use Normalizer;
use Psr\Log\LoggerInterface;
use Symfony\Component\Yaml\Yaml;

/**
 * todo move Domain
 * Class ExternRefTransformer
 *
 * @package App\Application
 */
class ExternRefTransformer implements TransformerInterface
{

    const SKIPPED_FILE_LOG  = __DIR__.'/resources/external_skipped.log';
    const LOG_REQUEST_ERROR = __DIR__.'/resources/external_request_error.log';
    public $skipUnauthorised = true;
    /**
     * @var array
     */
    public $summaryLog = [];
    /**
     * @var LoggerInterface
     */
    protected $log;
    private $config;
    /**
     * @var string|string[]
     */
    private $domain;
    /**
     * @var string
     */
    private $url;
    /**
     * @var ExternMapper
     */
    private $mapper;
    /**
     * @var array
     */
    private $data = [];
    /**
     * @var array
     */
    private $skip_domain = [];
    /**
     * @var \App\Domain\ExternPage
     */
    private $externalPage;

    /**
     * ExternalRefTransformer constructor.
     *
     * @param LoggerInterface $log
     */
    public function __construct(LoggerInterface $log)
    {
        $this->log = $log;

        // todo REFAC DataObject[]
        $this->config = Yaml::parseFile(__DIR__.'/resources/config_presse.yaml');
        $skipFromFile = file(__DIR__.'/resources/config_skip_domain.txt');
        $this->skip_domain = ($skipFromFile) ? $skipFromFile : [];

        $this->data['newspaper'] = json_decode(file_get_contents(__DIR__.'/resources/data_newspapers.json'), true);
        $this->data['scientific domain'] = json_decode(
            file_get_contents(__DIR__.'/resources/data_scientific_domain.json'),
            true
        );
        $this->data['scientific wiki'] = json_decode(
            file_get_contents(__DIR__.'/resources/data_scientific_wiki.json'),
            true
        );

        $this->mapper = new ExternMapper(new Logger());
    }

    /**
     * @param string $string
     *
     * @return string
     * @throws \Exception
     */
    public function process(string $string): string
    {
        if (!$this->isURLAutorized($string)) {
            return $string;
        }
        try {
            sleep(5);
            $this->externalPage = ExternPageFactory::fromURL($string, $this->log);
            $pageData = $this->externalPage->getData();
            $this->log->debug('metaData', $this->externalPage->getData());
        } catch (\Exception $e) {
            // ne pas générer de {lien brisé}, car peut-être 404 temporaire
            $this->log->notice('erreur sur extractWebData '.$e->getMessage());
            file_put_contents(self::LOG_REQUEST_ERROR, $this->domain);
        }

        if (empty($pageData)
            || (empty($pageData['JSON-LD']) && empty($pageData['meta']))
        ) {
            // site avec HTML pourri
            return $string;
        }

        if (isset($pageData['robots']) && strpos($pageData['robots'], 'noindex') !== false) {
            $this->log->notice('SKIP robots: noindex');

            return $string;
        }

        $mapData = $this->mapper->process($pageData);

        // check dataValide
        if (empty($mapData) || empty($mapData['url']) || empty($mapData['titre'])) {
            $this->skip_domain[] = $this->domain;
            $this->log->info('Mapping incomplet');
            // Todo : temp data
            try {
                file_put_contents(self::SKIPPED_FILE_LOG, $this->domain.",".$this->url."\n", FILE_APPEND);
            } catch (\Throwable $e) {
                unset($e);
            }

            return $string;
        }

        $this->tagAndLog($mapData);
        $this->addSummaryLog($mapData);

        $template = $this->chooseTemplateByData($mapData);

        $mapData = $this->replaceSitenameByConfig($mapData, $template);
        $mapData = $this->replaceURLbyOriginal($mapData);

        $template->hydrate($mapData);

        $serialized = $template->serialize(true);
        $this->log->info($serialized."\n");

        return Normalizer::normalize($serialized);
    }

    /**
     * @param string $string
     *
     * @return bool
     * @throws \Exception
     */
    protected function isURLAutorized(string $string): bool
    {
        if (!preg_match('#^http?s://[^ ]+$#i', $string)) {
            return false;
        }

        $this->url = $string;
        $this->domain = ExternDomains::extractSubDomain($this->url);

        if (in_array($this->domain, $this->skip_domain)) {
            return false;
        }

        if (!isset($this->config[$this->domain])) {
            $this->log->info("Domain ".$this->domain." non configuré\n");
            if ($this->skipUnauthorised) {
                return false;
            }
        } else {
            echo "> Domaine ".Color::LIGHT_GREEN.$this->domain.Color::NORMAL." configuré\n";
        }

        $this->config[$this->domain] = $this->config[$this->domain] ?? [];
        $this->config[$this->domain] = is_array($this->config[$this->domain]) ? $this->config[$this->domain] : [];

        if ($this->config[$this->domain] === 'desactived' || isset($this->config[$this->domain]['desactived'])) {
            $this->log->info("Domain ".$this->domain." desactivé\n");

            return false;
        }

        return true;
    }

    private function tagAndLog(array $mapData)
    {
        $this->log->debug('mapData', $mapData);

        if (isset($mapData['DATA-ARTICLE']) && $mapData['DATA-ARTICLE']) {
            $this->log->notice("Article OK");
        }
        if (isset($this->data['newspaper'][$this->domain])) {
            $this->log->notice('PRESSE');
        }
        if ($this->isScientificDomain()) {
            $this->log->notice('SCIENCE');
        }
    }

    private function isScientificDomain(): bool
    {
        if (isset($this->data['scientific domain'][$this->domain])) {
            return true;
        }
        if (strpos('.revues.org', $this->domain) > 0) {
            return true;
        }

        return false;
    }

    private function addSummaryLog(array $mapData)
    {
        $this->summaryLog[] = $mapData['site'] ?? $mapData['périodique'] ?? '?';
    }

    /**
     * todo refac lisible
     */
    private function chooseTemplateByData(array $mapData): AbstractWikiTemplate
    {
        // Logique : choix template
        $this->config[$this->domain]['template'] = $this->config[$this->domain]['template'] ?? [];
        $mapData['DATA-ARTICLE'] = $mapData['DATA-ARTICLE'] ?? false;

        if ($this->config[$this->domain]['template'] === 'article'
            || ($this->config[$this->domain]['template'] === 'auto' && $mapData['DATA-ARTICLE'])
            || ($mapData['DATA-ARTICLE'] && !empty($this->data['newspaper'][$this->domain]))
            || $this->isScientificDomain()
        ) {
            $templateName = 'article';
        }
        if (!isset($templateName) || $this->config[$this->domain]['template'] === 'lien web') {
            $templateName = 'lien web';
        }
        $template = WikiTemplateFactory::create($templateName);
        $template->userSeparator = " |";

        return $template;
    }

    /**
     * Logique : remplacement titre périodique ou nom du site
     *
     * @param array $mapData
     * @param       $template
     *
     * @return array
     */
    private function replaceSitenameByConfig(array $mapData, $template): array
    {
        // from wikidata URL of newspapers
        if (!empty($this->data['newspaper'][$this->domain])) {
            $frwiki = $this->data['newspaper'][$this->domain]['frwiki'];
            $label = $this->data['newspaper'][$this->domain]['fr'];
            if (isset($mapData['site']) || $template instanceof LienWebTemplate) {
                $mapData['site'] = WikiTextUtil::wikilink($label, $frwiki);
            }
            if (isset($mapData['périodique']) || $template instanceof ArticleTemplate) {
                $mapData['périodique'] = WikiTextUtil::wikilink($label, $frwiki);
            }
        }

        // from wikidata of scientific journals
        if (isset($mapData['périodique']) && isset($this->data['scientific wiki'][$mapData['périodique']])) {
            $mapData['périodique'] = WikiTextUtil::wikilink(
                $mapData['périodique'],
                $this->data['scientific wiki'][$mapData['périodique']]
            );
        }

        // from YAML config
        if (!empty($this->config[$this->domain]['site']) && $template instanceof LienWebTemplate) {
            $mapData['site'] = $this->config[$this->domain]['site'];
        }
        if (!empty($this->config[$this->domain]['périodique'])
            && (!empty($mapData['périodique'])
                || $template instanceof OuvrageTemplate)
        ) {
            $mapData['périodique'] = $this->config[$this->domain]['périodique'];
        }

        // from logic
        if (empty($mapData['site']) && $template instanceof LienWebTemplate) {
            $mapData['site'] = $this->externalPage->getPrettyDomainName();
        }

        return $mapData;
    }

    private function replaceURLbyOriginal(array $mapData):array
    {
        $mapData['url'] = $this->url;
        return $mapData;
    }

}


1			<?php
2			/**
3			* This file is part of dispositif/wikibot application (@github)
4			* 2019/2020 © Philippe M. <[email protected]>
5			* For the full copyright and MIT license information, please view the license file.
6			*/
7
8			declare(strict_types=1);
9
10			namespace App\Application;
11
12			use App\Domain\ExternDomains;
13			use App\Domain\ExternPageFactory;
14			use App\Domain\Models\Wiki\AbstractWikiTemplate;
15			use App\Domain\Models\Wiki\ArticleTemplate;
16			use App\Domain\Models\Wiki\LienWebTemplate;
17			use App\Domain\Models\Wiki\OuvrageTemplate;
18			use App\Domain\Publisher\ExternMapper;
19			use App\Domain\Utils\WikiTextUtil;
20			use App\Domain\WikiTemplateFactory;
21			use App\Infrastructure\Logger;
22			use Codedungeon\PHPCliColors\Color;
23			use Normalizer;
24			use Psr\Log\LoggerInterface;
25			use Symfony\Component\Yaml\Yaml;
26
27			/**
28			* todo move Domain
29			* Class ExternRefTransformer
30			*
31			* @package App\Application
32			*/
33			class ExternRefTransformer implements TransformerInterface
34			{
35
36			const SKIPPED_FILE_LOG = __DIR__.'/resources/external_skipped.log';
37			const LOG_REQUEST_ERROR = __DIR__.'/resources/external_request_error.log';
38			public $skipUnauthorised = true;
39			/**
40			* @var array
41			*/
42			public $summaryLog = [];
43			/**
44			* @var LoggerInterface
45			*/
46			protected $log;
47			private $config;
48			/**
49			* @var string\|string[]
50			*/
51			private $domain;
52			/**
53			* @var string
54			*/
55			private $url;
56			/**
57			* @var ExternMapper
58			*/
59			private $mapper;
60			/**
61			* @var array
62			*/
63			private $data = [];
64			/**
65			* @var array
66			*/
67			private $skip_domain = [];
68			/**
69			* @var \App\Domain\ExternPage
70			*/
71			private $externalPage;
72
73			/**
74			* ExternalRefTransformer constructor.
75			*
76			* @param LoggerInterface $log
77			*/
78			public function __construct(LoggerInterface $log)
79			{
80			$this->log = $log;
81
82			// todo REFAC DataObject[]
83			$this->config = Yaml::parseFile(__DIR__.'/resources/config_presse.yaml');
84			$skipFromFile = file(__DIR__.'/resources/config_skip_domain.txt');
85			$this->skip_domain = ($skipFromFile) ? $skipFromFile : [];
86
87			$this->data['newspaper'] = json_decode(file_get_contents(__DIR__.'/resources/data_newspapers.json'), true);
88			$this->data['scientific domain'] = json_decode(
89			file_get_contents(__DIR__.'/resources/data_scientific_domain.json'),
90			true
91			);
92			$this->data['scientific wiki'] = json_decode(
93			file_get_contents(__DIR__.'/resources/data_scientific_wiki.json'),
94			true
95			);
96
97			$this->mapper = new ExternMapper(new Logger());
98			}
99
100			/**
101			* @param string $string
102			*
103			* @return string
104			* @throws \Exception
105			*/
106			public function process(string $string): string
107			{
108			if (!$this->isURLAutorized($string)) {
109			return $string;
110			}
111			try {
112			sleep(5);
113			$this->externalPage = ExternPageFactory::fromURL($string, $this->log);
114			$pageData = $this->externalPage->getData();
115			$this->log->debug('metaData', $this->externalPage->getData());
116			} catch (\Exception $e) {
117			// ne pas générer de {lien brisé}, car peut-être 404 temporaire
118			$this->log->notice('erreur sur extractWebData '.$e->getMessage());
119			file_put_contents(self::LOG_REQUEST_ERROR, $this->domain);
120			}
121
122			if (empty($pageData)
123			\|\| (empty($pageData['JSON-LD']) && empty($pageData['meta']))
124			) {
125			// site avec HTML pourri
126			return $string;
127			}
128
129			if (isset($pageData['robots']) && strpos($pageData['robots'], 'noindex') !== false) {
130			$this->log->notice('SKIP robots: noindex');
131
132			return $string;
133			}
134
135			$mapData = $this->mapper->process($pageData);
136
137			// check dataValide
138			if (empty($mapData) \|\| empty($mapData['url']) \|\| empty($mapData['titre'])) {
139			$this->skip_domain[] = $this->domain;
140			$this->log->info('Mapping incomplet');
141			// Todo : temp data
142			try {
143			file_put_contents(self::SKIPPED_FILE_LOG, $this->domain.",".$this->url."\n", FILE_APPEND);
144			} catch (\Throwable $e) {
145			unset($e);
146			}
147
148			return $string;
149			}
150
151			$this->tagAndLog($mapData);
152			$this->addSummaryLog($mapData);
153
154			$template = $this->chooseTemplateByData($mapData);
155
156			$mapData = $this->replaceSitenameByConfig($mapData, $template);
157			$mapData = $this->replaceURLbyOriginal($mapData);
158
159			$template->hydrate($mapData);
160
161			$serialized = $template->serialize(true);
162			$this->log->info($serialized."\n");
163
164			return Normalizer::normalize($serialized);
165			}
166
167			/**
168			* @param string $string
169			*
170			* @return bool
171			* @throws \Exception
172			*/
173			protected function isURLAutorized(string $string): bool
174			{
175			if (!preg_match('#^http?s://[^ ]+$#i', $string)) {
176			return false;
177			}
178
179			$this->url = $string;
180			$this->domain = ExternDomains::extractSubDomain($this->url);
181
182			if (in_array($this->domain, $this->skip_domain)) {
183			return false;
184			}
185
186			if (!isset($this->config[$this->domain])) {
187			$this->log->info("Domain ".$this->domain." non configuré\n");
188			if ($this->skipUnauthorised) {
189			return false;
190			}
191			} else {
192			echo "> Domaine ".Color::LIGHT_GREEN.$this->domain.Color::NORMAL." configuré\n";
193			}
194
195			$this->config[$this->domain] = $this->config[$this->domain] ?? [];
196			$this->config[$this->domain] = is_array($this->config[$this->domain]) ? $this->config[$this->domain] : [];
197
198			if ($this->config[$this->domain] === 'desactived' \|\| isset($this->config[$this->domain]['desactived'])) {
199			$this->log->info("Domain ".$this->domain." desactivé\n");
200
201			return false;
202			}
203
204			return true;
205			}
206
207			private function tagAndLog(array $mapData)
208			{
209			$this->log->debug('mapData', $mapData);
210
211			if (isset($mapData['DATA-ARTICLE']) && $mapData['DATA-ARTICLE']) {
212			$this->log->notice("Article OK");
213			}
214			if (isset($this->data['newspaper'][$this->domain])) {
215			$this->log->notice('PRESSE');
216			}
217			if ($this->isScientificDomain()) {
218			$this->log->notice('SCIENCE');
219			}
220			}
221
222			private function isScientificDomain(): bool
223			{
224			if (isset($this->data['scientific domain'][$this->domain])) {
225			return true;
226			}
227			if (strpos('.revues.org', $this->domain) > 0) {
228			return true;
229			}
230
231			return false;
232			}
233
234			private function addSummaryLog(array $mapData)
235			{
236			$this->summaryLog[] = $mapData['site'] ?? $mapData['périodique'] ?? '?';
237			}
238
239			/**
240			* todo refac lisible
241			*/
242			private function chooseTemplateByData(array $mapData): AbstractWikiTemplate
243			{
244			// Logique : choix template
245			$this->config[$this->domain]['template'] = $this->config[$this->domain]['template'] ?? [];
246			$mapData['DATA-ARTICLE'] = $mapData['DATA-ARTICLE'] ?? false;
247
248			if ($this->config[$this->domain]['template'] === 'article'
249			\|\| ($this->config[$this->domain]['template'] === 'auto' && $mapData['DATA-ARTICLE'])
250			\|\| ($mapData['DATA-ARTICLE'] && !empty($this->data['newspaper'][$this->domain]))
251			\|\| $this->isScientificDomain()
252			) {
253			$templateName = 'article';
254			}
255			if (!isset($templateName) \|\| $this->config[$this->domain]['template'] === 'lien web') {
256			$templateName = 'lien web';
257			}
258			$template = WikiTemplateFactory::create($templateName);
259			$template->userSeparator = " \|";
260
261			return $template;
262			}
263
264			/**
265			* Logique : remplacement titre périodique ou nom du site
266			*
267			* @param array $mapData
268			* @param $template
269			*
270			* @return array
271			*/
272			private function replaceSitenameByConfig(array $mapData, $template): array
273			{
274			// from wikidata URL of newspapers
275			if (!empty($this->data['newspaper'][$this->domain])) {
276			$frwiki = $this->data['newspaper'][$this->domain]['frwiki'];
277			$label = $this->data['newspaper'][$this->domain]['fr'];
278			if (isset($mapData['site']) \|\| $template instanceof LienWebTemplate) {
279			$mapData['site'] = WikiTextUtil::wikilink($label, $frwiki);
280			}
281			if (isset($mapData['périodique']) \|\| $template instanceof ArticleTemplate) {
282			$mapData['périodique'] = WikiTextUtil::wikilink($label, $frwiki);
283			}
284			}
285
286			// from wikidata of scientific journals
287			if (isset($mapData['périodique']) && isset($this->data['scientific wiki'][$mapData['périodique']])) {
288			$mapData['périodique'] = WikiTextUtil::wikilink(
289			$mapData['périodique'],
290			$this->data['scientific wiki'][$mapData['périodique']]
291			);
292			}
293
294			// from YAML config
295			if (!empty($this->config[$this->domain]['site']) && $template instanceof LienWebTemplate) {
296			$mapData['site'] = $this->config[$this->domain]['site'];
297			}
298			if (!empty($this->config[$this->domain]['périodique'])
299			&& (!empty($mapData['périodique'])
300			\|\| $template instanceof OuvrageTemplate)
301			) {
302			$mapData['périodique'] = $this->config[$this->domain]['périodique'];
303			}
304
305			// from logic
306			if (empty($mapData['site']) && $template instanceof LienWebTemplate) {
307			$mapData['site'] = $this->externalPage->getPrettyDomainName();
308			}
309
310			return $mapData;
311			}
312
313			private function replaceURLbyOriginal(array $mapData):array
314			{
315			$mapData['url'] = $this->url;
316			return $mapData;
317			}
318
319			}
320

Dispositif / Wikibot

Push — master ( 7abd3d...61ab03 )

ExternRefTransformer::process() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like