App\Domain\WikiOptimizer\Handlers\PredictErrorParameterHandler

Complexity

Total Complexity

11

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	handle()	0	35	10
A	__construct()	0	4	1

<?php
/*
 * This file is part of dispositif/wikibot application (@github)
 * 2019-2023 © Philippe M./Irønie  <dispositif@gmail.com>
 * For the full copyright and MIT license information, view the license file.
 */

declare(strict_types=1);

namespace App\Domain\WikiOptimizer\Handlers;

use App\Domain\Models\Wiki\WikiTemplateInterface;
use App\Domain\Utils\TextUtil;
use App\Domain\WikiOptimizer\OptiStatus;

class PredictErrorParameterHandler implements OptimizeHandlerInterface
{
    /**
     * @var WikiTemplateInterface
     */
    protected $template;
    /**
     * @var OptiStatus
     */
    protected $optiStatus;

    public function __construct(WikiTemplateInterface $template, OptiStatus $summary)
    {
        $this->template = $template;
        $this->optiStatus = $summary;
    }

    // Correction des parametres rejetés à l'hydratation données.
    public function handle()
    {
        if (empty($this->template->parametersErrorFromHydrate)) {

Accessing parametersErrorFromHydrate on the interface App\Domain\Models\Wiki\WikiTemplateInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            return;
        }
        $allParamsAndAlias = $this->template->getParamsAndAlias();

The method getParamsAndAlias() does not exist on App\Domain\Models\Wiki\WikiTemplateInterface. Did you maybe mean getParam()?

        foreach ($this->template->parametersErrorFromHydrate as $name => $value) {
            if (!is_string($name)) {
                // example : 1 => "ouvrage collectif" from |ouvrage collectif|
                continue;
            }

            // delete error parameter if no value
            if (empty($value)) {
                unset($this->template->parametersErrorFromHydrate[$name]);

                continue;
            }

            $maxDistance = 1;
            if (mb_strlen($name) >= 4) {
                $maxDistance = 2;
            }
            if (mb_strlen($name) >= 8) {
                $maxDistance = 3;
            }

            $predName = TextUtil::predictCorrectParam($name, $allParamsAndAlias, $maxDistance);
            if ($predName && mb_strlen($name) >= 5 && empty($this->template->getParam($predName))) {
                $predName = $this->template->getAliasParam($predName);

The method getAliasParam() does not exist on App\Domain\Models\Wiki\WikiTemplateInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to App\Domain\Models\Wiki\WikiTemplateInterface.

                $this->template->setParam($predName, $value);
                $this->optiStatus->addSummaryLog(sprintf('%s⇒%s ?', $name, $predName));
                $this->optiStatus->setNotCosmetic(true);
                unset($this->template->parametersErrorFromHydrate[$name]);
            }
        }
    }
}