App\Domain\WikiOptimizer\Handlers\LocationHandler

Complexity

Total Complexity

6

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	23	5
A	__construct()	0	4	1

<?php
/*
 * This file is part of dispositif/wikibot application (@github)
 * 2019-2023 © Philippe M./Irønie  <dispositif@gmail.com>
 * For the full copyright and MIT license information, view the license file.
 */

declare(strict_types=1);

namespace App\Domain\WikiOptimizer\Handlers;

use App\Domain\InfrastructurePorts\PageListInterface;
use App\Domain\Models\Wiki\OuvrageTemplate;
use App\Domain\Utils\TextUtil;
use App\Domain\Utils\WikiTextUtil;
use App\Domain\WikiOptimizer\OptiStatus;
use Exception;

class LocationHandler extends AbstractOuvrageHandler
{
    public const TRANSLATE_CITY_FR = __DIR__ . '/../../resources/traduction_ville.csv';

    /**
     * @var PageListInterface
     */
    protected $pageListManager;

    public function __construct(OuvrageTemplate $ouvrage, OptiStatus $summary, PageListInterface $pageListManager)
    {
        parent::__construct($ouvrage, $summary);
        $this->pageListManager = $pageListManager;
    }

    /**
     * Todo: injection dep.
     * Todo : "[s. l.]" sans lieu "s.l.n.d." sans lieu ni date.
     * @throws Exception
     */
    public function handle()
    {
        $location = $this->getParam('lieu');
        if (empty($location)) {
            return;
        }

        // typo and unwikify
        $memo = $location;
        $location = WikiTextUtil::unWikify($location);
        $location = TextUtil::mb_ucfirst($location);
        if ($memo !== $location) {
            $this->setParam('lieu', $location);
            $this->addSummaryLog('±lieu');
            $this->optiStatus->setNotCosmetic(true);
        }

        // translation : "London"->"Londres"
        $row = $this->pageListManager->findCSVline(self::TRANSLATE_CITY_FR, $location);

The method findCSVline() does not exist on App\Domain\InfrastructurePorts\PageListInterface. It seems like you code against a sub-type of App\Domain\InfrastructurePorts\PageListInterface such as App\Infrastructure\FileManager.

        if ($row !== [] && !empty($row[1])) {
            $this->setParam('lieu', $row[1]);
            $this->addSummaryLog('lieu francisé');
            $this->notCosmetic = true;

The property notCosmetic does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }
    }
}