App\Domain\OptimizeISBNTrait

Complexity

Total Complexity

20

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
D	processIsbn()	0	92	20

<?php
/**
 * This file is part of dispositif/wikibot application (@github)
 * 2019/2020 © Philippe M. <dispositif@gmail.com>
 * For the full copyright and MIT license information, please view the license file.
 */

declare(strict_types=1);


namespace App\Domain;

use Exception;
use Throwable;

/**
 * TODO refac : too many conditions
 * Trait OptimizeISBNTrait
 */
trait OptimizeISBNTrait
{
    /**
     * Refac complexity (lines, 20 conditions)
     * Validate or correct ISBN.
     *
     * @throws Exception
     */
    protected function processIsbn()
    {
        $isbn = $this->getParam('isbn') ?? '';

It seems like getParam() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (empty($isbn)) {
            return;
        }

        // ISBN-13 à partir de 2007
        $year = $this->findBookYear();

It seems like findBookYear() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($year !== null && $year < 2007 && 10 === strlen($this->stripIsbn($isbn))) {

It seems like stripIsbn() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            // juste mise en forme ISBN-10 pour 'isbn'
            try {
                $isbnMachine = new IsbnFacade($isbn);
                $isbnMachine->validate();
                $isbn10pretty = $isbnMachine->format('ISBN-10');
                if ($isbn10pretty !== $isbn) {
                    $this->setParam('isbn', $isbn10pretty);

It seems like setParam() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                    $this->addSummaryLog('ISBN10');

It seems like addSummaryLog() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                    //                    $this->notCosmetic = true;
                }
            } catch (Throwable $e) {
                // ISBN not validated
                $this->setParam(
                    'isbn invalide',
                    sprintf('%s %s', $isbn, $e->getMessage() ?? '')
                );
                $this->addSummaryLog(sprintf('ISBN invalide: %s', $e->getMessage()));
                $this->notCosmetic = true;

The property notCosmetic does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            }

            return;
        }

        try {
            $isbnMachine = new IsbnFacade($isbn);
            $isbnMachine->validate();
            $isbn13 = $isbnMachine->format('ISBN-13');
        } catch (Throwable $e) {
            // ISBN not validated
            // TODO : bot ISBN invalide (queue, message PD...)
            $this->setParam(
                'isbn invalide',
                sprintf('%s %s', $isbn, $e->getMessage() ?? '')
            );
            $this->addSummaryLog(sprintf('ISBN invalide: %s', $e->getMessage()));
            $this->notCosmetic = true;

            // TODO log file ISBNinvalide
            return;
        }

        // Si $isbn13 et 'isbn2' correspond à ISBN-13 => suppression
        if (isset($isbn13)
            && $this->hasParamValue('isbn2')

It seems like hasParamValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            && $this->stripIsbn($this->getParam('isbn2')) === $this->stripIsbn($isbn13)
        ) {
            $this->unsetParam('isbn2');

It seems like unsetParam() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        // ISBN-10 ?
        $stripIsbn = $this->stripIsbn($isbn);
        if (10 === mb_strlen($stripIsbn)) {
            // ajout des tirets
            $isbn10pretty = $isbn;

            try {
                $isbn10pretty = $isbnMachine->format('ISBN-10');
            } catch (Throwable $e) {
                unset($e);
            }

            // archivage ISBN-10 dans 'isbn2'
            if (!$this->getParam('isbn2')) {
                $this->setParam('isbn2', $isbn10pretty);
            }
            // sinon dans 'isbn3'
            if ($this->hasParamValue('isbn2')
                && $this->stripIsbn($this->getParam('isbn2')) !== $stripIsbn
                && empty($this->getParam('isbn3'))
            ) {
                $this->setParam('isbn3', $isbn10pretty);
            }
            // delete 'isbn10' (en attendant modification modèle)
            if ($this->hasParamValue('isbn10') && $this->stripIsbn($this->getParam('isbn10')) === $stripIsbn) {
                $this->unsetParam('isbn10');
            }
        }

        // ISBN correction
        if ($isbn13 !== $isbn) {
            $this->setParam('isbn', $isbn13);
            $this->addSummaryLog('ISBN');
            //            $this->notCosmetic = true;
        }
    }
}