BnfFromIsbnHandler::__construct() - Code Metrics - Inspection of "refac OuvrageOptimizer (handlers)" - Dispositif/Wikibot - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9e3ea7...ee24dc )

by Dispositif

created 2023-04-28 17:05 UTC

BnfFromIsbnHandler::__construct() A

↳ Parent: BnfFromIsbnHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	3
c	1
b	0
f	0
dl	0
loc	5
rs	10
cc	1
nc	1
nop	3

<?php
/*
 * This file is part of dispositif/wikibot application (@github)
 * 2019-2023 © Philippe M./Irønie  <[email protected]>
 * For the full copyright and MIT license information, view the license file.
 */

declare(strict_types=1);

namespace App\Application\OuvrageComplete\Handlers;

use App\Domain\Models\Wiki\OuvrageTemplate;
use App\Domain\OuvrageFactory;
use Psr\Log\LoggerInterface;
use Throwable;

class BnfFromIsbnHandler implements CompleteHandlerInterface
{

    /**
     * @var string
     */
    protected $isbn;
    /**
     * @var string|null
     */
    protected $isbn10;
    /**
     * @var LoggerInterface
     */
    protected $logger;

    public function __construct(string $isbn, ?string $isbn10, LoggerInterface $logger)
    {
        $this->isbn = $isbn;
        $this->isbn10 = $isbn10;
        $this->logger = $logger;
    }

    public function handle(): ?OuvrageTemplate
    {
        try {
            $this->logger->debug('BIBLIO NAT FRANCE...');
            // BnF sait pas trouver un vieux livre (10) d'après ISBN-13... FACEPALM !
            $bnfOuvrage = null;
            if ($this->isbn10) {
                $bnfOuvrage = OuvrageFactory::BnfFromIsbn($this->isbn10);
                sleep(2);
            }
            if (!$this->isbn10 || null === $bnfOuvrage || empty($bnfOuvrage->getParam('titre'))) {
                $bnfOuvrage = OuvrageFactory::BnfFromIsbn($this->isbn);
            }

        } catch (Throwable $e) {
            if (strpos($e->getMessage(), 'Could not resolve host') !== false) {
                throw $e;
            }
            $this->logger->error(sprintf(
                "*** ERREUR BnF Isbn Search %s %s %s \n",
                $e->getMessage(),
                $e->getFile(),
                $e->getLine()
            ));

            return null;
        }

        return $bnfOuvrage instanceof OuvrageTemplate ? $bnfOuvrage : null;

    }
}

1			<?php
2			/*
3			* This file is part of dispositif/wikibot application (@github)
4			* 2019-2023 © Philippe M./Irønie <[email protected]>
5			* For the full copyright and MIT license information, view the license file.
6			*/
7
8			declare(strict_types=1);
9
10			namespace App\Application\OuvrageComplete\Handlers;
11
12			use App\Domain\Models\Wiki\OuvrageTemplate;
13			use App\Domain\OuvrageFactory;
14			use Psr\Log\LoggerInterface;
15			use Throwable;
16
17			class BnfFromIsbnHandler implements CompleteHandlerInterface
18			{
19
20			/**
21			* @var string
22			*/
23			protected $isbn;
24			/**
25			* @var string\|null
26			*/
27			protected $isbn10;
28			/**
29			* @var LoggerInterface
30			*/
31			protected $logger;
32
33			public function __construct(string $isbn, ?string $isbn10, LoggerInterface $logger)
34			{
35			$this->isbn = $isbn;
36			$this->isbn10 = $isbn10;
37			$this->logger = $logger;
38			}
39
40			public function handle(): ?OuvrageTemplate
41			{
42			try {
43			$this->logger->debug('BIBLIO NAT FRANCE...');
44			// BnF sait pas trouver un vieux livre (10) d'après ISBN-13... FACEPALM !
45			$bnfOuvrage = null;
46			if ($this->isbn10) {
47			$bnfOuvrage = OuvrageFactory::BnfFromIsbn($this->isbn10);
48			sleep(2);
49			}
50			if (!$this->isbn10 \|\| null === $bnfOuvrage \|\| empty($bnfOuvrage->getParam('titre'))) {
51			$bnfOuvrage = OuvrageFactory::BnfFromIsbn($this->isbn);
52			}
53
54			} catch (Throwable $e) {
55			if (strpos($e->getMessage(), 'Could not resolve host') !== false) {
56			throw $e;
57			}
58			$this->logger->error(sprintf(
59			"*** ERREUR BnF Isbn Search %s %s %s \n",
60			$e->getMessage(),
61			$e->getFile(),
62			$e->getLine()
63			));
64
65			return null;
66			}
67
68			return $bnfOuvrage instanceof OuvrageTemplate ? $bnfOuvrage : null;
			0 ignored issues – show introduced 2023-04-28 12:49 UTC by Report Bug Copy Issue Report `$bnfOuvrage` is always a sub-type of `App\Domain\Models\Wiki\OuvrageTemplate`. Loading history...
69			}
70			}

Dispositif / Wikibot

Push — master ( 9e3ea7...ee24dc )

BnfFromIsbnHandler::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like