App\Application\OuvrageEdit\OuvrageEditWorker::pageProcess()

Complexity

Conditions	18
Paths	14

Size

Total Lines	110
Code Lines	64

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function pageProcess(): bool
    {
        $e = null;

The assignment to $e is dead and can be removed.

        $this->pageWorkStatus = new PageWorkStatus();

        if ((new TalkStopValidator($this->bot))->validate() === false) {

The condition new App\Application\OuvrageEdit\Validators\TalkStopValidator($this->bot)->validate() === false is always false.

            return false;
        }

        // get a random queue line
        $json = $this->db->getAllRowsOfOneTitleToEdit(self::CITATION_LIMIT);
        $pageCitationCollection = json_decode($json, true, 512, JSON_THROW_ON_ERROR);

It seems like $json can also be of type null; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

        if ((new CitationsNotEmptyValidator($pageCitationCollection, $this->log))->validate() === false) {

The condition new App\Application\OuvrageEdit\Validators\CitationsNotEmptyValidator($pageCitationCollection, $this->log)->validate() === false is always false.

            return false;
        }

        $title = $pageCitationCollection[0]['page']; // not used by validators
        $this->pageWorkStatus->title = $title;
        $this->printTitle($title);

        // Find on wikipedia the page to edit
        try {
            $this->wikiPageAction = ServiceFactory::wikiPageAction($title); // , true ?
        } catch (Exception $e) {
            $this->log->warning("*** WikiPageAction error : " . $title . " \n");
            sleep(20);

            return false;
        }
        $pageValidator = new PageValidatorComposite(
            $this->bot,
            $pageCitationCollection,
            $this->db,
            $this->wikiPageAction
        );
        if ($pageValidator->validate() === false) {
            return false;
        }

        $this->pageWorkStatus->wikiText = $this->wikiPageAction->getText();
        // or do that at the end of ArticleValidForEditValidator if PageWorkStatus injected ?

        $this->checkArticleLabels($title);
        // or do that at the end of ArticleValidForEditValidator if PageWorkStatus injected ?

        // print total number of rows completed in db
        $this->log->info(sprintf("%s rows to process\n", is_countable($pageCitationCollection) ? count($pageCitationCollection) : 0));


        // foreach line
        $changed = false;
        foreach ($pageCitationCollection as $dat) {
            if (!$this->isAllCitationCompleted($dat)) {
                $this->log->notice("SKIP : Amélioration incomplet de l'article. sleep 10min");
                sleep(600);

                return false;
            }
            $success = $this->processOneCitation($dat);
            $changed = ($success) ? true : $changed;
        }
        if (!$changed) {
            $this->log->debug("Rien à changer...");
            $this->db->skipArticle($title);

The method skipArticle() does not exist on App\Application\InfrastructurePorts\DbAdapterInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to App\Application\InfrastructurePorts\DbAdapterInterface.

            return false;
        }


        // EDIT THE PAGE
        if (!(new WikiTextValidator($this->pageWorkStatus->wikiText))->validate()) {
            return false;
        }

        $miniSummary = $this->generateFinalSummary();
        $this->log->notice($miniSummary);
        $this->log->debug("sleep 2...");
        sleep(2); // todo ???

        dump($miniSummary);
        die("\n*** STOP ON OuvrageEditWorker:191 FOR REFACTORING ***\n");

In this branch, the function will implicitly return null which is incompatible with the type-hinted return boolean. Consider adding a return statement or allowing null as return value.

Using exit here is not recommended.

        $success = $this->editPage($miniSummary);

$success = $this->editPage($miniSummary) is not reachable.

        if ($success) {
            // updata DB
            foreach ($pageCitationCollection as $dat) {
                $this->db->sendEditedData(['id' => $dat['id']]);
            }

            try {
                if (self::EDIT_SIGNALEMENT && !empty($this->pageWorkStatus->errorWarning[$title])) {
                    $this->sendOuvrageErrorsOnTalkPage($pageCitationCollection, $this->log);
                }
            } catch (Throwable $e) {
                $this->log->warning('Exception in editPage() ' . $e->getMessage());
                unset($e);
            }

            if (!$this->pageWorkStatus->botFlag) {
                $this->log->debug("sleep " . self::DELAY_NO_BOTFLAG_SECONDS);
                sleep(self::DELAY_NO_BOTFLAG_SECONDS);
            }
            if ($this->pageWorkStatus->botFlag) {
                $this->log->debug("sleep " . self::DELAY_BOTFLAG_SECONDS);
                sleep(self::DELAY_BOTFLAG_SECONDS);
            }
        }

        return $success;
    }