App\Application\OuvrageEdit\Validators\ArticleRestrictedValidator

Complexity

Total Complexity

3

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	validate()	0	11	2

<?php
/*
 * This file is part of dispositif/wikibot application (@github)
 * 2019-2023 © Philippe M./Irønie  <dispositif@gmail.com>
 * For the full copyright and MIT license information, view the license file.
 */

declare(strict_types=1);


namespace App\Application\OuvrageEdit\Validators;


use App\Application\InfrastructurePorts\DbAdapterInterface;
use App\Application\WikiBotConfig;
use App\Application\WikiPageAction;
use Psr\Log\LoggerInterface;

class ArticleRestrictedValidator implements ValidatorInterface
{
    /**
     * @var DbAdapterInterface
     */
    protected $db;
    /**
     * @var LoggerInterface
     */
    protected $log;
    /**
     * @var string
     */
    protected $title;
    /**
     * @var WikiPageAction
     */
    protected $wikiPageAction;

    public function __construct(string $title, LoggerInterface $logger, DbAdapterInterface $db, WikiPageAction $wikiPageAction)
    {
        $this->title = $title;
        $this->log = $logger;
        $this->db = $db;
        $this->wikiPageAction = $wikiPageAction;
    }

    public function validate(): bool
    {
        if (WikiBotConfig::isEditionTemporaryRestrictedOnWiki($this->wikiPageAction->getText())) {

It seems like $this->wikiPageAction->getText() can also be of type null; however, parameter $text of App\Application\WikiBotConfig::isEditionTemporaryRestrictedOnWiki() does only seem to accept string, maybe add an additional type check?

            // new feature ? Gestion d'une repasse dans X jours
            $this->log->info("SKIP : protection/3R/travaux.\n");
            $this->db->skipArticle($this->title);

The method skipArticle() does not exist on App\Application\InfrastructurePorts\DbAdapterInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to App\Application\InfrastructurePorts\DbAdapterInterface.

            return false;
        }

        return true;
    }
}