DigitalState /
Identities
| Conditions | 17 |
| Paths | 4 |
| Total Lines | 89 |
| Code Lines | 67 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 57 | public function validate($role, Constraint $constraint) |
||
| 58 | { |
||
| 59 | foreach ($role->getPermissions() as $service => $permissions) { |
||
| 60 | try { |
||
| 61 | $this->api->get($service.'.access'); |
||
| 62 | } catch (OutOfRangeException $exception) { |
||
| 63 | $this->context |
||
| 64 | ->buildViolation($constraint->serviceUndefined) |
||
| 65 | ->setParameter('{{ service }}', '"' . $service . '"') |
||
| 66 | ->atPath('permissions.' . $service) |
||
| 67 | ->addViolation(); |
||
| 68 | |||
| 69 | continue; |
||
| 70 | } |
||
| 71 | |||
| 72 | if (!is_array($permissions)) { |
||
| 73 | $this->context |
||
| 74 | ->buildViolation($constraint->permissionsNotArray) |
||
| 75 | ->setParameter('{{ service }}', '"'.$service.'"') |
||
| 76 | ->atPath('permissions.'.$service) |
||
| 77 | ->addViolation(); |
||
| 78 | |||
| 79 | continue; |
||
| 80 | } |
||
| 81 | |||
| 82 | foreach ($permissions as $index => $permission) { |
||
| 83 | if (!is_array($permission)) { |
||
| 84 | $this->context |
||
| 85 | ->buildViolation($constraint->permissionNotObject) |
||
| 86 | ->setParameter('{{ service }}', '"'.$service.'"') |
||
| 87 | ->atPath('permissions.'.$service.'['.$index.']') |
||
| 88 | ->addViolation(); |
||
| 89 | |||
| 90 | continue; |
||
| 91 | } |
||
| 92 | |||
| 93 | foreach (['scope', 'entity', 'entityUuid', 'permissions'] as $attribute) { |
||
| 94 | if (!array_key_exists($attribute, $permission)) { |
||
| 95 | $this->context |
||
| 96 | ->buildViolation($constraint->permissionAttributeMissing) |
||
| 97 | ->setParameter('{{ service }}', '"'.$service.'"') |
||
| 98 | ->setParameter('{{ attribute }}', '"'.$attribute.'"') |
||
| 99 | ->atPath('permissions.'.$service.'['.$index.'].'.$attribute) |
||
| 100 | ->addViolation(); |
||
| 101 | } |
||
| 102 | |||
| 103 | if ('permissions' === $attribute) { |
||
| 104 | if (!is_array($permission['permissions'])) { |
||
| 105 | $this->context |
||
| 106 | ->buildViolation($constraint->subpermissionsNotArray) |
||
| 107 | ->setParameter('{{ service }}', '"'.$service.'"') |
||
| 108 | ->atPath('permissions.'.$service.'['.$index.'].permissions') |
||
| 109 | ->addViolation(); |
||
| 110 | |||
| 111 | continue; |
||
| 112 | } |
||
| 113 | |||
| 114 | foreach ($permission['permissions'] as $subindex => $subpermission) { |
||
| 115 | if (!is_array($subpermission)) { |
||
| 116 | $this->context |
||
| 117 | ->buildViolation($constraint->subpermissionNotObject) |
||
| 118 | ->setParameter('{{ service }}', '"'.$service.'"') |
||
| 119 | ->atPath('permissions.'.$service.'['.$index.'].permissions['.$subindex.']') |
||
| 120 | ->addViolation(); |
||
| 121 | |||
| 122 | continue; |
||
| 123 | } |
||
| 124 | |||
| 125 | foreach (['key', 'attributes'] as $subattribute) { |
||
| 126 | if (!array_key_exists($subattribute, $subpermission)) { |
||
| 127 | $this->context |
||
| 128 | ->buildViolation($constraint->subpermissionAttributeMissing) |
||
| 129 | ->setParameter('{{ service }}', '"'.$service.'"') |
||
| 130 | ->setParameter('{{ attribute }}', '"'.$subattribute.'"') |
||
| 131 | ->atPath('permissions.'.$service.'['.$index.'].'.$attribute.'['.$subindex.'].'.$subattribute) |
||
| 132 | ->addViolation(); |
||
| 133 | |||
| 134 | continue; |
||
| 135 | } |
||
| 136 | |||
| 137 | if ('attributes' === $subattribute) { |
||
| 138 | foreach ($subpermission['attributes'] as $item) { |
||
| 139 | if (!in_array($item, [Permission::BROWSE, Permission::READ, Permission::EDIT, Permission::ADD, Permission::DELETE, Permission::EXECUTE])) { |
||
| 140 | $this->context |
||
| 141 | ->buildViolation($constraint->subpermissionUndefined) |
||
| 142 | ->setParameter('{{ service }}', '"'.$service.'"') |
||
| 143 | ->setParameter('{{ attribute }}', '"'.$item.'"') |
||
| 144 | ->atPath('permissions.'.$service.'['.$index.'].'.$attribute.'['.$subindex.'].attributes') |
||
| 145 | ->addViolation(); |
||
| 146 | } |
||
| 157 |
