OrganizationProvider::loadUserByOAuthUserResponse() - Code Metrics - Inspection of "Add data templates for oauth-based registrations" - DigitalState/Authentication - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( a295c8...769ac9 )

by Mario

created 2018-07-18 15:45 UTC

loadUserByOAuthUserResponse() B

↳ Parent: OrganizationProvider

Complexity

Conditions	7
Paths	7

Size

Total Lines	68
Code Lines	49

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	49
nc	7
nop	1
dl	0
loc	68
rs	8.1793
c	0
b	0
f	0

How to fix Long Method

<?php

namespace AppBundle\Security\Provider\OAuth;

use AppBundle\Entity\OAuth;
use AppBundle\Service\OAuthService;
use AppBundle\Service\RegistrationService;
use Ds\Component\Config\Service\ConfigService;
use Ds\Component\Identity\Model\Identity;
use Exception;
use FOS\UserBundle\Model\UserManagerInterface;
use HWI\Bundle\OAuthBundle\OAuth\Response\UserResponseInterface;
use HWI\Bundle\OAuthBundle\Security\Core\Exception\AccountNotLinkedException;
use HWI\Bundle\OAuthBundle\Security\Core\User\FOSUBUserProvider;
use Symfony\Component\Security\Core\User\UserInterface;

/**
 * Class OrganizationProvider
 */
class OrganizationProvider extends FOSUBUserProvider
{
    /**
     * @var \AppBundle\Service\OAuthService
     */
    protected $oAuthService;

    /**
     * @var \AppBundle\Service\RegistrationService
     */
    protected $registrationService;

    /**
     * @var \Ds\Component\Config\Service\ConfigService
     */
    protected $configService;

    /**
     * Constructor
     *
     * @param \FOS\UserBundle\Model\UserManagerInterface $userManager
     * @param array $properties
     * @param \AppBundle\Service\OAuthService $oAuthService
     * @param \AppBundle\Service\RegistrationService $registrationService
     * @param \Ds\Component\Config\Service\ConfigService $configService
     */
    public function __construct(UserManagerInterface $userManager, array $properties, OAuthService $oAuthService, RegistrationService $registrationService, ConfigService $configService)
    {
        parent::__construct($userManager, $properties);
        $this->oAuthService = $oAuthService;
        $this->registrationService = $registrationService;
        $this->configService = $configService;
    }

    /**
     * {@inheritdoc}
     */
    public function loadUserByOAuthUserResponse(UserResponseInterface $response)
    {
        $oAuth = $this->oAuthService->getRepository()->findOneBy([
            'type' => $response->getResourceOwner()->getName(),
            'identifier' => $response->getUsername()
        ]);

        if ($oAuth) {
            $oAuth->setToken($response->getAccessToken());
            $user = $oAuth->getUser();
        } else {
            $email = $response->getEmail();

            if (null === $email) {
                throw new AccountNotLinkedException('Email is not defined.');
            }

            $user = $this->userManager->findUserByUsernameOrEmail($response->getEmail());

            if ($user) {

                throw new AccountNotLinkedException('Username is not available.');
            }

            $owner = substr($response->getResourceOwner()->getName(), 13);
            $data = [
                '%email%' => $response->getEmail(),
                '%firstName%' => $response->getFirstName(),
                '%lastName%' => $response->getLastName()
            ];

            switch ($owner) {
                case 'github':
                    break;

                case 'google':
                    break;

                case 'twitter':
                    break;
            }

            $registration = $this->registrationService->createInstance();
            $registration
                ->setOwner($this->configService->get('app.registration.organization.owner.type'))
                ->setOwnerUuid($this->configService->get('app.registration.organization.owner.uuid'))
                ->setIdentity(Identity::ORGANIZATION)
                ->setUsername($email)
                ->setPassword(sha1(uniqid().microtime()))
                ->setData(json_decode(strtr($this->configService->get('app.registration.organization.data.'.$owner), $data), true));
            $manager = $this->registrationService->getManager();
            $manager->persist($registration);
            $manager->flush();
            $user = $registration->getUser();
            $oAuth = new OAuth;
            $oAuth
                ->setUser($user)
                ->setType($response->getResourceOwner()->getName())
                ->setIdentifier($response->getUsername())
                ->setToken($response->getAccessToken())
                ->setOwner($registration->getOwner())
                ->setOwnerUuid($registration->getOwnerUuid());
        }

        $manager = $this->oAuthService->getManager();
        $manager->persist($oAuth);
        $manager->flush();

        return $user;
    }

    /**
     * {@inheritDoc}
     */
    public function connect(UserInterface $user, UserResponseInterface $response)
    {
        throw new Exception('Not yet implemented.');
    }

    /**
     * {@inheritDoc}
     */
    public function disconnect(UserInterface $user, UserResponseInterface $response)
    {
        throw new Exception('Not yet implemented.');
    }

    /**
     * {@inheritdoc}
     */
    public function refreshUser(UserInterface $user)
    {
        throw new Exception('Not yet implemented.');
    }
}


1			<?php
2
3			namespace AppBundle\Security\Provider\OAuth;
4
5			use AppBundle\Entity\OAuth;
6			use AppBundle\Service\OAuthService;
7			use AppBundle\Service\RegistrationService;
8			use Ds\Component\Config\Service\ConfigService;
9			use Ds\Component\Identity\Model\Identity;
10			use Exception;
11			use FOS\UserBundle\Model\UserManagerInterface;
12			use HWI\Bundle\OAuthBundle\OAuth\Response\UserResponseInterface;
13			use HWI\Bundle\OAuthBundle\Security\Core\Exception\AccountNotLinkedException;
14			use HWI\Bundle\OAuthBundle\Security\Core\User\FOSUBUserProvider;
15			use Symfony\Component\Security\Core\User\UserInterface;
16
17			/**
18			* Class OrganizationProvider
19			*/
20			class OrganizationProvider extends FOSUBUserProvider
21			{
22			/**
23			* @var \AppBundle\Service\OAuthService
24			*/
25			protected $oAuthService;
26
27			/**
28			* @var \AppBundle\Service\RegistrationService
29			*/
30			protected $registrationService;
31
32			/**
33			* @var \Ds\Component\Config\Service\ConfigService
34			*/
35			protected $configService;
36
37			/**
38			* Constructor
39			*
40			* @param \FOS\UserBundle\Model\UserManagerInterface $userManager
41			* @param array $properties
42			* @param \AppBundle\Service\OAuthService $oAuthService
43			* @param \AppBundle\Service\RegistrationService $registrationService
44			* @param \Ds\Component\Config\Service\ConfigService $configService
45			*/
46			public function __construct(UserManagerInterface $userManager, array $properties, OAuthService $oAuthService, RegistrationService $registrationService, ConfigService $configService)
47			{
48			parent::__construct($userManager, $properties);
49			$this->oAuthService = $oAuthService;
50			$this->registrationService = $registrationService;
51			$this->configService = $configService;
52			}
53
54			/**
55			* {@inheritdoc}
56			*/
57			public function loadUserByOAuthUserResponse(UserResponseInterface $response)
58			{
59			$oAuth = $this->oAuthService->getRepository()->findOneBy([
60			'type' => $response->getResourceOwner()->getName(),
61			'identifier' => $response->getUsername()
62			]);
63
64			if ($oAuth) {
65			$oAuth->setToken($response->getAccessToken());
66			$user = $oAuth->getUser();
67			} else {
68			$email = $response->getEmail();
69
70			if (null === $email) {
71			throw new AccountNotLinkedException('Email is not defined.');
72			}
73
74			$user = $this->userManager->findUserByUsernameOrEmail($response->getEmail());
75
76			if ($user) {
			0 ignored issues – show introduced 2018-07-11 19:05 UTC by Report Bug Copy Issue Report `$user` is of type `FOS\UserBundle\Model\UserInterface`, thus it always evaluated to `true`. Loading history...
77			throw new AccountNotLinkedException('Username is not available.');
78			}
79
80			$owner = substr($response->getResourceOwner()->getName(), 13);
81			$data = [
82			'%email%' => $response->getEmail(),
83			'%firstName%' => $response->getFirstName(),
84			'%lastName%' => $response->getLastName()
85			];
86
87			switch ($owner) {
88			case 'github':
89			break;
90
91			case 'google':
92			break;
93
94			case 'twitter':
95			break;
96			}
97
98			$registration = $this->registrationService->createInstance();
99			$registration
100			->setOwner($this->configService->get('app.registration.organization.owner.type'))
101			->setOwnerUuid($this->configService->get('app.registration.organization.owner.uuid'))
102			->setIdentity(Identity::ORGANIZATION)
103			->setUsername($email)
104			->setPassword(sha1(uniqid().microtime()))
105			->setData(json_decode(strtr($this->configService->get('app.registration.organization.data.'.$owner), $data), true));
106			$manager = $this->registrationService->getManager();
107			$manager->persist($registration);
108			$manager->flush();
109			$user = $registration->getUser();
110			$oAuth = new OAuth;
111			$oAuth
112			->setUser($user)
113			->setType($response->getResourceOwner()->getName())
114			->setIdentifier($response->getUsername())
115			->setToken($response->getAccessToken())
116			->setOwner($registration->getOwner())
117			->setOwnerUuid($registration->getOwnerUuid());
118			}
119
120			$manager = $this->oAuthService->getManager();
121			$manager->persist($oAuth);
122			$manager->flush();
123
124			return $user;
125			}
126
127			/**
128			* {@inheritDoc}
129			*/
130			public function connect(UserInterface $user, UserResponseInterface $response)
131			{
132			throw new Exception('Not yet implemented.');
133			}
134
135			/**
136			* {@inheritDoc}
137			*/
138			public function disconnect(UserInterface $user, UserResponseInterface $response)
139			{
140			throw new Exception('Not yet implemented.');
141			}
142
143			/**
144			* {@inheritdoc}
145			*/
146			public function refreshUser(UserInterface $user)
147			{
148			throw new Exception('Not yet implemented.');
149			}
150			}
151

DigitalState / Authentication

Push — develop ( a295c8...769ac9 )

loadUserByOAuthUserResponse() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like