WP2D_Post::post() - Code Metrics - Inspection of "Version 2.1.0" - DiasPHPora/wp-to-diaspora - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 48f45b...559f84 )

by Armando
created 2017-11-17 22:36 UTC
WP2D_Post::post() C

↳ Parent: WP2D_Post
Complexity

Conditions	10
Paths	14
Size

Total Lines	70
Code Lines	33
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
dl	0
loc	70
rs	5.9999
c	0
b	0
f	0
cc	10
eloc	33
nc	14
nop	2
How to fix Long Method Complexity

<?php

/**
 * A diaspora* flavoured WP Post class.
 *
 * @package WP_To_Diaspora\Post
 * @since   1.5.0
 */

// Exit if accessed directly.
defined( 'ABSPATH' ) || exit;

use League\HTMLToMarkdown\HtmlConverter;

/**
 * Custom diaspora* post class to manage all post related things.
 *
 * @since 1.5.0
 */
class WP2D_Post {
namespace YourVendor;

class YourClass { }

	/**
	 * The original post object.
	 *
	 * @var WP_Post
	 * @since 1.5.0
	 */
	public $post;

	/**
	 * The original post ID.
	 *
	 * @var int
	 * @since 1.5.0
	 */
	public $ID;

	/**
	 * If this post should be shared on diaspora*.
	 *
	 * @var bool
	 * @since 1.5.0
	 */
	public $post_to_diaspora;

	/**
	 * If a link back to the original post should be added.
	 *
	 * @var bool
	 * @since 1.5.0
	 */
	public $fullentrylink;

	/**
	 * What content gets posted.
	 *
	 * @var string
	 * @since 1.5.0
	 */
	public $display;

	/**
	 * The types of tags to post. (global,custom,post)
	 *
	 * @var array
	 * @since 1.5.0
	 */
	public $tags_to_post;

	/**
	 * The post's custom tags.
	 *
	 * @var array
	 * @since 1.5.0
	 */
	public $custom_tags;

	/**
	 * Aspects this post gets posted to.
	 *
	 * @var array
	 * @since 1.5.0
	 */
	public $aspects;

	/**
	 * Services this post gets posted to.
	 *
	 * @var array
	 * @since 1.5.0
	 */
	public $services;

	/**
	 * The post's history of diaspora* posts.
	 *
	 * @var array
	 * @since 1.5.0
	 */
	public $post_history;

	/**
	 * If the post actions have all been set up already.
	 *
	 * @var boolean
	 * @since 1.5.0
	 */
	private static $_is_set_up = false;

	/**
	 * Setup all the necessary WP callbacks.
	 *
	 * @since 1.5.0
	 */
	public static function setup() {
		if ( self::$_is_set_up ) {
			return;
		}

		$instance = new WP2D_Post( null );

		// Notices when a post has been shared or if it has failed.
		add_action( 'admin_notices', [ $instance, 'admin_notices' ] );
		add_action( 'admin_init', [ $instance, 'ignore_post_error' ] );

		// Handle diaspora* posting when saving the post.
		add_action( 'save_post', [ $instance, 'post' ], 20, 2 );
		add_action( 'save_post', [ $instance, 'save_meta_box_data' ], 10 );

		// Add meta boxes.
		add_action( 'add_meta_boxes', [ $instance, 'add_meta_boxes' ] );

		self::$_is_set_up = true;
	}

	/**
	 * Constructor.
	 *
	 * @since 1.5.0
	 *
	 * @param int|WP_Post $post Post ID or the post itself.
	 */
	public function __construct( $post ) {
		$this->_assign_wp_post( $post );
	}

	/**
	 * Assign the original WP_Post object and all the custom meta data.
	 *
	 * @since 1.5.0
	 *
	 * @param int|WP_Post $post Post ID or the post itself.
	 */
	private function _assign_wp_post( $post ) {
		if ( $this->post = get_post( $post ) ) {
			$this->ID = $this->post->ID;

			$options = WP2D_Options::instance();

			// Assign all meta values, expanding non-existent ones with the defaults.
			$meta_current = get_post_meta( $this->ID, '_wp_to_diaspora', true );
			$meta         = wp_parse_args(
				$meta_current,
				$options->get_options()
			);
			if ( $meta ) {
				foreach ( $meta as $key => $value ) {
					$this->$key = $value;
				}
			}

			// If no WP2D meta data has been saved yet, this post shouldn't be published.
			// This can happen if existing posts (before WP2D) get updated externally, not through the post edit screen.
			// Check DiasPHPora/wp-to-diaspora#91 for reference.
			// Also, when we have a post scheduled for publishing, don't touch it.
			// This is important when modifying scheduled posts using Quick Edit.
			if ( ! $meta_current && ! in_array( $this->post->post_status, [ 'auto-draft', 'future' ], true ) ) {
				$this->post_to_diaspora = false;
			}

			$this->post_history = get_post_meta( $this->ID, '_wp_to_diaspora_post_history', true );
		}
	}

	/**
	 * Post to diaspora* when saving a post.
	 *
	 * @since 1.5.0
	 *
	 * @todo  Maybe somebody wants to share a password protected post to a closed aspect.
	 *
	 * @param integer $post_id ID of the post being saved.
	 * @param WP_Post $post    Post object being saved.
	 *
	 * @return bool If the post was posted successfully.
	 */
	public function post( $post_id, $post ) {
		$this->_assign_wp_post( $post );

		$options = WP2D_Options::instance();

		// Is this post type enabled for posting?
		if ( ! in_array( $post->post_type, $options->get_option( 'enabled_post_types' ), true ) ) {
			return false;
		}

		// Make sure we're posting to diaspora* and the post isn't password protected.
		if ( ! ( $this->post_to_diaspora && 'publish' === $post->post_status && '' === $post->post_password ) ) {
			return false;
		}

		$status_message = $this->_get_title_link();

		// Post the full post text, just the excerpt, or nothing at all?
		if ( 'full' === $this->display ) {
			$status_message .= $this->_get_full_content();
		} elseif ( 'excerpt' === $this->display ) {
			$status_message .= $this->_get_excerpt_content();
		}

		// Add the tags assigned to the post.
		$status_message .= $this->_get_tags_to_add();

		// Add the original entry link to the post?
		$status_message .= $this->_get_posted_at_link();

		$status_converter = new HtmlConverter( [ 'strip_tags' => true ] );
		$status_message   = $status_converter->convert( $status_message );

		// Set up the connection to diaspora*.
		$api = WP2D_Helpers::api_quick_connect();
		if ( empty( $status_message ) ) {
			return false;
		}

		if ( $api->has_last_error() ) {
			// Save the post error as post meta data, so we can display it to the user.
			update_post_meta( $post_id, '_wp_to_diaspora_post_error', $api->get_last_error() );

			return false;
		}

		// Add services to share to via diaspora*.
		$extra_data = [
			'services' => $this->services,
		];

		// Try to post to diaspora*.
		$response = $api->post( $status_message, $this->aspects, $extra_data );
		if ( ! $response ) {
			return false;
		}

		// Save certain diaspora* post data as meta data for future reference.
		$this->_save_to_history( (object) $response );

		// If there is still a previous post error around, remove it.
		delete_post_meta( $post_id, '_wp_to_diaspora_post_error' );

		// Unset post_to_diaspora meta field to prevent mistakenly republishing to diaspora*.
		$meta                     = get_post_meta( $post_id, '_wp_to_diaspora', true );
		$meta['post_to_diaspora'] = false;
		update_post_meta( $post_id, '_wp_to_diaspora', $meta );

		return true;
	}

	/**
	 * Get the title of the post linking to the post itself.
	 *
	 * @since 1.5.0
	 *
	 * @return string Post title as a link.
	 */
	private function _get_title_link() {
		$title      = esc_html( $this->post->post_title );
		$permalink  = get_permalink( $this->ID );
		$title_link = sprintf( '<strong><a href="%2$s" title="%2$s">%1$s</a></strong>', $title, $permalink );

		/**
		 * Filter the title link at the top of the post.
		 *
		 * @since 1.5.4.1
		 *
		 * @param string    $default   The whole HTML of the title link to be outputted.
		 * @param WP2D_Post $wp2d_post This object, to allow total customisation of the title.
		 */
		return apply_filters( 'wp2d_title_filter', "<p>{$title_link}</p>", $this );
	}

	/**
	 * Get the full post content with only default filters applied.
	 *
	 * @since 1.5.0
	 *
	 * @return string The full post content.
	 */
	private function _get_full_content() {
		// Only allow certain shortcodes.
		global $shortcode_tags;
function myFunction($a, $b) {
    // Do something
}
		$shortcode_tags_bkp = [];

		foreach ( $shortcode_tags as $shortcode_tag => $shortcode_function ) {
			if ( ! in_array( $shortcode_tag, apply_filters( 'wp2d_shortcodes_filter', [ 'wp_caption', 'caption', 'gallery' ] ), true ) ) {
				$shortcode_tags_bkp[ $shortcode_tag ] = $shortcode_function;
				unset( $shortcode_tags[ $shortcode_tag ] );
			}
		}

		// Disable all filters and then enable only defaults. This prevents additional filters from being posted to diaspora*.
		remove_all_filters( 'the_content' );

		/** @var array $content_filters */
		$content_filters = apply_filters( 'wp2d_content_filters_filter', [ 'do_shortcode', 'wptexturize', 'convert_smilies', 'convert_chars', 'wpautop', 'shortcode_unautop', 'prepend_attachment', [ $this, 'embed_remove' ] ] );
		foreach ( $content_filters as $filter ) {
			add_filter( 'the_content', $filter );
		}

		// Extract URLs from [embed] shortcodes.
		add_filter( 'embed_oembed_html', [ $this, 'embed_url' ], 10, 2 );

		// Add the pretty caption after the images.
		add_filter( 'img_caption_shortcode', [ $this, 'custom_img_caption' ], 10, 3 );

		// Overwrite the native shortcode handler to add pretty captions.
		// http://wordpress.stackexchange.com/a/74675/54456 for explanation.
		add_shortcode( 'gallery', [ $this, 'custom_gallery_shortcode' ] );

		$post_content = apply_filters( 'the_content', $this->post->post_content );

		// Put the removed shortcode tags back again.
		$shortcode_tags += $shortcode_tags_bkp;

		/**
		 * Filter the full content of the post.
		 *
		 * @since 2.1.0
		 *
		 * @param string    $default   The whole HTML of the post to be outputted.
		 * @param WP2D_Post $wp2d_post This object, to allow total customisation of the post.
		 */
		return apply_filters( 'wp2d_post_filter', $post_content, $this );
	}

	/**
	 * Get the post's excerpt in a nice format.
	 *
	 * @since 1.5.0
	 *
	 * @return string Post's excerpt.
	 */
	private function _get_excerpt_content() {
		// Look for the excerpt in the following order:
		// 1. Custom post excerpt.
		// 2. Text up to the <!--more--> tag.
		// 3. Manually trimmed content.
		$content = $this->post->post_content;
		$excerpt = $this->post->post_excerpt;
		if ( '' === $excerpt ) {
			if ( $more_pos = strpos( $content, '<!--more' ) ) {
				$excerpt = substr( $content, 0, $more_pos );
			} else {
				$excerpt = wp_trim_words( $content, 42, '[...]' );
			}
		}

		/**
		 * Filter the excerpt of the post.
		 *
		 * @since 2.1.0
		 *
		 * @param string    $default   The whole HTML of the excerpt to be outputted.
		 * @param WP2D_Post $wp2d_post This object, to allow total customisation of the excerpt.
		 */
		return apply_filters( 'wp2d_excerpt_filter', "<p>{$excerpt}</p>", $this );
	}

	/**
	 * Get a string of tags that have been added to the post.
	 *
	 * @since 1.5.0
	 *
	 * @return string Tags added to the post.
	 */
	private function _get_tags_to_add() {
		$options       = WP2D_Options::instance();
		$tags_to_post  = $this->tags_to_post;
		$tags_to_add   = '';
		$diaspora_tags = [];

		// Add any diaspora* tags?
		if ( ! empty( $tags_to_post ) ) {
			// The diaspora* tags to add to the post.
			$diaspora_tags_tmp = [];

			// Add global tags?
			$global_tags = $options->get_option( 'global_tags' );
			if ( is_array( $global_tags ) && in_array( 'global', $tags_to_post, true ) ) {
				$diaspora_tags_tmp += array_flip( $global_tags );
			}

			// Add custom tags?
			if ( is_array( $this->custom_tags ) && in_array( 'custom', $tags_to_post, true ) ) {
				$diaspora_tags_tmp += array_flip( $this->custom_tags );
			}

			// Add post tags?
			$post_tags = wp_get_post_tags( $this->ID, [ 'fields' => 'slugs' ] );
			if ( is_array( $post_tags ) && in_array( 'post', $tags_to_post, true ) ) {
				$diaspora_tags_tmp += array_flip( $post_tags );
			}

			// Get an array of cleaned up tags.
			// NOTE: Validate method needs a variable, as it's passed by reference!
			$diaspora_tags_tmp = array_keys( $diaspora_tags_tmp );
			$options->validate_tags( $diaspora_tags_tmp );

			// Get all the tags and list them all nicely in a row.
			foreach ( $diaspora_tags_tmp as $tag ) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
				$diaspora_tags[] = '#' . $tag;
			}

			// Add all the found tags.
			if ( ! empty( $diaspora_tags ) ) {
				$tags_to_add = implode( ' ', $diaspora_tags ) . '<br/>';
			}
		}

		/**
		 * Filter the tags of the post.
		 *
		 * @since 2.1.0
		 *
		 * @param string    $default   The whole string of tags to be outputted.
		 * @param array     $tags      All tags that are assigned to this post.
		 * @param WP2D_Post $wp2d_post This object, to allow total customisation of the tags output.
		 */
		return apply_filters( 'wp2d_tags_filter', $tags_to_add, $diaspora_tags, $this );
	}

	/**
	 * Get the link to the original post.
	 *
	 * @since 1.5.0
	 *
	 * @return string Original post link.
	 */
	private function _get_posted_at_link() {
		if ( $this->fullentrylink ) {
			$prefix         = esc_html__( 'Originally posted at:', 'wp-to-diaspora' );
			$permalink      = get_permalink( $this->ID );
			$title          = esc_html__( 'Permalink', 'wp-to-diaspora' );
			$posted_at_link = sprintf( '%1$s <a href="%2$s" title="%3$s">%2$s</a>', $prefix, $permalink, $title );

			/**
			 * Filter the "Originally posted at" link at the bottom of the post.
			 *
			 * @since 1.5.4.1
			 *
			 * @param string    $default   The whole HTML of the text and link to be outputted.
			 * @param WP2D_Post $wp2d_post This object, to allow total customisation of the title.
			 * @param string    $prefix    The "Originally posted at:" prefix before the link.
			 */
			return apply_filters( 'wp2d_posted_at_link_filter', "<p>{$posted_at_link}</p>", $this, $prefix );
		}

		return '';
	}

	/**
	 * Save the details of the new diaspora* post to this post's history.
	 *
	 * @since 1.5.0
	 *
	 * @param object $response Response from the API containing the diaspora* post details.
	 */
	private function _save_to_history( $response ) {
		// Make sure the post history is an array.
		if ( empty( $this->post_history ) ) {
			$this->post_history = [];
		}

		// Add a new entry to the history.
		$this->post_history[] = [
			'id'         => $response->id,
			'guid'       => $response->guid,
			'created_at' => $this->post->post_modified,
			'aspects'    => $this->aspects,
			'nsfw'       => $response->nsfw,
			'post_url'   => $response->permalink,
		];

		update_post_meta( $this->ID, '_wp_to_diaspora_post_history', $this->post_history );
	}

	/**
	 * Return URL from [embed] shortcode instead of generated iframe.
	 *
	 * @since 1.5.0
	 * @see   WP_Embed::shortcode()
	 *
	 * @param mixed  $html The cached HTML result, stored in post meta.
	 * @param string $url  The attempted embed URL.
	 *
	 * @return string URL of the embed.
	 */
	public function embed_url( $html, $url ) {
		return $url;
	}

	/**
	 * Removes '[embed]' and '[/embed]' left by embed_url.
	 *
	 * @since 1.5.0
	 * @todo  It would be great to fix it using only one filter.
	 *       It's happening because embed filter is being removed by remove_all_filters('the_content') on WP2D_Post::post().
	 *
	 * @param string $content Content of the post.
	 *
	 * @return string The content with the embed tags removed.
	 */
	public function embed_remove( $content ) {
		return str_replace( [ '[embed]', '[/embed]' ], [ '<p>', '</p>' ], $content );
	}

	/**
	 * Prettify the image caption.
	 *
	 * @since 1.5.3
	 *
	 * @param string $caption Caption to be prettified.
	 *
	 * @return string Prettified image caption.
	 */
	public function get_img_caption( $caption ) {
		$caption = trim( $caption );
		if ( '' === $caption ) {
			return '';
		}

		/**
		 * Filter the image caption to be displayed after images with captions.
		 *
		 * @since 1.5.3
		 *
		 * @param string $default The whole HTML of the caption.
		 * @param string $caption The caption text.
		 */
		return apply_filters( 'wp2d_image_caption', "<blockquote>{$caption}</blockquote>", $caption );
	}

	/**
	 * Filter the default caption shortcode output.
	 *
	 * @since 1.5.3
	 * @see   img_caption_shortcode()
	 *
	 * @param string $empty   The caption output. Default empty.
	 * @param array  $attr    Attributes of the caption shortcode.
	 * @param string $content The image element, possibly wrapped in a hyperlink.
	 *
	 * @return string The caption shortcode output.
	 */
	public function custom_img_caption( $empty, $attr, $content ) {
		$content = do_shortcode( $content );

		// If a caption attribute is defined, we'll add it after the image.
		if ( isset( $attr['caption'] ) && '' !== $attr['caption'] ) {
			$content .= "\n" . $this->get_img_caption( $attr['caption'] );
		}

		return $content;
	}

	/**
	 * Create a custom gallery caption output.
	 *
	 * @since 1.5.3
	 *
	 * @param   array $attr Gallery attributes.
	 *
	 * @return  string
	 */
	public function custom_gallery_shortcode( $attr ) {
		// Default value in WordPress.
		$captiontag = current_theme_supports( 'html5', 'gallery' ) ? 'figcaption' : 'dd';

		// User value.
		if ( isset( $attr['captiontag'] ) ) {
			$captiontag = $attr['captiontag'];
		}

		// Let WordPress create the regular gallery.
		$gallery = gallery_shortcode( $attr );

		// Change the content of the captions.
		$gallery = preg_replace_callback(
			'~(<' . $captiontag . '.*>)(.*)(</' . $captiontag . '>)~mUus',
			[ $this, 'custom_gallery_regex_callback' ],
			$gallery
		);

		return $gallery;
	}

	/**
	 * Change the result of the regex match from custom_gallery_shortcode.
	 *
	 * @param array $m Regex matches.
	 *
	 * @return string Prettified gallery image caption.
	 */
	public function custom_gallery_regex_callback( $m ) {
		return $this->get_img_caption( $m[2] );
	}

	/*
	 * META BOX
	 */

	/**
	 * Adds a meta box to the main column on the enabled Post Types' edit screens.
	 *
	 * @since 1.5.0
	 */
	public function add_meta_boxes() {
		$options = WP2D_Options::instance();
		foreach ( $options->get_option( 'enabled_post_types' ) as $post_type ) {
			add_meta_box(
				'wp_to_diaspora_meta_box',
				'WP to diaspora*',
				[ $this, 'meta_box_render' ],
				$post_type,
				'side',
				'high'
			);
		}
	}

	/**
	 * Prints the meta box content.
	 *
	 * @since 1.5.0
	 *
	 * @param WP_Post $post The object for the current post.
	 */
	public function meta_box_render( $post ) {
		$this->_assign_wp_post( $post );

		// Add an nonce field so we can check for it later.
		wp_nonce_field( 'wp_to_diaspora_meta_box', 'wp_to_diaspora_meta_box_nonce' );

		// Get the default values to use, but give priority to the meta data already set.
		$options = WP2D_Options::instance();

		// Make sure we have some value for post meta fields.
		$this->custom_tags = $this->custom_tags ?: [];

		// If this post is already published, don't post again to diaspora* by default.
		$this->post_to_diaspora = ( $this->post_to_diaspora && 'publish' !== get_post_status( $this->ID ) );
		$this->aspects          = $this->aspects ?: [];
		$this->services         = $this->services ?: [];

		// Have we already posted on diaspora*?
		if ( is_array( $this->post_history ) ) {
			$latest_post = end( $this->post_history );
			?>
			<p><a href="<?php echo esc_attr( $latest_post['post_url'] ); ?>" target="_blank"><?php esc_html_e( 'Already posted to diaspora*.', 'wp-to-diaspora' ); ?></a></p>
			<?php
		}
		?>

		<p><?php $options->post_to_diaspora_render( $this->post_to_diaspora ); ?></p>
		<p><?php $options->fullentrylink_render( $this->fullentrylink ); ?></p>
		<p><?php $options->display_render( $this->display ); ?></p>
		<p><?php $options->tags_to_post_render( $this->tags_to_post ); ?></p>
		<p><?php $options->custom_tags_render( $this->custom_tags ); ?></p>
		<p><?php $options->aspects_services_render( [ 'aspects', $this->aspects ] ); ?></p>
		<p><?php $options->aspects_services_render( [ 'services', $this->services ] ); ?></p>

		<?php
	}

	/**
	 * When the post is saved, save our meta data.
	 *
	 * @since 1.5.0
	 *
	 * @param integer $post_id The ID of the post being saved.
	 */
	public function save_meta_box_data( $post_id ) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		/*
		 * We need to verify this came from our screen and with proper authorization,
		 * because the save_post action can be triggered at other times.
		 */
		if ( ! $this->_is_safe_to_save() ) {
			return;
		}

		/* OK, it's safe for us to save the data now. */

		// Meta data to save.
		$meta_to_save = $_POST['wp_to_diaspora_settings'];
		$options      = WP2D_Options::instance();

		// Checkboxes.
		$options->validate_checkboxes( [ 'post_to_diaspora', 'fullentrylink' ], $meta_to_save );

		// Single Selects.
		$options->validate_single_selects( 'display', $meta_to_save );

		// Multiple Selects.
		$options->validate_multi_selects( 'tags_to_post', $meta_to_save );

		// Save custom tags as array.
		$options->validate_tags( $meta_to_save['custom_tags'] );

		// Clean up the list of aspects. If the list is empty, only use the 'Public' aspect.
		$options->validate_aspects_services( $meta_to_save['aspects'], [ 'public' ] );

		// Clean up the list of services.
		$options->validate_aspects_services( $meta_to_save['services'] );

		// Update the meta data for this post.
		update_post_meta( $post_id, '_wp_to_diaspora', $meta_to_save );
	}

	/**
	 * Perform all checks to see if we are allowed to save the meta data.
	 *
	 * @since 1.5.0
	 *
	 * @return bool If the verification checks have passed.
	 */
	private function _is_safe_to_save() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		// Verify that our nonce is set and  valid.
		if ( ! ( isset( $_POST['wp_to_diaspora_meta_box_nonce'] ) && wp_verify_nonce( $_POST['wp_to_diaspora_meta_box_nonce'], 'wp_to_diaspora_meta_box' ) ) ) {
			return false;
		}

		// If this is an autosave, our form has not been submitted, so we don't want to do anything.
		if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) {
			return false;
		}

		// Check the user's permissions.
		$permission = ( isset( $_POST['post_type'] ) && 'page' === $_POST['post_type'] ) ? 'edit_pages' : 'edit_posts';
		if ( ! current_user_can( $permission, $this->ID ) ) {
			return false;
		}

		// Make real sure that we have some meta data to save.
		if ( ! isset( $_POST['wp_to_diaspora_settings'] ) ) {
			return false;
		}

		return true;
	}

	/**
	 * Add admin notices when a post gets displayed.
	 *
	 * @since 1.5.0
	 *
	 * @todo  Ignore post error with AJAX.
	 */
	public function admin_notices() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		global $post, $pagenow;
function myFunction($a, $b) {
    // Do something
}
		if ( ! $post || 'post.php' !== $pagenow ) {
			return;
		}

		if ( ( $error = get_post_meta( $post->ID, '_wp_to_diaspora_post_error', true ) ) && is_wp_error( $error ) ) {
			// Are we adding a help tab link to this notice?
			$help_link = WP2D_Contextual_Help::get_help_tab_quick_link( $error );

			// This notice will only be shown if posting to diaspora* has failed.
			printf( '<div class="error notice is-dismissible"><p>%1$s %2$s %3$s <a href="%4$s">%5$s</a></p></div>',
				esc_html__( 'Failed to post to diaspora*.', 'wp-to-diaspora' ),
				esc_html__( $error->get_error_message() ),
				$help_link,
				esc_url( add_query_arg( 'wp2d_ignore_post_error', '' ) ),
				esc_html__( 'Ignore', 'wp-to-diaspora' )
			);
		} elseif ( ( $diaspora_post_history = get_post_meta( $post->ID, '_wp_to_diaspora_post_history', true ) ) && is_array( $diaspora_post_history ) ) {
			// Get the latest post from the history.
			$latest_post = end( $diaspora_post_history );

			// Only show if this post is showing a message and the post is a fresh share.
			if ( isset( $_GET['message'] ) && $post->post_modified === $latest_post['created_at'] ) {
				printf( '<div class="updated notice is-dismissible"><p>%1$s <a href="%2$s" target="_blank">%3$s</a></p></div>',
					esc_html__( 'Successfully posted to diaspora*.', 'wp-to-diaspora' ),
					esc_url( $latest_post['post_url'] ),
					esc_html__( 'View Post' )
				);
			}
		}
	}

	/**
	 * Delete the error post meta data if it gets ignored.
	 *
	 * @since 1.5.0
	 */
	public function ignore_post_error() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		// If "Ignore" link has been clicked, delete the post error meta data.
		if ( isset( $_GET['wp2d_ignore_post_error'], $_GET['post'] ) ) {
			delete_post_meta( $_GET['post'], '_wp_to_diaspora_post_error' );
		}
	}
}

Push — master ( 48f45b...559f84 )

WP2D_Post::post() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

DiasPHPora / wp-to-diaspora

Push — master ( 48f45b...559f84 )

WP2D_Post::post() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like
