Issues in Translator.php (master) - Issues in master - Dgame/php-soap - Measure and Improve Code Quality continuously with Scrutinizer

Issues (24)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Hydrator/Translator.php (2 issues)

Labels

Documentation 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Dgame\Soap\Hydrator;

use Dgame\Soap\Attribute\XmlAttribute;
use Dgame\Soap\XmlElement;
use Dgame\Soap\XmlNode;
use DOMAttr;
use DOMDocument;
use DOMNode;

/**
 * Class Translator
 * @package Dgame\Soap\Hydrator
 */
final class Translator
{
    /**
     * @return Translator

     */
    public static function new(): self
    {
        return new self();
    }

    /**
     * @param DOMNode $node
     *
     * @return XmlElement|XmlNode|null
     */
    public function translate(DOMNode $node)
    {
        if ($node->nodeType === XML_DOCUMENT_NODE) {
            /** @var DOMDocument $node */
            return $this->translateDocument($node);
        }

        return $this->translateNode($node);
    }

    /**
     * @param DOMDocument $document
     *
     * @return XmlNode|null

     */
    public function translateDocument(DOMDocument $document)
    {
        return $this->translateNode($document->documentElement);
    }

    /**
     * @param DOMNode $node
     *
     * @return XmlNode|XmlElement|null
     */
    public function translateNode(DOMNode $node)
    {
        if ($node->nodeType !== XML_ELEMENT_NODE) {
            return null;
        }

        if ($this->isElement($node)) {
            return $this->createElement($node);
        }

        return $this->createNode($node);
    }

    /**
     * @param DOMNode $node
     *
     * @return bool
     */
    public function isElement(DOMNode $node): bool
    {
        return !$node->hasChildNodes() || ($node->childNodes->length === 1 && $node->firstChild->nodeType === XML_TEXT_NODE);
    }

    /**
     * @param DOMNode $node
     *
     * @return XmlElement
     */
    private function createElement(DOMNode $node): XmlElement
    {
        $element = new XmlElement($node->localName, $node->nodeValue, $node->prefix);
        $this->setAttributes($node, $element);

        return $element;
    }

    /**
     * @param DOMNode $node
     *
     * @return XmlNode
     */
    private function createNode(DOMNode $node): XmlNode
    {
        $element = new XmlNode($node->localName, null, $node->prefix);
        $this->setAttributes($node, $element);
        $this->appendChildNodes($node, $element);

        return $element;
    }

    /**
     * @param DOMNode    $node
     * @param XmlElement $element
     */
    private function setAttributes(DOMNode $node, XmlElement $element)
    {
        foreach ($node->attributes as $attribute) {
            $element->setAttribute($this->createAttribute($attribute));
        }
    }

    /**
     * @param DOMAttr $attr
     *
     * @return XmlAttribute
     */
    private function createAttribute(DOMAttr $attr): XmlAttribute
    {
        return new XmlAttribute($attr->name, $attr->value, $attr->prefix);
    }

    /**
     * @param DOMNode $node
     * @param XmlNode $parent
     */
    private function appendChildNodes(DOMNode $node, XmlNode $parent)
    {
        foreach ($node->childNodes as $childNode) {
            $child = $this->translateNode($childNode);
            if ($child !== null) {
                $parent->appendElement($child);
            } elseif ($childNode->nodeType === XML_TEXT_NODE) {
                $parent->setValue($childNode->nodeValue);
            }
        }
    }
}

1			<?php
2
3			namespace Dgame\Soap\Hydrator;
4
5			use Dgame\Soap\Attribute\XmlAttribute;
6			use Dgame\Soap\XmlElement;
7			use Dgame\Soap\XmlNode;
8			use DOMAttr;
9			use DOMDocument;
10			use DOMNode;
11
12			/**
13			* Class Translator
14			* @package Dgame\Soap\Hydrator
15			*/
16			final class Translator
17			{
18			/**
19			* @return Translator
			0 ignored issues – show Documentation introduced 2017-04-09 11:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `\self`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
20			*/
21			public static function new(): self
22			{
23			return new self();
24			}
25
26			/**
27			* @param DOMNode $node
28			*
29			* @return XmlElement\|XmlNode\|null
30			*/
31			public function translate(DOMNode $node)
32			{
33			if ($node->nodeType === XML_DOCUMENT_NODE) {
34			/** @var DOMDocument $node */
35			return $this->translateDocument($node);
36			}
37
38			return $this->translateNode($node);
39			}
40
41			/**
42			* @param DOMDocument $document
43			*
44			* @return XmlNode\|null
			0 ignored issues – show Documentation introduced 2017-05-26 22:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `XmlElement\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
45			*/
46			public function translateDocument(DOMDocument $document)
47			{
48			return $this->translateNode($document->documentElement);
49			}
50
51			/**
52			* @param DOMNode $node
53			*
54			* @return XmlNode\|XmlElement\|null
55			*/
56			public function translateNode(DOMNode $node)
57			{
58			if ($node->nodeType !== XML_ELEMENT_NODE) {
59			return null;
60			}
61
62			if ($this->isElement($node)) {
63			return $this->createElement($node);
64			}
65
66			return $this->createNode($node);
67			}
68
69			/**
70			* @param DOMNode $node
71			*
72			* @return bool
73			*/
74			public function isElement(DOMNode $node): bool
75			{
76			return !$node->hasChildNodes() \|\| ($node->childNodes->length === 1 && $node->firstChild->nodeType === XML_TEXT_NODE);
77			}
78
79			/**
80			* @param DOMNode $node
81			*
82			* @return XmlElement
83			*/
84			private function createElement(DOMNode $node): XmlElement
85			{
86			$element = new XmlElement($node->localName, $node->nodeValue, $node->prefix);
87			$this->setAttributes($node, $element);
88
89			return $element;
90			}
91
92			/**
93			* @param DOMNode $node
94			*
95			* @return XmlNode
96			*/
97			private function createNode(DOMNode $node): XmlNode
98			{
99			$element = new XmlNode($node->localName, null, $node->prefix);
100			$this->setAttributes($node, $element);
101			$this->appendChildNodes($node, $element);
102
103			return $element;
104			}
105
106			/**
107			* @param DOMNode $node
108			* @param XmlElement $element
109			*/
110			private function setAttributes(DOMNode $node, XmlElement $element)
111			{
112			foreach ($node->attributes as $attribute) {
113			$element->setAttribute($this->createAttribute($attribute));
114			}
115			}
116
117			/**
118			* @param DOMAttr $attr
119			*
120			* @return XmlAttribute
121			*/
122			private function createAttribute(DOMAttr $attr): XmlAttribute
123			{
124			return new XmlAttribute($attr->name, $attr->value, $attr->prefix);
125			}
126
127			/**
128			* @param DOMNode $node
129			* @param XmlNode $parent
130			*/
131			private function appendChildNodes(DOMNode $node, XmlNode $parent)
132			{
133			foreach ($node->childNodes as $childNode) {
134			$child = $this->translateNode($childNode);
135			if ($child !== null) {
136			$parent->appendElement($child);
137			} elseif ($childNode->nodeType === XML_TEXT_NODE) {
138			$parent->setValue($childNode->nodeValue);
139			}
140			}
141			}
142			}

Dgame / php-soap

Issues (24)

Security Analysis no request data

src/Hydrator/Translator.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like