Dgame\Soap\Hydrator\Dom\Assembler

Complexity

Total Complexity

16

Size/Duplication

Total Lines	102
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

88.89%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	2
A	getDocument()	0	4	1
A	assemble()	0	11	2
A	visitElement()	0	5	2
A	visitXmlElement()	0	8	3
A	visitXmlNode()	0	9	2
A	visitAttribute()	0	4	2
A	visitXmlAttribute()	0	4	2

<?php

namespace Dgame\Soap\Hydrator\Dom;

use Dgame\Soap\Attribute\Attribute;
use Dgame\Soap\Attribute\XmlAttribute;
use Dgame\Soap\Element;
use Dgame\Soap\Hydrator\VisitorInterface;
use Dgame\Soap\XmlElement;
use Dgame\Soap\XmlNode;
use DOMDocument;
use DOMElement;
use DOMNode;

/**
 * Class Assembler
 * @package Dgame\Soap\Hydrator\Dom
 */
final class Assembler implements VisitorInterface
{
    /**
     * @var DOMDocument
     */
    private $document;
    /**
     * @var DOMElement
     */
    private $node;

    /**
     * Assembler constructor.
     *
     * @param DOMNode|null $node
     */
    public function __construct(DOMNode $node = null)
    {
        if ($node === null) {
            $this->node = $this->document = new DOMDocument('1.0', 'utf-8');

It seems like $this->document = new \DOMDocument('1.0', 'utf-8') of type object<DOMDocument> is incompatible with the declared type object<DOMElement> of property $node.

        } else {
            $this->node     = $node;

$node is of type object<DOMNode>, but the property $node was declared to be of type object<DOMElement>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

            $this->document = $node->ownerDocument ?? $this->node;

It seems like $node->ownerDocument ?? $this->node can also be of type object<DOMNode>. However, the property $document is declared as type object<DOMDocument>. Maybe add an additional type check?

        }
    }

    /**
     * @return DOMDocument
     */
    public function getDocument(): DOMDocument
    {
        return $this->document;
    }

    /**
     * @param Element $element
     * @param DOMNode $node
     *
     * @return DOMNode
     */
    private function assemble(Element $element, DOMNode $node): DOMNode
    {
        $this->node->appendChild($node);
        $this->node = $node;

$node is of type object<DOMNode>, but the property $node was declared to be of type object<DOMElement>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        foreach ($element->getAttributes() as $attribute) {
            $attribute->accept($this);
        }

        return $node;
    }

    /**
     * @param Element $element
     */
    public function visitElement(Element $element)
    {
        $node = $this->document->createElement($element->getName(), $element->hasValue() ? $element->getValue() : null);
        $this->assemble($element, $node);
    }

    /**
     * @param XmlElement $element
     */
    public function visitXmlElement(XmlElement $element)
    {
        $node = $this->document->createElement($element->getPrefixedName(), $element->hasValue() ? $element->getValue() : null);
        $node = $this->assemble($element, $node);
        if ($element->hasPrefix()) {
            $node->prefix = $element->getPrefix();
        }
    }

    /**
     * @param XmlNode $node
     */
    public function visitXmlNode(XmlNode $node)
    {
        $this->visitXmlElement($node);

        foreach ($node->getElements() as $child) {
            $assembler = new self($this->node);
            $child->accept($assembler);
        }
    }

    /**
     * @param Attribute $attribute
     */
    public function visitAttribute(Attribute $attribute)
    {
        $this->node->setAttribute($attribute->getName(), $attribute->hasValue() ? $attribute->getValue() : null);
    }

    /**
     * @param XmlAttribute $attribute
     */
    public function visitXmlAttribute(XmlAttribute $attribute)
    {
        $this->node->setAttribute($attribute->getPrefixedName(), $attribute->hasValue() ? $attribute->getValue() : null);
    }
}