Dgame\Object\Validator

Complexity

Total Complexity

19

Size/Duplication

Total Lines	117
Duplicated Lines	35.9 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	new()	0	4	1
B	validateGetterMethod()	5	15	5
A	isValidProperty()	16	16	3
A	isValidMethod()	16	16	3
B	isValidSetterMethod()	5	18	6

<?php

namespace Dgame\Object;

use ReflectionMethod;
use ReflectionProperty;
use function Dgame\Conditional\debug;

/**
 * Class Validator
 * @package Dgame\Object
 */
final class Validator
{
    /**
     * @var ObjectFacade
     */
    private $facade;

    /**
     * Validator constructor.
     *
     * @param ObjectFacade $facade
     */
    public function __construct(ObjectFacade $facade)
    {
        $this->facade = $facade;
    }

    /**
     * @param ObjectFacade $facade
     *
     * @return Validator
     */
    public static function new(ObjectFacade $facade): self
    {
        return new self($facade);
    }

    /**
     * @param ReflectionProperty $property
     *
     * @return bool
     */
    public function isValidProperty(ReflectionProperty $property): bool

This method seems to be duplicated in your project.

    {
        if (!$property->isPublic()) {
            debug(ObjectFacade::DEBUG_LABEL)->output('[Error] Property %s is not public', $property->getName());

            return false;
        }

        if ($property->isStatic()) {
            debug(ObjectFacade::DEBUG_LABEL)->output('[Error] Property %s is static', $property->getName());

            return false;
        }

        return true;
    }

    /**
     * @param ReflectionMethod $method
     *
     * @return bool
     */
    public function isValidMethod(ReflectionMethod $method): bool

This method seems to be duplicated in your project.

    {
        if (!$method->isPublic()) {
            debug(ObjectFacade::DEBUG_LABEL)->output('[Error] Method %s is not public', $method->getName());

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

            return false;
        }

        if ($method->isStatic()) {
            debug(ObjectFacade::DEBUG_LABEL)->output('[Error] Method %s is static', $method->getName());

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

            return false;
        }

        return true;
    }

    /**
     * @param ReflectionMethod $method
     * @param                  $value
     *
     * @return bool
     */
    public function isValidSetterMethod(ReflectionMethod $method, $value): bool
    {
        if (!$this->isValidMethod($method)) {
            return false;
        }

        if ($value === null && $method->getNumberOfParameters() !== 0 && !$method->getParameters()[0]->allowsNull()) {

This code seems to be duplicated across your project.

            debug(ObjectFacade::DEBUG_LABEL)->output('[Error] First parameter of method %s is not allowed to be null', $method->getName());

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

            return false;
        }

        if ($method->getNumberOfParameters() === 0) {
            debug(ObjectFacade::DEBUG_LABEL)->output('[Warning] Method %s does not accept any parameters', $method->getName());

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

        }

        return true;
    }

    /**
     * @param ReflectionMethod $method
     *
     * @return bool
     */
    public function validateGetterMethod(ReflectionMethod $method): bool
    {
        if (!$this->isValidMethod($method)) {
            return false;
        }

        $value = $method->invoke($this->facade->getObject());
        if ($value === null && $method->hasReturnType() && !$method->getReturnType()->allowsNull()) {

This code seems to be duplicated across your project.

            debug(ObjectFacade::DEBUG_LABEL)->output('[Error] Method %s return value is not allowed to be null', $method->getName());

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

            return false;
        }

        return true;
    }
}