Issues in DynamicRelationSubscriber.php (master) - Issues in master - DevelopTech/AgilityBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (32)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

EventSubscriber/DynamicRelationSubscriber.php (13 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Developtech\AgilityBundle\EventSubscriber;

use Doctrine\Common\EventSubscriber;
use Doctrine\ORM\Event\LoadClassMetadataEventArgs;
use Doctrine\ORM\Events;
use Doctrine\ORM\Mapping\ClassMetadata;

class DynamicRelationSubscriber implements EventSubscriber
{
    const MODEL_PROJECT = 'Developtech\AgilityBundle\Entity\Project';
    const MODEL_FEATURE = 'Developtech\AgilityBundle\Entity\Feature';
    const MODEL_FEEDBACK = 'Developtech\AgilityBundle\Entity\Feedback';

    /** @var string **/
    protected $userClass;

    /**
     * @param string $userClass
     */
    public function __construct($userClass) {
        $this->userClass = $userClass;
    }

    /**
     * {@inheritDoc}
     */
    public function getSubscribedEvents()
    {
        return array(
            Events::loadClassMetadata,
        );
    }

    /**
     * @param LoadClassMetadataEventArgs $eventArgs
     */
    public function loadClassMetadata(LoadClassMetadataEventArgs $eventArgs)
    {
        // the $metadata is the whole mapping info for this class
        $metadata = $eventArgs->getClassMetadata();

        switch($metadata->getName()) {

            case self::MODEL_PROJECT: return $this->mapProject($metadata);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            case self::MODEL_FEATURE: return $this->mapFeature($metadata);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            case self::MODEL_FEEDBACK: return $this->mapFeedback($metadata);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            default: return;
switch ($expr) {
    default:
        doSomething(); //right
        break;
}


switch ($expr) {
    default:

        doSomething(); //wrong
        break;
}
        }
    }

    /**
     * @param CLassMetadata $metadata
     */
    public function mapProject(ClassMetadata $metadata) {
        $metadata->mapManyToOne(array(
            'targetEntity'  => $this->userClass,
            'fieldName'     => 'productOwner',
            'cascade'       => array(),
            'joinColumn'    => array(
                'nullable' => false
            )
        ));
    }

    /**
     * @param CLassMetadata $metadata
     */
    public function mapFeature(ClassMetadata $metadata) {
        $metadata->mapManyToOne(array(
            'targetEntity'  => $this->userClass,
            'fieldName'     => 'responsible',
            'cascade'       => array(),
            'joinColumn'    => array(
                'nullable' => true
            )
        ));
    }

    /**
     * @param CLassMetadata $metadata
     */
    public function mapFeedback(ClassMetadata $metadata) {
        $metadata->mapManyToOne(array(
            'targetEntity'  => $this->userClass,
            'fieldName'     => 'author',
            'cascade'       => array(),
            'joinColumn'    => array(
                'nullable' => false
            )
        ));
        $metadata->mapManyToOne(array(
            'targetEntity'  => $this->userClass,
            'fieldName'     => 'responsible',
            'cascade'       => array(),
            'joinColumn'    => array(
                'nullable' => true
            )
        ));
    }
}


1		<?php
2
3		namespace Developtech\AgilityBundle\EventSubscriber;
4
5		use Doctrine\Common\EventSubscriber;
6		use Doctrine\ORM\Event\LoadClassMetadataEventArgs;
7		use Doctrine\ORM\Events;
8		use Doctrine\ORM\Mapping\ClassMetadata;
9
10		class DynamicRelationSubscriber implements EventSubscriber
11		{
12		const MODEL_PROJECT = 'Developtech\AgilityBundle\Entity\Project';
13		const MODEL_FEATURE = 'Developtech\AgilityBundle\Entity\Feature';
14		const MODEL_FEEDBACK = 'Developtech\AgilityBundle\Entity\Feedback';
15
16		/ @var string /
17		protected $userClass;
18
19		/**
20		* @param string $userClass
21		*/
22	1	public function __construct($userClass) {
23	1	$this->userClass = $userClass;
24	1	}
25
26		/**
27		* {@inheritDoc}
28		*/
29	1	public function getSubscribedEvents()
30		{
31		return array(
32	1	Events::loadClassMetadata,
33	1	);
34		}
35
36		/**
37		* @param LoadClassMetadataEventArgs $eventArgs
38		*/
39	1	public function loadClassMetadata(LoadClassMetadataEventArgs $eventArgs)
40		{
41		// the $metadata is the whole mapping info for this class
42	1	$metadata = $eventArgs->getClassMetadata();
43
44	1	switch($metadata->getName()) {
		0 ignored issues – show Bug introduced 2016-08-01 22:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getName()` does not seem to exist on `object<Doctrine\ORM\EntityManager>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Coding Style introduced 2016-08-01 22:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 1 space after SWITCH keyword; 0 found Loading history...
45	1	case self::MODEL_PROJECT: return $this->mapProject($metadata);
		0 ignored issues – show Documentation introduced 2016-08-05 20:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$metadata` is of type `object<Doctrine\ORM\EntityManager>`, but the function expects a `object<Doctrine\ORM\Mapping\ClassMetadata>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Coding Style introduced 2016-08-05 20:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-08-05 20:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
46	1	case self::MODEL_FEATURE: return $this->mapFeature($metadata);
		0 ignored issues – show Documentation introduced 2016-08-05 20:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$metadata` is of type `object<Doctrine\ORM\EntityManager>`, but the function expects a `object<Doctrine\ORM\Mapping\ClassMetadata>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Coding Style introduced 2016-08-05 20:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-08-05 20:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
47	1	case self::MODEL_FEEDBACK: return $this->mapFeedback($metadata);
		0 ignored issues – show Documentation introduced 2016-08-01 22:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$metadata` is of type `object<Doctrine\ORM\EntityManager>`, but the function expects a `object<Doctrine\ORM\Mapping\ClassMetadata>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Coding Style introduced 2016-08-01 22:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-08-01 22:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
48	1	default: return;
		0 ignored issues – show Coding Style introduced 2016-08-01 22:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The default body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a default statement must start on the line immediately following the statement. switch ($expr) { default: doSomething(); //right break; } switch ($expr) { default: doSomething(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-08-01 22:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
49	1	}
50		}
51
52		/**
53		* @param CLassMetadata $metadata
54		*/
55	1	public function mapProject(ClassMetadata $metadata) {
56	1	$metadata->mapManyToOne(array(
57	1	'targetEntity' => $this->userClass,
58	1	'fieldName' => 'productOwner',
59	1	'cascade' => array(),
60		'joinColumn' => array(
61		'nullable' => false
62	1	)
63	1	));
64	1	}
65
66		/**
67		* @param CLassMetadata $metadata
68		*/
69	1	public function mapFeature(ClassMetadata $metadata) {
70	1	$metadata->mapManyToOne(array(
71	1	'targetEntity' => $this->userClass,
72	1	'fieldName' => 'responsible',
73	1	'cascade' => array(),
74		'joinColumn' => array(
75		'nullable' => true
76	1	)
77	1	));
78	1	}
79
80		/**
81		* @param CLassMetadata $metadata
82		*/
83	1	public function mapFeedback(ClassMetadata $metadata) {
84	1	$metadata->mapManyToOne(array(
85	1	'targetEntity' => $this->userClass,
86	1	'fieldName' => 'author',
87	1	'cascade' => array(),
88		'joinColumn' => array(
89		'nullable' => false
90	1	)
91	1	));
92	1	$metadata->mapManyToOne(array(
93	1	'targetEntity' => $this->userClass,
94	1	'fieldName' => 'responsible',
95	1	'cascade' => array(),
96		'joinColumn' => array(
97		'nullable' => true
98	1	)
99	1	));
100	1	}
101		}
102

DevelopTech / AgilityBundle

Issues (32)

Security Analysis no request data

EventSubscriber/DynamicRelationSubscriber.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like