ProjectModelTest::testModel() - Code Metrics - Inspection of "Feature/22/feedbacks list" - DevelopTech/AgilityBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#25)

by Axel

created 2016-07-14 16:25 UTC

ProjectModelTest::testModel() B

↳ Parent: ProjectModelTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	31
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	31
rs	8.8571
cc	1
eloc	29
nc	1
nop	0

<?php

namespace Developtech\AgilityBundle\Tests\Model;

use Developtech\AgilityBundle\Tests\Mock\Project;
use Developtech\AgilityBundle\Tests\Mock\Feature;
use Developtech\AgilityBundle\Tests\Mock\Feedback;

class ProjectModelTest extends \PHPUnit_Framework_TestCase {
    public function testModel() {
        $feedback = new Feedback();
        $feature = new Feature();
        $entity =
            (new Project())

            ->setId(1)
            ->setName('Great project')
            ->setSlug('great-project')
            ->setCreatedAt(new \DateTime())
            ->setProductOwner((new \StdClass()))
            ->setBetaTestStatus('open')
            ->setNbBetaTesters(12)
            ->addFeature(new Feature())
            ->addFeature($feature)
            ->removeFeature($feature)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->addFeedback($feedback)
            ->addFeedback(new Feedback())
            ->removeFeedback($feedback)
        ;
        $this->assertEquals(1, $entity->getId());
        $this->assertEquals('Great project', $entity->getName());
        $this->assertEquals('great-project', $entity->getSlug());
        $this->assertInstanceOf('DateTime', $entity->getCreatedAt());
        $this->assertInstanceOf('StdClass', $entity->getProductOwner());
        $this->assertEquals('open', $entity->getBetaTestStatus());
        $this->assertEquals(12, $entity->getNbBetaTesters());
        $this->assertFalse($project->hasFeature($feature));

        $this->assertFalse($project->hasFeedback($feedback));
        $this->assertCount(1, $project->getFeedbacks());
        $this->assertCount(1, $project->getFeatures());
    }
}


1			<?php
2
3			namespace Developtech\AgilityBundle\Tests\Model;
4
5			use Developtech\AgilityBundle\Tests\Mock\Project;
6			use Developtech\AgilityBundle\Tests\Mock\Feature;
7			use Developtech\AgilityBundle\Tests\Mock\Feedback;
8
9			class ProjectModelTest extends \PHPUnit_Framework_TestCase {
10			public function testModel() {
11			$feedback = new Feedback();
12			$feature = new Feature();
13			$entity =
14			(new Project())
			0 ignored issues – show Bug introduced 2016-07-14 16:40 UTC by Report Bug Copy Issue Report The method `removeFeedback()` does not seem to exist on `object<Developtech\Agili...dle\Model\ProjectModel>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
15			->setId(1)
16			->setName('Great project')
17			->setSlug('great-project')
18			->setCreatedAt(new \DateTime())
19			->setProductOwner((new \StdClass()))
20			->setBetaTestStatus('open')
21			->setNbBetaTesters(12)
22			->addFeature(new Feature())
23			->addFeature($feature)
24			->removeFeature($feature)
			0 ignored issues – show Documentation introduced 2016-07-14 16:40 UTC by Report Bug Copy Issue Report `$feature` is of type `object<Developtech\Agili...dle\Tests\Mock\Feature>`, but the function expects a `object<Developtech\Agili...le\Model\FeedbackModel>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
25			->addFeedback($feedback)
26			->addFeedback(new Feedback())
27			->removeFeedback($feedback)
28			;
29			$this->assertEquals(1, $entity->getId());
30			$this->assertEquals('Great project', $entity->getName());
31			$this->assertEquals('great-project', $entity->getSlug());
32			$this->assertInstanceOf('DateTime', $entity->getCreatedAt());
33			$this->assertInstanceOf('StdClass', $entity->getProductOwner());
34			$this->assertEquals('open', $entity->getBetaTestStatus());
35			$this->assertEquals(12, $entity->getNbBetaTesters());
36			$this->assertFalse($project->hasFeature($feature));
			0 ignored issues – show Bug introduced 2016-07-14 16:40 UTC by Report Bug Copy Issue Report The variable `$project` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
37			$this->assertFalse($project->hasFeedback($feedback));
38			$this->assertCount(1, $project->getFeedbacks());
39			$this->assertCount(1, $project->getFeatures());
40			}
41			}
42

DevelopTech / AgilityBundle

Pull Request — develop (#25)

ProjectModelTest::testModel() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like