Developtech\AgilityBundle\Manager\FeedbackManager

Complexity

Total Complexity

2

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getProjectFeedbacks()	0	3	1

<?php

namespace Developtech\AgilityBundle\Manager;

use Doctrine\ORM\EntityManager;

use Developtech\AgilityBundle\Model\ProjectModel;

class FeedbackManager {
    /** @var EntityManager **/
    protected $em;
    /** @var string **/
    protected $feedbackClass;

    /**
     * @param EntityManager $em
     * @param string $feedbackClass
     */
    public function __construct(EntityManager $em, $feedbackClass) {

You have injected the EntityManager via parameter $em. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

        $this->em = $em;
        $this->feedbackClass = $feedbackClass;
    }

    /**
     * @param ProjectModel $project
     * @return array
     */
    public function getProjectFeedbacks(ProjectModel $project) {
        return $this->em->getRepository($this->feedbackClass)->findByProject($project);
    }
}