Developtech\AgilityBundle\Manager\FeatureManager

Complexity

Total Complexity

4

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	2

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getProjectFeatures()	0	3	1
A	getFeature()	0	6	2

<?php

namespace Developtech\AgilityBundle\Manager;

use Doctrine\ORM\EntityManager;

use Developtech\AgilityBundle\Model\ProjectModel;
use Developtech\AgilityBundle\Model\FeatureModel;

use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class FeatureManager {
    /** @var EntityManager **/
    protected $em;
    /** @var string **/
    protected $featureClass;

    /**
     * @param EntityManager $em
     * @param string $featureClass
     */
    public function __construct(EntityManager $em, $featureClass) {

You have injected the EntityManager via parameter $em. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

        $this->em = $em;
        $this->featureClass = $featureClass;
    }

    /**
     * @param ProjectModel $project
     * @return array
     */
    public function getProjectFeatures(ProjectModel $project) {
        return $this->em->getRepository($this->featureClass)->findByProject($project);
    }

    /**
     * @param integer $id
     * @return FeatureModel
     */
    public function getFeature($id) {
        if(($feature = $this->em->getRepository($this->featureClass)->find($id)) === null) {

Expected 1 space after IF keyword; 0 found

            throw new NotFoundHttpException('Feature not found');
        }
        return $feature;
    }
}