Developtech\AgilityBundle\Manager\ProjectManager

Complexity

Total Complexity

8

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

91.18%

Importance

Changes	4
Bugs	0	Features	3

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getProjects()	0	3	1
A	getProject()	0	7	2
A	createProject()	0	13	1
A	editProject()	0	16	3

<?php

namespace Developtech\AgilityBundle\Manager;

use Doctrine\ORM\EntityManager;

use Developtech\AgilityBundle\Entity\Project;

use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

use Symfony\Component\Security\Core\User\UserInterface;

use Developtech\AgilityBundle\Utils\Slugger;

class ProjectManager {
    /** @var Doctrine\ORM\EntityManager **/
    protected $em;
    /** @var Developtech\AgilityBundle\Utils\Slugger **/
    protected $slugger;

    /**
     * @param Doctrine\ORM\EntityManager $em
     * @param Slugger $slugger
     */
    public function __construct(EntityManager $em, Slugger $slugger) {

You have injected the EntityManager via parameter $em. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

        $this->em = $em;

It seems like $em of type object<Doctrine\ORM\EntityManager> is incompatible with the declared type object<Developtech\AgilityBundle\Manager\Doctrine\ORM\EntityManager> of property $em.

        $this->slugger = $slugger;

It seems like $slugger of type object<Developtech\AgilityBundle\Utils\Slugger> is incompatible with the declared type object<Developtech\AgilityBundle\Manager\Developtech\AgilityBundle\Utils\Slugger> of property $slugger.

    }

    /**
     * @return array
     */
    public function getProjects() {
        return $this->em->getRepository(Project::class)->findAll();
    }

    /**
     * @param string $slug
     * @throws NotFoundHttpException
     * @return ProjectModel
     */
    public function getProject($slug) {
        $project = $this->em->getRepository(Project::class)->findOneBySlug($slug);
        if($project === null) {

Expected 1 space after IF keyword; 0 found

            throw new NotFoundHttpException('Project not found');
        }
        return $project;
    }

    /**
     * @param string $name
     * @param UserInterface $productOwner
     * @return \DevelopTech\AgilityBundle\ProjectModel
     */
    public function createProject($name, UserInterface $productOwner) {
        $project =
            (new Project())
            ->setName($name)
            ->setSlug($this->slugger->slugify($name))
            ->setProductOwner($productOwner)
            ->setBetaTestStatus('closed')
            ->setNbBetaTesters(0)
        ;
        $this->em->persist($project);
        $this->em->flush();
        return $project;
    }

    /**
     * @param integer $id
     * @param string $name
     * @param integer $betaTestStatus
     * @param integer $nbBetaTesters
     * @param UserInterface $productOwner
     * @throws NotFoundHttpException
     * @return ProjectModel
     */
    public function editProject($id, $name, $betaTestStatus, $nbBetaTesters, UserInterface $productOwner = null) {
        if (($project = $this->em->getRepository(Project::class)->find($id)) === null) {
            throw new NotFoundHttpException('Project not found');
        }
        $project
            ->setName($name)
            ->setSlug($this->slugger->slugify($name))
            ->setBetaTestStatus($betaTestStatus)
            ->setNbBetaTesters($nbBetaTesters)
        ;
        if($productOwner !== null) {

Expected 1 space after IF keyword; 0 found

            $project->setProductOwner($productOwner);
        }
        $this->em->flush();
        return $project;
    }
}