Issues in NotificationController.php (master) - Issues in master - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2170)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

controllers/NotificationController.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace app\backgroundtasks\controllers;

use app\backgroundtasks\models\NotifyMessage;
use app\backgroundtasks\models\Task;
use Yii;
use yii\filters\AccessControl;
use yii\filters\VerbFilter;
use yii\web\Controller;
use yii\web\NotFoundHttpException;

/**
 * Class NotificationController
 * @package app\backgroundtasks\controllers
 * @author evgen-d <[email protected]>
 */
class NotificationController extends Controller
{
    public function behaviors()
    {
        return [
            'access' => [
                'class' => AccessControl::className(),

                'rules' => [
                    [
                        'allow' => true,
                        'roles' => ['@'],
                    ],
                ],
            ],
            'verbs' => [
                'class' => VerbFilter::className(),

                'actions' => [
                ],
            ],
        ];
    }

    /**
     * View all notifications
     * @return string
     */
    public function actionIndex()
    {
        if (Yii::$app->getModule('background')->inGroup()) {
            $searchModel = new NotifyMessage(['scenario' => 'search']);
            $dataProvider = $searchModel->search($_GET);
        } else {
            $searchModel = new NotifyMessage(['scenario' => 'search']);
            $dataProvider = $searchModel->search($_GET, true);
        }

        return $this->render(
            'index',
            [
                'dataProvider' => $dataProvider,
                'searchModel' => $searchModel,
            ]
        );
    }

    /**
     * View Notification model if exist
     * @param $id
     * @return string
     * @throws \yii\web\NotFoundHttpException
     */
    public function actionView($id)
    {
        if (Yii::$app->getModule('background')->inGroup()) {
            /* @var $model NotifyMessage */
            $model = NotifyMessage::find()->joinWith(['task'])->where(
                [
                    'NotifyMessage.id' => $id,
                ]
            )->one();
        } else {
            /* @var $model NotifyMessage */
            $model = NotifyMessage::find()->joinWith(['task'])->where(
                [
                    NotifyMessage::tableName() . '.id' => $id,
                    Task::tableName() . '.initiator' => Yii::$app->user->id,
                ]
            )->one();
        }

        if ($model !== null) {
            switch ($model->result_status) {
                case NotifyMessage::STATUS_SUCCESS:
                    $class = 'panel-success';
                    break;
                case NotifyMessage::STATUS_FAULT:
                    $class = 'panel-danger';
                    break;
                default:
                    $class = 'panel-default';
                    break;
            }
            return $this->render(
                'view',
                [
                    'model' => $model,
                    'class' => $class,
                ]
            );
        } else {
            throw new NotFoundHttpException('repeated task #' . $id . ' not found');
        }
    }

    /**
     * Return count of new notifications
     * @param $current
     * @return mixed

     */
    public function actionOnlyNewNotifications($current)
    {
        if (Yii::$app->getModule('background')->inGroup()) {
            return NotifyMessage::find()->where('UNIX_TIMESTAMP(`ts`) > :current', [':current' => $current])->count();
        } else {
            return NotifyMessage::find()->where(
                [
                    'user_id' => Yii::$app->user->id,
                ]
            )->andWhere('UNIX_TIMESTAMP(`ts`) > :current', [':current' => $current])->count();
        }
    }

}


1			<?php
2
3			namespace app\backgroundtasks\controllers;
4
5			use app\backgroundtasks\models\NotifyMessage;
6			use app\backgroundtasks\models\Task;
7			use Yii;
8			use yii\filters\AccessControl;
9			use yii\filters\VerbFilter;
10			use yii\web\Controller;
11			use yii\web\NotFoundHttpException;
12
13			/**
14			* Class NotificationController
15			* @package app\backgroundtasks\controllers
16			* @author evgen-d <[email protected]>
17			*/
18			class NotificationController extends Controller
19			{
20			public function behaviors()
21			{
22			return [
23			'access' => [
24			'class' => AccessControl::className(),
			0 ignored issues – show Deprecated Code introduced 2018-06-05 13:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `yii\base\BaseObject::className()` has been deprecated with message: since 2.0.14. On PHP >=5.5, use `::class` instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
25			'rules' => [
26			[
27			'allow' => true,
28			'roles' => ['@'],
29			],
30			],
31			],
32			'verbs' => [
33			'class' => VerbFilter::className(),
			0 ignored issues – show Deprecated Code introduced 2018-06-05 13:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `yii\base\BaseObject::className()` has been deprecated with message: since 2.0.14. On PHP >=5.5, use `::class` instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
34			'actions' => [
35			],
36			],
37			];
38			}
39
40			/**
41			* View all notifications
42			* @return string
43			*/
44			public function actionIndex()
45			{
46			if (Yii::$app->getModule('background')->inGroup()) {
47			$searchModel = new NotifyMessage(['scenario' => 'search']);
48			$dataProvider = $searchModel->search($_GET);
49			} else {
50			$searchModel = new NotifyMessage(['scenario' => 'search']);
51			$dataProvider = $searchModel->search($_GET, true);
52			}
53
54			return $this->render(
55			'index',
56			[
57			'dataProvider' => $dataProvider,
58			'searchModel' => $searchModel,
59			]
60			);
61			}
62
63			/**
64			* View Notification model if exist
65			* @param $id
66			* @return string
67			* @throws \yii\web\NotFoundHttpException
68			*/
69			public function actionView($id)
70			{
71			if (Yii::$app->getModule('background')->inGroup()) {
72			/* @var $model NotifyMessage */
73			$model = NotifyMessage::find()->joinWith(['task'])->where(
74			[
75			'NotifyMessage.id' => $id,
76			]
77			)->one();
78			} else {
79			/* @var $model NotifyMessage */
80			$model = NotifyMessage::find()->joinWith(['task'])->where(
81			[
82			NotifyMessage::tableName() . '.id' => $id,
83			Task::tableName() . '.initiator' => Yii::$app->user->id,
84			]
85			)->one();
86			}
87
88			if ($model !== null) {
89			switch ($model->result_status) {
90			case NotifyMessage::STATUS_SUCCESS:
91			$class = 'panel-success';
92			break;
93			case NotifyMessage::STATUS_FAULT:
94			$class = 'panel-danger';
95			break;
96			default:
97			$class = 'panel-default';
98			break;
99			}
100			return $this->render(
101			'view',
102			[
103			'model' => $model,
104			'class' => $class,
105			]
106			);
107			} else {
108			throw new NotFoundHttpException('repeated task #' . $id . ' not found');
109			}
110			}
111
112			/**
113			* Return count of new notifications
114			* @param $current
115			* @return mixed
			0 ignored issues – show Documentation introduced 2017-03-17 10:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider making the return type a bit more specific; maybe use `integer\|string`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
116			*/
117			public function actionOnlyNewNotifications($current)
118			{
119			if (Yii::$app->getModule('background')->inGroup()) {
120			return NotifyMessage::find()->where('UNIX_TIMESTAMP(`ts`) > :current', [':current' => $current])->count();
121			} else {
122			return NotifyMessage::find()->where(
123			[
124			'user_id' => Yii::$app->user->id,
125			]
126			)->andWhere('UNIX_TIMESTAMP(`ts`) > :current', [':current' => $current])->count();
127			}
128			}
129
130			}
131

GitHub Access Token became invalid

Issues (2170)

Security Analysis not enabled

controllers/NotificationController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Issues (2170)

Security Analysis not enabled

controllers/NotificationController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like