CategoryMovementsButtons::registerScript() - Code Metrics - Inspection of "Batch product movements" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — filters ( 69e989...d867fc )

unknown

created 2015-12-23 12:27 UTC

CategoryMovementsButtons::registerScript() A

↳ Parent: CategoryMovementsButtons

Complexity

Conditions	1
Paths	1

Size

Total Lines	51
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	51
rs	9.411
cc	1
eloc	10
nc	1
nop	0

How to fix Long Method

<?php

namespace app\backend\widgets;


use yii\base\Widget;
use Yii;
use yii\helpers\Html;
use yii\base\InvalidParamException;
use app\modules\shop\models\Category;
use kartik\icons\Icon;

class CategoryMovementsButtons extends Widget
{
    const MOVE_ACTION = 'move-selected';
    const ADD_ACTION = 'add-selected';
    public $url;
    public $gridSelector;
    public $wrapperClass = '';
    public $addText = '';
    public $moveText = '';
    /**
     * @var array here you can define buttons classes like this:
     * [
     *  'add-class' => 'btn btn-danger', //class for add button
     *  'move-class' => 'btn btn-danger', //class for move button
     * ]
     *
     */
    public $htmlOptions = [];
    private $modalSelector = '#mass-categories-actions';
    private static $categories = [];

    /**
     * @inheritdoc
     */
    public function init()
    {
        if (!isset($this->url, $this->gridSelector)) {
            throw new InvalidParamException('Attribute \'url\' or \'gridSelector\' is not set');
        }
        if (true === empty($this->moveText)) {
            $this->moveText = Yii::t('app', 'Are you sure you want to move all selected products into');
        }
        if (true === empty($this->addText)) {
            $this->addText = Yii::t('app', 'Are you sure you want to add all selected products into');
        }
        if (!isset($this->htmlOptions['id'])) {
            $this->htmlOptions['id'] = '';
        }
        if (true === empty(static::$categories)) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            $cc = Category::find()
                ->select('id, name')
                ->where(['active' => 1])
                ->asArray(true)
                ->all();
            foreach ($cc as $k => $cat) {
                static::$categories[$cat['id']] = $cat['name'];
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            }
        }
    }

    /**
     * @return string
     */
    public function run()
    {
        $this->registerScript();
        return $this->renderButtons();
    }

    /**
     * @return string
     */
    protected function renderButtons()
    {
        $buttons = [
            self::ADD_ACTION => Html::button(
                Icon::show('plus') . ' ' .
                Yii::t('app', 'Add selected to:'),
                [
                    'class' => isset($this->htmlOptions['add-class']) ?
                        $this->htmlOptions['add-class'] : 'btn btn-default',
                    'disabled' => 'disabled',
                    'data-mc-action' => self::ADD_ACTION
                ]),
            self::MOVE_ACTION => Html::button(
                Icon::show('arrows') . ' ' .
                Yii::t('app', 'Move selected to:'),
                [
                    'class' => isset($this->htmlOptions['move-class']) ?
                        $this->htmlOptions['move-class'] : 'btn btn-default',
                    'disabled' => 'disabled',
                    'data-mc-action' => self::MOVE_ACTION
                ]),

        ];
        $group = '';
        foreach ($buttons as $id => $button) {
            $group .= Html::tag('div',
                Html::tag('div',
                    $button . "\n\t" . Html::tag('div',
                        Html::dropDownList(null, null, static::$categories, [
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
                            'prompt' => Yii::t('app', 'Select category'),
                            'class' => 'form-control',
                            'id' => $id,
                        ]), [
                            'class' => 'input-group',
                        ]), [
                        'class' => 'btn-group',
                    ]), [
                    'class' => 'col-xs-12 col-sm-6',
                ]);
        };
        return Html::tag('div', $group, ['class' => 'row m-bottom-10']);
    }

    /**
     *
     */
    protected function registerScript()
    {
        $JS = <<<JS
            $("#%1\$s, #%2\$s").change(function (){
                var \$this = $(this),
                    buttonSelector = \$this.attr('id'),
                    \$button = $('button[data-mc-action="' + buttonSelector + '"]'),
                    \$selected = $('option:selected', \$this),
                    categoryId = parseInt(\$selected.val()),
                    categoryName = \$selected.text(),
                    items =  $("{$this->gridSelector}").yiiGridView('getSelectedRows');
                if (items.length) {
                    if (false === isNaN(categoryId)) {
                        \$button.attr("disabled", false);
                        \$button.data('cat-id', categoryId)
                            .data('cat-name', categoryName)
                            .data('items', items);
                    } else {
                        \$button.attr("disabled", true);
                    }
                }
            });
            $('button[data-mc-action]').click(function () {
                var \$this = $(this),
                    \$modal = $("{$this->modalSelector}"),
                     action = \$this.data('mc-action'),
                    \$textContainer = $('#mass-categories-action-modal-text', \$modal),
                    categoryId = parseInt(\$this.data('cat-id')),
                    categoryName = \$this.data('cat-name'),
                    items = \$this.data('items');
                    \$textContainer.closest('.alert').removeClass('alert-danger').addClass('alert-info');
                    if (false === isNaN(categoryId)) {
                        switch (action) {
                            case '%1\$s' :
                                \$textContainer.text('{$this->addText} ' + categoryName + '?');
                                break;
                            case '%2\$s' :
                                \$textContainer.text('{$this->moveText} ' + categoryName + '?');
                                break;
                        }
                        \$modal.data('url', "{$this->url}")
                            .data('items', items)
                            .data('cat-id', categoryId)
                            .data('mc-action', action)
                            .modal('show');
                    }
                return false;
            });
JS;
        $this->view->registerJs(sprintf($JS, self::ADD_ACTION, self::MOVE_ACTION));
    }
}

1			<?php
2
3			namespace app\backend\widgets;
4
5
6			use yii\base\Widget;
7			use Yii;
8			use yii\helpers\Html;
9			use yii\base\InvalidParamException;
10			use app\modules\shop\models\Category;
11			use kartik\icons\Icon;
12
13			class CategoryMovementsButtons extends Widget
14			{
15			const MOVE_ACTION = 'move-selected';
16			const ADD_ACTION = 'add-selected';
17			public $url;
18			public $gridSelector;
19			public $wrapperClass = '';
20			public $addText = '';
21			public $moveText = '';
22			/**
23			* @var array here you can define buttons classes like this:
24			* [
25			* 'add-class' => 'btn btn-danger', //class for add button
26			* 'move-class' => 'btn btn-danger', //class for move button
27			* ]
28			*
29			*/
30			public $htmlOptions = [];
31			private $modalSelector = '#mass-categories-actions';
32			private static $categories = [];
33
34			/**
35			* @inheritdoc
36			*/
37			public function init()
38			{
39			if (!isset($this->url, $this->gridSelector)) {
40			throw new InvalidParamException('Attribute \'url\' or \'gridSelector\' is not set');
41			}
42			if (true === empty($this->moveText)) {
43			$this->moveText = Yii::t('app', 'Are you sure you want to move all selected products into');
44			}
45			if (true === empty($this->addText)) {
46			$this->addText = Yii::t('app', 'Are you sure you want to add all selected products into');
47			}
48			if (!isset($this->htmlOptions['id'])) {
49			$this->htmlOptions['id'] = '';
50			}
51			if (true === empty(static::$categories)) {
			1 ignored issue – show Bug introduced 2015-12-23 12:38 UTC by Report Bug Copy Issue Report Since `$categories` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$categories` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
52			$cc = Category::find()
53			->select('id, name')
54			->where(['active' => 1])
55			->asArray(true)
56			->all();
57			foreach ($cc as $k => $cat) {
58			static::$categories[$cat['id']] = $cat['name'];
			1 ignored issue – show Bug introduced 2015-12-23 12:38 UTC by Report Bug Copy Issue Report Since `$categories` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$categories` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
59			}
60			}
61			}
62
63			/**
64			* @return string
65			*/
66			public function run()
67			{
68			$this->registerScript();
69			return $this->renderButtons();
70			}
71
72			/**
73			* @return string
74			*/
75			protected function renderButtons()
76			{
77			$buttons = [
78			self::ADD_ACTION => Html::button(
79			Icon::show('plus') . ' ' .
80			Yii::t('app', 'Add selected to:'),
81			[
82			'class' => isset($this->htmlOptions['add-class']) ?
83			$this->htmlOptions['add-class'] : 'btn btn-default',
84			'disabled' => 'disabled',
85			'data-mc-action' => self::ADD_ACTION
86			]),
87			self::MOVE_ACTION => Html::button(
88			Icon::show('arrows') . ' ' .
89			Yii::t('app', 'Move selected to:'),
90			[
91			'class' => isset($this->htmlOptions['move-class']) ?
92			$this->htmlOptions['move-class'] : 'btn btn-default',
93			'disabled' => 'disabled',
94			'data-mc-action' => self::MOVE_ACTION
95			]),
96
97			];
98			$group = '';
99			foreach ($buttons as $id => $button) {
100			$group .= Html::tag('div',
101			Html::tag('div',
102			$button . "\n\t" . Html::tag('div',
103			Html::dropDownList(null, null, static::$categories, [
			1 ignored issue – show Bug introduced 2015-12-23 12:38 UTC by Report Bug Copy Issue Report Since `$categories` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$categories` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
104			'prompt' => Yii::t('app', 'Select category'),
105			'class' => 'form-control',
106			'id' => $id,
107			]), [
108			'class' => 'input-group',
109			]), [
110			'class' => 'btn-group',
111			]), [
112			'class' => 'col-xs-12 col-sm-6',
113			]);
114			};
115			return Html::tag('div', $group, ['class' => 'row m-bottom-10']);
116			}
117
118			/**
119			*
120			*/
121			protected function registerScript()
122			{
123			$JS = <<<JS
124			$("#%1\$s, #%2\$s").change(function (){
125			var \$this = $(this),
126			buttonSelector = \$this.attr('id'),
127			\$button = $('button[data-mc-action="' + buttonSelector + '"]'),
128			\$selected = $('option:selected', \$this),
129			categoryId = parseInt(\$selected.val()),
130			categoryName = \$selected.text(),
131			items = $("{$this->gridSelector}").yiiGridView('getSelectedRows');
132			if (items.length) {
133			if (false === isNaN(categoryId)) {
134			\$button.attr("disabled", false);
135			\$button.data('cat-id', categoryId)
136			.data('cat-name', categoryName)
137			.data('items', items);
138			} else {
139			\$button.attr("disabled", true);
140			}
141			}
142			});
143			$('button[data-mc-action]').click(function () {
144			var \$this = $(this),
145			\$modal = $("{$this->modalSelector}"),
146			action = \$this.data('mc-action'),
147			\$textContainer = $('#mass-categories-action-modal-text', \$modal),
148			categoryId = parseInt(\$this.data('cat-id')),
149			categoryName = \$this.data('cat-name'),
150			items = \$this.data('items');
151			\$textContainer.closest('.alert').removeClass('alert-danger').addClass('alert-info');
152			if (false === isNaN(categoryId)) {
153			switch (action) {
154			case '%1\$s' :
155			\$textContainer.text('{$this->addText} ' + categoryName + '?');
156			break;
157			case '%2\$s' :
158			\$textContainer.text('{$this->moveText} ' + categoryName + '?');
159			break;
160			}
161			\$modal.data('url', "{$this->url}")
162			.data('items', items)
163			.data('cat-id', categoryId)
164			.data('mc-action', action)
165			.modal('show');
166			}
167			return false;
168			});
169			JS;
170			$this->view->registerJs(sprintf($JS, self::ADD_ACTION, self::MOVE_ACTION));
171			}
172			}

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — filters ( 69e989...d867fc )

CategoryMovementsButtons::registerScript() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like