Wishlist - Code Metrics - Inspection of "Merge pull request #292 from angoliar/wish-list" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 3732bd...eba618 )

by Ivan

created 2016-04-14 07:53 UTC

Wishlist A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	254
Duplicated Lines	10.24 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
wmc	32
c	2
b	0
f	1
lcom	1
cbo	3
dl	26
loc	254
rs	9.6

14 Methods

Rating	Name	Duplication	Size	Complexity
A	tableName()	0	4	1
B	rules()	26	26	1
A	attributeLabels()	0	8	1
A	getUser()	0	4	1
A	getItems()	0	4	1
A	getWishlist()	0	10	2
A	createWishlist()	0	15	2
B	addToWishlist()	0	20	5
A	countItems()	0	17	3
A	setDefaultWishlist()	0	16	4
A	renameWishlist()	0	5	1
A	removeItem()	0	10	1
A	clearWishlist()	0	5	1
C	getTotalPrice()	0	32	8

How to fix Duplicated Code

<?php

namespace app\modules\shop\models;

use yii\db\ActiveRecord;
use Yii;
use app\modules\user\models\User;
use app\modules\shop\models\WishlistProduct;
use app\modules\shop\models\Currency;

/**
 * This is the model class for table "{{%wishlist}}".
 * Model fields:
 * @property integer $id
 * @property integer $user_id
 * @property string $title
 * @property bool $default
 * Relations:
 * @property User $user
 * @property WishlistProduct[] $items
 */
class Wishlist extends ActiveRecord
{

    /**
     * @inheritdoc
     */
    public static function tableName()
    {
        return '{{%wishlist}}';
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            [
                [
                    'user_id',
                    'title',
                    'default',
                ],
                'required'
            ],
            [
                [
                    'user_id',
                ],
                'integer'
            ],
            [
                [
                    'default',
                ],
                'boolean'
            ],
            [['default'], 'default', 'value' => true],
        ];
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'id' => Yii::t('app', 'ID'),
            'user_id' => Yii::t('app', 'User'),
            'title' => Yii::t('app', 'Title'),
        ];
    }

    /**
     * @return User|null
     */
    public function getUser()
    {
        return $this->hasOne(User::className(), ['id' => 'user_id']);
    }

    /**
     * @return WishlistProduct[]|null
     */
    public function getItems()
    {
        return $this->hasMany(WishlistProduct::className(), ['wishlist_id' => 'id']);
    }

    /**
     * @param $user_id
     * @param array $wishlist_ids
     * @return array
     */
    public static function getWishlist($user_id, $wishlist_ids)
    {
        if ($user_id != 0) {
            return self::findAll(['user_id' => $user_id]);
        }
        return self::findAll([
            'id' => $wishlist_ids,
            'user_id' => $user_id,
        ]);
    }

    /**
     * @param string $title
     * @param $user_id
     * @param array $wishlist_ids
     * @param bool $default
     * @return Wishlist|null
     */
    public static function createWishlist($title, $user_id, $wishlist_ids, $default = true)
    {
        $model = new static;
        $model->user_id = $user_id;
        $model->title = $title;
        $model->default = $default;
        if ($model->save(true)) {
            $sessionWishlists = $wishlist_ids;
            $sessionWishlists[] = $model->id;
            Yii::$app->session->set('wishlists', $sessionWishlists);
            return $model;
        }
        Yii::error('Failed to save wishlist');
        return null;
    }

    /**
     * @param $productId
     * @return bool
     */
    public function addToWishlist($productId)
    {
        if ($productId !== null) {
            foreach ($this->items as $item) {
                if ($item->product_id == $productId) {
                    return false;
                }
            }
            $model = new WishlistProduct();
            $model->wishlist_id = $this->id;
            $model->product_id = $productId;
            if ($model->save(true)) {
                return true;
            }
            Yii::error('Failed to save item in wishlist');
            return false;
        }
        Yii::error('Incorrect product_id');
        return false;
    }

    /**
     * @param $user_id
     * @param array $wishlist_ids
     * @param $wishlistId
     * @return int
     */
    public static function countItems($user_id, $wishlist_ids, $wishlistId = null)
    {
        $query = Wishlist::find();
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}
        $query->where(['user_id' => $user_id])
            ->joinWith('items', true, 'INNER JOIN');
        if (null !== $wishlistId) {
            $query->where([
                self::tableName() . '.id' => $wishlistId,
            ]);
        }
        if ($user_id == 0) {
            $query->andWhere([
                self::tableName() . '.id' => $wishlist_ids,
            ]);
        }
        return $query->count();
    }

    /**
     * @param $id
     * @param $user_id
     * @param array $wishlist_ids
     * @return bool
     */
    public static function setDefaultWishlist($id, $user_id, $wishlist_ids)
    {
        if (null !== $wishlists = Wishlist::getWishlist($user_id, $wishlist_ids)) {
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}
            foreach ($wishlists as $wishlist) {
                /** @var Wishlist $wishlist */
                $wishlist->default = false;
                if ($wishlist->id == $id) {
                    $wishlist->default = true;
                }
                $wishlist->save();
            }
            return true;
        }
        Yii::error('Failed to set default wishlist');
        return false;
    }

    /**
     * @param string $title
     * @return bool
     */
    public function renameWishlist($title)
    {
        $this->title = $title;
        return $this->save(true, ['title']);
    }

    /**
     * @param $itemId
     * @return bool
     */
    public function removeItem($itemId)
    {
        /** @var WishlistProduct $item */

        $item = WishlistProduct::findOne([
            'wishlist_id' => $this->id,
            'product_id' => $itemId
        ]);
        return $item->delete();
    }

    /**
     * @return bool
     */
    public function clearWishlist()
    {
        WishlistProduct::deleteAll(['wishlist_id' => $this->id]);
        return true;
    }

    /**
     * @param $user_id
     * @param array $wishlist_ids
     * @param $wishlistId
     * @param array $selections

     * @return string
     */
    public static function getTotalPrice($user_id, $wishlist_ids, $wishlistId = null, $selections = null)
    {
        /** @var WishlistProduct $item */
        $total_price = 0;
        if (null !== $wishlistId) {
            /** @var Wishlist $wishlist */
            $wishlist = static::findOne([
                'id' => $wishlistId,
                'user_id' => $user_id
            ]);
            if (null !== $selections) {
                foreach ($wishlist->items as $item) {
                    if (in_array($item->product_id, $selections)) {
                        $total_price += $item->product->convertedPrice(null, false);
                    }
                }
            } else {
                foreach ($wishlist->items as $item) {
                    $total_price += $item->product->convertedPrice(null, false);
                }
            }

        } else {
            $wishlists = static::getWishlist($user_id, $wishlist_ids);
            foreach ($wishlists as $wishlist) {
                foreach ($wishlist->items as $item) {
                    $total_price += $item->product->convertedPrice(null, false);
                }
            }
        }
        return Currency::getMainCurrency()->format($total_price);
    }
}


1		<?php
2
3		namespace app\modules\shop\models;
4
5		use yii\db\ActiveRecord;
6		use Yii;
7		use app\modules\user\models\User;
8		use app\modules\shop\models\WishlistProduct;
9		use app\modules\shop\models\Currency;
10
11		/**
12		* This is the model class for table "{{%wishlist}}".
13		* Model fields:
14		* @property integer $id
15		* @property integer $user_id
16		* @property string $title
17		* @property bool $default
18		* Relations:
19		* @property User $user
20		* @property WishlistProduct[] $items
21		*/
22		class Wishlist extends ActiveRecord
23		{
24
25		/**
26		* @inheritdoc
27		*/
28		public static function tableName()
29		{
30		return '{{%wishlist}}';
31		}
32
33		/**
34		* @inheritdoc
35		*/
36	View Code Duplication	public function rules()
37		{
38		return [
39		[
40		[
41		'user_id',
42		'title',
43		'default',
44		],
45		'required'
46		],
47		[
48		[
49		'user_id',
50		],
51		'integer'
52		],
53		[
54		[
55		'default',
56		],
57		'boolean'
58		],
59		[['default'], 'default', 'value' => true],
60		];
61		}
62
63		/**
64		* @inheritdoc
65		*/
66		public function attributeLabels()
67		{
68		return [
69		'id' => Yii::t('app', 'ID'),
70		'user_id' => Yii::t('app', 'User'),
71		'title' => Yii::t('app', 'Title'),
72		];
73		}
74
75		/**
76		* @return User\|null
77		*/
78		public function getUser()
79		{
80		return $this->hasOne(User::className(), ['id' => 'user_id']);
81		}
82
83		/**
84		* @return WishlistProduct[]\|null
85		*/
86		public function getItems()
87		{
88		return $this->hasMany(WishlistProduct::className(), ['wishlist_id' => 'id']);
89		}
90
91		/**
92		* @param $user_id
93		* @param array $wishlist_ids
94		* @return array
95		*/
96		public static function getWishlist($user_id, $wishlist_ids)
97		{
98		if ($user_id != 0) {
99		return self::findAll(['user_id' => $user_id]);
100		}
101		return self::findAll([
102		'id' => $wishlist_ids,
103		'user_id' => $user_id,
104		]);
105		}
106
107		/**
108		* @param string $title
109		* @param $user_id
110		* @param array $wishlist_ids
111		* @param bool $default
112		* @return Wishlist\|null
113		*/
114		public static function createWishlist($title, $user_id, $wishlist_ids, $default = true)
115		{
116		$model = new static;
117		$model->user_id = $user_id;
118		$model->title = $title;
119		$model->default = $default;
120		if ($model->save(true)) {
121		$sessionWishlists = $wishlist_ids;
122		$sessionWishlists[] = $model->id;
123		Yii::$app->session->set('wishlists', $sessionWishlists);
124		return $model;
125		}
126		Yii::error('Failed to save wishlist');
127		return null;
128		}
129
130		/**
131		* @param $productId
132		* @return bool
133		*/
134		public function addToWishlist($productId)
135		{
136		if ($productId !== null) {
137		foreach ($this->items as $item) {
138		if ($item->product_id == $productId) {
139		return false;
140		}
141		}
142		$model = new WishlistProduct();
143		$model->wishlist_id = $this->id;
144		$model->product_id = $productId;
145		if ($model->save(true)) {
146		return true;
147		}
148		Yii::error('Failed to save item in wishlist');
149		return false;
150		}
151		Yii::error('Incorrect product_id');
152		return false;
153		}
154
155		/**
156		* @param $user_id
157		* @param array $wishlist_ids
158		* @param $wishlistId
159		* @return int
160		*/
161		public static function countItems($user_id, $wishlist_ids, $wishlistId = null)
162		{
163		$query = Wishlist::find();
		0 ignored issues – show Coding Style introduced 2016-04-04 07:51 UTC by Report Bug Copy Issue Report As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
164		$query->where(['user_id' => $user_id])
165		->joinWith('items', true, 'INNER JOIN');
166		if (null !== $wishlistId) {
167		$query->where([
168		self::tableName() . '.id' => $wishlistId,
169		]);
170		}
171		if ($user_id == 0) {
172		$query->andWhere([
173		self::tableName() . '.id' => $wishlist_ids,
174		]);
175		}
176		return $query->count();
177		}
178
179		/**
180		* @param $id
181		* @param $user_id
182		* @param array $wishlist_ids
183		* @return bool
184		*/
185		public static function setDefaultWishlist($id, $user_id, $wishlist_ids)
186		{
187		if (null !== $wishlists = Wishlist::getWishlist($user_id, $wishlist_ids)) {
		0 ignored issues – show Coding Style introduced 2016-04-04 07:51 UTC by Report Bug Copy Issue Report As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
188		foreach ($wishlists as $wishlist) {
189		/** @var Wishlist $wishlist */
190		$wishlist->default = false;
191		if ($wishlist->id == $id) {
192		$wishlist->default = true;
193		}
194		$wishlist->save();
195		}
196		return true;
197		}
198		Yii::error('Failed to set default wishlist');
199		return false;
200		}
201
202		/**
203		* @param string $title
204		* @return bool
205		*/
206		public function renameWishlist($title)
207		{
208		$this->title = $title;
209		return $this->save(true, ['title']);
210		}
211
212		/**
213		* @param $itemId
214		* @return bool
215		*/
216		public function removeItem($itemId)
217		{
218		/** @var WishlistProduct $item */
219
220		$item = WishlistProduct::findOne([
221		'wishlist_id' => $this->id,
222		'product_id' => $itemId
223		]);
224		return $item->delete();
225		}
226
227		/**
228		* @return bool
229		*/
230		public function clearWishlist()
231		{
232		WishlistProduct::deleteAll(['wishlist_id' => $this->id]);
233		return true;
234		}
235
236		/**
237		* @param $user_id
238		* @param array $wishlist_ids
239		* @param $wishlistId
240		* @param array $selections
		0 ignored issues – show Documentation introduced 2016-03-28 13:46 UTC by Report Bug Copy Issue Report Should the type for parameter `$selections` not be `array\|null`? Also, consider making the array more specific, something like `array<String>`, or `String[]`. This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. In addition it looks for parameters that have the generic type `array` and suggests a stricter type like `array<String>`. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
241		* @return string
242		*/
243		public static function getTotalPrice($user_id, $wishlist_ids, $wishlistId = null, $selections = null)
244		{
245		/** @var WishlistProduct $item */
246		$total_price = 0;
247		if (null !== $wishlistId) {
248		/** @var Wishlist $wishlist */
249		$wishlist = static::findOne([
250		'id' => $wishlistId,
251		'user_id' => $user_id
252		]);
253		if (null !== $selections) {
254		foreach ($wishlist->items as $item) {
255		if (in_array($item->product_id, $selections)) {
256		$total_price += $item->product->convertedPrice(null, false);
257		}
258		}
259		} else {
260		foreach ($wishlist->items as $item) {
261		$total_price += $item->product->convertedPrice(null, false);
262		}
263		}
264
265		} else {
266		$wishlists = static::getWishlist($user_id, $wishlist_ids);
267		foreach ($wishlists as $wishlist) {
268		foreach ($wishlist->items as $item) {
269		$total_price += $item->product->convertedPrice(null, false);
270		}
271		}
272		}
273		return Currency::getMainCurrency()->format($total_price);
274		}
275		}
276

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — master ( 3732bd...eba618 )

Wishlist A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like