BackendReviewController::actionCreate() - Code Metrics - Inspection of "CS" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — filters-dev ( b8c330...c59b06 )

by Ivan

created 2016-03-09 14:10 UTC

BackendReviewController::actionCreate() B

↳ Parent: BackendReviewController

Complexity

Conditions	6
Paths	9

Size

Total Lines	32
Code Lines	21

Duplication

Lines	7
Ratio	21.88 %

Metric	Value
dl	7
loc	32
rs	8.439
cc	6
eloc	21
nc	9
nop	1

<?php

namespace app\modules\review\controllers;

use app\models\Object;
use app\modules\page\models\Page;
use app\modules\review\models\Review;
use app\modules\shop\models\Category;
use app\modules\shop\models\Product;
use yii\db\ActiveRecord;
use yii\filters\AccessControl;
use yii\helpers\Url;
use yii\web\BadRequestHttpException;
use Yii;
use yii\web\NotFoundHttpException;
use app\components\SearchModel;
use app\models\Submission;
use yii\web\Response;

class BackendReviewController extends \app\backend\components\BackendController
{

    const BACKEND_REVIEW_EDIT = 'backend-review-edit';
    const BACKEND_REVIEW_EDIT_SAVE = 'backend-review-edit-save';
    const BACKEND_REVIEW_EDIT_FORM = 'backend-review-edit-form';
    const BACKEND_REVIEW_AFTER_SAVE = 'backend-review-after-save';


    public function behaviors()
    {
        return [
            'access' => [
                'class' => AccessControl::className(),
                'rules' => [
                    [
                        'allow' => true,
                        'roles' => ['review manage'],
                    ],
                ],
            ],
        ];
    }

    public function actionIndex()

    {
        $searchModelConfig = [
            'defaultOrder' => ['id' => SORT_DESC],
            'model' => Review::className(),
            'relations' => [
                'submission.form' => ['name'],
            ],
            'additionalConditions' => [
                ['parent_id' => 0],
            ]
        ];
        $searchModel = new SearchModel($searchModelConfig);
        $dataProvider = $searchModel->search(Yii::$app->request->queryParams);
        return $this->render(
            'index',
            [
                'dataProvider' => $dataProvider,
                'searchModel' => $searchModel,
            ]
        );
    }

    public function actionView($id)

    {
        $model = Review::find()
            ->with(['submission'])
            ->where(['id' => $id])
            ->one();
        if (null === $model) {
            throw new NotFoundHttpException;
        }

        if (true === Yii::$app->request->isPost) {
            if ($model->load(Yii::$app->request->post()) && $model->save()) {
                return $this->redirect(Url::toRoute(['view', 'id' => $model->id]));
            }
        }

        return $this->render('edit', [
            'review' => $model
        ]);
    }

    public function actionUpdateStatus($id = null)

    {
        if (null === $id) {
            $id = \Yii::$app->request->post('editableKey');
            $index = \Yii::$app->request->post('editableIndex');
            if (null === $id || null === $index) {
                throw new BadRequestHttpException;
            } else {
                $review = $this->loadModel($id);
                $reviews = \Yii::$app->request->post('Review', []);
                $review->status = $reviews[$index]['status'];
                return $review->update();
            }
        } else {
            $reviews = $reviews = \Yii::$app->request->post('Review');
            $status = $reviews['status'];
            $review = $this->loadModel($id);
            $review->status = $status;
            if ($review->update()) {
                Yii::$app->session->setFlash('success', Yii::t('app', 'Review successfully updated'));
            } else {
                Yii::$app->session->setFlash('error', Yii::t('app', 'Error occurred while updating review'));
            }
            return $this->redirect(
                Url::toRoute(
                    [
                        'view',
                        'id' => $review->id
                    ]
                )
            );
        }
    }

    public function actionMarkSpam($id, $spam = 1)

    {
        if ($spam === 1) {
            $message = Yii::t('app', 'Entry successfully marked as spam');
        } else {
            $message = Yii::t('app', 'Entry successfully marked as not spam');
        }
        /** @var Submission $submission */
        $submission = Submission::findOne($id);
        if (is_null($submission)) {
            throw new NotFoundHttpException;
        }
        $submission->spam = $spam;
        if ($spam == 1) {
            /** @var Review $review */
            $review = Review::findOne(['submission_id' => $id]);
            if (!is_null($review)) {
                $review->status = Review::STATUS_NOT_APPROVED;
                $review->save(true, ['status']);
            }
        }
        if ($submission->save(true, ['spam'])) {
            Yii::$app->session->setFlash('success', $message);
        }
        return $this->redirect(
            Url::toRoute(
                [
                    'view',
                    'id' => $id
                ]
            )
        );
    }

    /**
     * @param $id
     * @param null $returnUrl
     * @return Response
     * @throws NotFoundHttpException
     * @throws \Exception
     */
    public function actionDelete($id, $returnUrl = null)
    {
        $model = $this->loadModel($id);
        $parent_id = $model->parent_id;
        if ($model->delete()) {
            Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
        }

        $returnUrl = !empty($returnUrl)
            ? $returnUrl
            : (0 === intval($parent_id) ? Url::toRoute(['index']) : Url::toRoute(['view', 'id' => $parent_id]));
        return $this->redirect($returnUrl);
    }

    /**
     * @param array $returnUrl
     * @return Response
     * @throws \Exception
     */
    public function actionRemoveAll($returnUrl = ['index'])
    {
        $items = Yii::$app->request->post('items', []);
        if (!empty($items)) {
            $items = Review::findAll(['id' => $items]);
            foreach ($items as $item) {
                $item->delete();
            }
            Yii::$app->session->setFlash('info', Yii::t('app', 'Objects removed'));
        }
        return $this->redirect($returnUrl);
    }

    /**
     * Load review model by id
     * @param $id
     * @return Review
     * @throws NotFoundHttpException
     */
    protected function loadModel($id)
    {
        $model = Review::findOne($id);
        if (is_null($model)) {
            throw new NotFoundHttpException;
        }
        return $model;
    }

    public function actionCreate($parent_id = 0)

    {
        $parent_id = intval($parent_id);
        $model = new Review();
        $model->loadDefaultValues();

        if (0 === $parent_id) {
            $model->parent_id = $parent_id;
            $model->submission_id = 0;
            $model->object_model_id = 0;
            $model->object_id = 0;
        } elseif (null !== $parent = Review::findOne(['id' => $parent_id])) {
            /** @var Review $parent */
            $model->parent_id = $parent_id;
            $model->object_id = $parent->object_id;
            $model->object_model_id = $parent->object_model_id;
            $model->root_id = $parent->root_id;
            $model->submission_id = $parent->submission_id;
        }

        if (true === Yii::$app->request->isPost) {
            if ($model->load(Yii::$app->request->post()) && $model->save()) {
                return $this->redirect(Url::toRoute(['view', 'id' => $model->id]));
            } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
                // @todo add alert and may be something else here

            }
        }

        return $this->render('edit', [
            'review' => $model
        ]);
    }

    /**
     * @return array

     */
    public function actionAjaxSearch()
    {
        Yii::$app->response->format = Response::FORMAT_JSON;
        $search = \Yii::$app->request->get('search', []);
        $object = !empty($search['object']) ?  intval($search['object']) : 0;
        $term = !empty($search['term']) ?  $search['term'] : '';

        $result = [
            'more' => false,
            'results' => []
        ];

        if (null === $object = Object::findById($object)) {
            return $result;
        }

        /** @var ActiveRecord $class */
        $class = $object->object_class;
        $list = [
            Product::className(),
            Category::className(),
            Page::className(),
        ];
        if (!in_array($class, $list)) {
            return $result;
        }

        $query = $class::find()
            ->select('id, name, "#" `url`')
            ->andWhere(['like', 'name', $term])
            ->asArray(true);
        $result['results'] = array_values($query->all());
        array_walk($result['results'],
            function (&$val) use ($class)
            {
                if (null !== $model = $class::findOne(['id' => $val['id']])) {
                    if (Product::className() === $model->className()) {
                        $val['url'] = Url::toRoute([
                            '@product',
                            'model' => $model,
                            'category_group_id' => $model->category->category_group_id,
                        ]);
                    } elseif (Category::className() === $model->className()) {
                        $val['url'] = Url::toRoute([
                            '@category',
                            'last_category_id' => $model->id,
                            'category_group_id' => $model->category_group_id,
                        ]);
                    } else if (Page::className() === $model->className()) {
                        $val['url'] = Url::toRoute([
                            '@article',
                            'id' => $model->id,
                        ]);
                    }
                }
            });

        return $result;
    }

    /**
     * @return array
     */
    public function actionAjaxGetTree($root_id = null, $current_id = 0)
    {
        Yii::$app->response->format = Response::FORMAT_JSON;

        $q = Review::find()
            ->select('*')
            ->where(['root_id' => $root_id])
            ->orderBy(['parent_id' => SORT_ASC])
            ->asArray(true);

        $result = array_reduce($q->all(),
            function ($res, $item) use ($current_id)
            {
                $res[] = [
                    'id' => $item['id'],
                    'parent' => 0 === intval($item['parent_id']) ? '#' : $item['parent_id'],
                    'text' => $item['id'],
                    'type' => intval($item['id']) === intval($current_id) ? 'current' : 'leaf',
                    'a_attr' => [
                        'data-id' => $item['id'],
                    ]
                ];
                return $res;
            }, []);

        return $result;
    }
}


1		<?php
2
3		namespace app\modules\review\controllers;
4
5		use app\models\Object;
6		use app\modules\page\models\Page;
7		use app\modules\review\models\Review;
8		use app\modules\shop\models\Category;
9		use app\modules\shop\models\Product;
10		use yii\db\ActiveRecord;
11		use yii\filters\AccessControl;
12		use yii\helpers\Url;
13		use yii\web\BadRequestHttpException;
14		use Yii;
15		use yii\web\NotFoundHttpException;
16		use app\components\SearchModel;
17		use app\models\Submission;
18		use yii\web\Response;
19
20		class BackendReviewController extends \app\backend\components\BackendController
21		{
22
23		const BACKEND_REVIEW_EDIT = 'backend-review-edit';
24		const BACKEND_REVIEW_EDIT_SAVE = 'backend-review-edit-save';
25		const BACKEND_REVIEW_EDIT_FORM = 'backend-review-edit-form';
26		const BACKEND_REVIEW_AFTER_SAVE = 'backend-review-after-save';
27
28
29	View Code Duplication	public function behaviors()
30		{
31		return [
32		'access' => [
33		'class' => AccessControl::className(),
34		'rules' => [
35		[
36		'allow' => true,
37		'roles' => ['review manage'],
38		],
39		],
40		],
41		];
42		}
43
44		public function actionIndex()
		0 ignored issues – show Documentation introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
45		{
46		$searchModelConfig = [
47		'defaultOrder' => ['id' => SORT_DESC],
48		'model' => Review::className(),
49		'relations' => [
50		'submission.form' => ['name'],
51		],
52		'additionalConditions' => [
53		['parent_id' => 0],
54		]
55		];
56		$searchModel = new SearchModel($searchModelConfig);
57		$dataProvider = $searchModel->search(Yii::$app->request->queryParams);
58		return $this->render(
59		'index',
60		[
61		'dataProvider' => $dataProvider,
62		'searchModel' => $searchModel,
63		]
64		);
65		}
66
67		public function actionView($id)
		0 ignored issues – show Documentation introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
68		{
69		$model = Review::find()
70		->with(['submission'])
71		->where(['id' => $id])
72		->one();
73		if (null === $model) {
74		throw new NotFoundHttpException;
75		}
76
77	View Code Duplication	if (true === Yii::$app->request->isPost) {
78		if ($model->load(Yii::$app->request->post()) && $model->save()) {
79		return $this->redirect(Url::toRoute(['view', 'id' => $model->id]));
80		}
81		}
82
83		return $this->render('edit', [
84		'review' => $model
85		]);
86		}
87
88		public function actionUpdateStatus($id = null)
		0 ignored issues – show Documentation introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
89		{
90		if (null === $id) {
91		$id = \Yii::$app->request->post('editableKey');
92		$index = \Yii::$app->request->post('editableIndex');
93		if (null === $id \|\| null === $index) {
94		throw new BadRequestHttpException;
95		} else {
96		$review = $this->loadModel($id);
97		$reviews = \Yii::$app->request->post('Review', []);
98		$review->status = $reviews[$index]['status'];
99		return $review->update();
100		}
101		} else {
102		$reviews = $reviews = \Yii::$app->request->post('Review');
103		$status = $reviews['status'];
104		$review = $this->loadModel($id);
105		$review->status = $status;
106		if ($review->update()) {
107		Yii::$app->session->setFlash('success', Yii::t('app', 'Review successfully updated'));
108		} else {
109		Yii::$app->session->setFlash('error', Yii::t('app', 'Error occurred while updating review'));
110		}
111		return $this->redirect(
112		Url::toRoute(
113		[
114		'view',
115		'id' => $review->id
116		]
117		)
118		);
119		}
120		}
121
122		public function actionMarkSpam($id, $spam = 1)
		0 ignored issues – show Documentation introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
123		{
124		if ($spam === 1) {
125		$message = Yii::t('app', 'Entry successfully marked as spam');
126		} else {
127		$message = Yii::t('app', 'Entry successfully marked as not spam');
128		}
129		/** @var Submission $submission */
130		$submission = Submission::findOne($id);
131		if (is_null($submission)) {
132		throw new NotFoundHttpException;
133		}
134		$submission->spam = $spam;
135		if ($spam == 1) {
136		/** @var Review $review */
137		$review = Review::findOne(['submission_id' => $id]);
138		if (!is_null($review)) {
139		$review->status = Review::STATUS_NOT_APPROVED;
140		$review->save(true, ['status']);
141		}
142		}
143		if ($submission->save(true, ['spam'])) {
144		Yii::$app->session->setFlash('success', $message);
145		}
146		return $this->redirect(
147		Url::toRoute(
148		[
149		'view',
150		'id' => $id
151		]
152		)
153		);
154		}
155
156		/**
157		* @param $id
158		* @param null $returnUrl
159		* @return Response
160		* @throws NotFoundHttpException
161		* @throws \Exception
162		*/
163		public function actionDelete($id, $returnUrl = null)
164		{
165		$model = $this->loadModel($id);
166		$parent_id = $model->parent_id;
167		if ($model->delete()) {
168		Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
169		}
170
171		$returnUrl = !empty($returnUrl)
172		? $returnUrl
173		: (0 === intval($parent_id) ? Url::toRoute(['index']) : Url::toRoute(['view', 'id' => $parent_id]));
174		return $this->redirect($returnUrl);
175		}
176
177		/**
178		* @param array $returnUrl
179		* @return Response
180		* @throws \Exception
181		*/
182		public function actionRemoveAll($returnUrl = ['index'])
183		{
184		$items = Yii::$app->request->post('items', []);
185		if (!empty($items)) {
186		$items = Review::findAll(['id' => $items]);
187		foreach ($items as $item) {
188		$item->delete();
189		}
190		Yii::$app->session->setFlash('info', Yii::t('app', 'Objects removed'));
191		}
192		return $this->redirect($returnUrl);
193		}
194
195		/**
196		* Load review model by id
197		* @param $id
198		* @return Review
199		* @throws NotFoundHttpException
200		*/
201		protected function loadModel($id)
202		{
203		$model = Review::findOne($id);
204		if (is_null($model)) {
205		throw new NotFoundHttpException;
206		}
207		return $model;
208		}
209
210		public function actionCreate($parent_id = 0)
		0 ignored issues – show Documentation introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
211		{
212		$parent_id = intval($parent_id);
213		$model = new Review();
214		$model->loadDefaultValues();
215
216		if (0 === $parent_id) {
217		$model->parent_id = $parent_id;
218		$model->submission_id = 0;
219		$model->object_model_id = 0;
220		$model->object_id = 0;
221		} elseif (null !== $parent = Review::findOne(['id' => $parent_id])) {
222		/** @var Review $parent */
223		$model->parent_id = $parent_id;
224		$model->object_id = $parent->object_id;
225		$model->object_model_id = $parent->object_model_id;
226		$model->root_id = $parent->root_id;
227		$model->submission_id = $parent->submission_id;
228		}
229
230	View Code Duplication	if (true === Yii::$app->request->isPost) {
231		if ($model->load(Yii::$app->request->post()) && $model->save()) {
232		return $this->redirect(Url::toRoute(['view', 'id' => $model->id]));
233		} else {
		0 ignored issues – show Unused Code introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report This `else` statement is empty and can be removed. This check looks for the `else` branches of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `else` branches can be removed. if (rand(1, 6) > 3) { print "Check failed"; } else { //print "Check succeeded"; } could be turned into if (rand(1, 6) > 3) { print "Check failed"; } This is much more concise to read. Loading history...
234		// @todo add alert and may be something else here
		0 ignored issues – show Coding Style Best Practice introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history...
235		}
236		}
237
238		return $this->render('edit', [
239		'review' => $model
240		]);
241		}
242
243		/**
244		* @return array
		0 ignored issues – show Documentation introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `array<string,false\|array>`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
245		*/
246		public function actionAjaxSearch()
247		{
248		Yii::$app->response->format = Response::FORMAT_JSON;
249		$search = \Yii::$app->request->get('search', []);
250		$object = !empty($search['object']) ? intval($search['object']) : 0;
251		$term = !empty($search['term']) ? $search['term'] : '';
252
253		$result = [
254		'more' => false,
255		'results' => []
256		];
257
258		if (null === $object = Object::findById($object)) {
259		return $result;
260		}
261
262		/** @var ActiveRecord $class */
263		$class = $object->object_class;
264		$list = [
265		Product::className(),
266		Category::className(),
267		Page::className(),
268		];
269		if (!in_array($class, $list)) {
270		return $result;
271		}
272
273		$query = $class::find()
274		->select('id, name, "#" `url`')
275		->andWhere(['like', 'name', $term])
276		->asArray(true);
277		$result['results'] = array_values($query->all());
278		array_walk($result['results'],
279		function (&$val) use ($class)
280		{
281		if (null !== $model = $class::findOne(['id' => $val['id']])) {
282		if (Product::className() === $model->className()) {
283		$val['url'] = Url::toRoute([
284		'@product',
285		'model' => $model,
286		'category_group_id' => $model->category->category_group_id,
287		]);
288		} elseif (Category::className() === $model->className()) {
289		$val['url'] = Url::toRoute([
290		'@category',
291		'last_category_id' => $model->id,
292		'category_group_id' => $model->category_group_id,
293		]);
294		} else if (Page::className() === $model->className()) {
295		$val['url'] = Url::toRoute([
296		'@article',
297		'id' => $model->id,
298		]);
299		}
300		}
301		});
302
303		return $result;
304		}
305
306		/**
307		* @return array
308		*/
309		public function actionAjaxGetTree($root_id = null, $current_id = 0)
310		{
311		Yii::$app->response->format = Response::FORMAT_JSON;
312
313		$q = Review::find()
314		->select('*')
315		->where(['root_id' => $root_id])
316		->orderBy(['parent_id' => SORT_ASC])
317		->asArray(true);
318
319		$result = array_reduce($q->all(),
320		function ($res, $item) use ($current_id)
321		{
322		$res[] = [
323		'id' => $item['id'],
324		'parent' => 0 === intval($item['parent_id']) ? '#' : $item['parent_id'],
325		'text' => $item['id'],
326		'type' => intval($item['id']) === intval($current_id) ? 'current' : 'leaf',
327		'a_attr' => [
328		'data-id' => $item['id'],
329		]
330		];
331		return $res;
332		}, []);
333
334		return $result;
335		}
336		}
337

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — filters-dev ( b8c330...c59b06 )

BackendReviewController::actionCreate() B

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like