BackendChunkController - Code Metrics - Inspection of "Epic merge of filters and master begins" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( e91cf6...3a6b3f )

by Alexander

created 2016-01-26 06:30 UTC

BackendChunkController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	125
Duplicated Lines	23.2 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	19
lcom	1
cbo	12
dl	29
loc	125
rs	10
c	1
b	0
f	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	actionDelete()	15	15	4
A	actions()	0	18	1
A	behaviors()	14	14	1
A	actionIndex()	0	17	1
D	actionEdit()	0	40	9
A	actionRemoveAll()	0	11	3

How to fix Duplicated Code

<?php

namespace app\modules\core\controllers;

use app\backend\components\BackendController;
use app\backend\traits\BackendRedirect;
use app\modules\core\models\ContentBlockGroup;
use devgroup\JsTreeWidget\AdjacencyFullTreeDataAction;
use devgroup\JsTreeWidget\TreeNodeMoveAction;
use devgroup\JsTreeWidget\TreeNodesReorderAction;
use yii\filters\AccessControl;
use app\modules\core\models\ContentBlock;
use Yii;
use yii\helpers\Url;
use yii\web\NotFoundHttpException;

class BackendChunkController extends BackendController
{
    use BackendRedirect;

    public function actions()
    {
        return [
            'getTree' => [
                'class' => AdjacencyFullTreeDataAction::className(),
                'class_name' => ContentBlockGroup::className(),
                'model_label_attribute' => 'name',
            ],
            'move' => [
                'class' => TreeNodeMoveAction::className(),
                'className' => ContentBlockGroup::className(),
            ],
            'reorder' => [
                'class' => TreeNodesReorderAction::className(),
                'className' => ContentBlockGroup::className(),
            ],
        ];
    }

    public function behaviors()
    {
        return [
            'access' => [
                'class' => AccessControl::className(),
                'rules' => [
                    [
                        'allow' => true,
                        'roles' => ['content manage'],
                    ],
                ],
            ],
        ];
    }

    public function actionIndex()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $searchModel = new ContentBlock(['scenario' => 'search']);
        $group_id = Yii::$app->request->get('group_id', null);
        $searchModel->group_id = $group_id;
        $dataProvider = $searchModel->search($_GET);


        return $this->render(
            'index',
            [
                'dataProvider' => $dataProvider,
                'searchModel' => $searchModel,
                'parent_id' => $group_id
            ]
        );
    }

    public function actionEdit($id = null, $group_id = null)

    {
        /** @var null|ContentBlock $model */
        $model = new ContentBlock();
        if ($id !== null) {
            $model = ContentBlock::findOne($id);
        }

        if ($model->isNewRecord === true && $group_id !== null) {
            $model->group_id = $group_id;
        }
        $model->loadDefaultValues();


        $post = \Yii::$app->request->post();
        if ($model->load($post) && $model->validate()) {
            if (!empty($model->newGroup)) {
                $group = new ContentBlockGroup([
                    'name' => $model->newGroup,
                ]);
                $group->loadDefaultValues();
                if ($group->save()) {
                    $model->group_id = $group->id;
                }
            }
            $save_result = $model->save();
            if ($save_result) {
                Yii::$app->session->setFlash('info', Yii::t('app', 'Object saved'));
                $this->redirectUser($model->id);
            } else {
                \Yii::$app->session->setFlash('error', Yii::t('app', 'Cannot update data'));
            }
        }
        return $this->render(
            'edit',
            [
                'model' => $model,
            ]
        );
    }

    public function actionDelete($id = null)
    {
        if ((null === $id) || (null === $model = ContentBlock::findOne($id))) {
            throw new NotFoundHttpException;
        }
        if ($model->delete()) {

            Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
        }
        return $this->redirect(
            Yii::$app->request->get(
                'returnUrl',
                Url::toRoute(['index'])
            )
        );
    }

    public function actionRemoveAll()
    {
        $items = Yii::$app->request->post('items', []);
        if (!empty($items)) {
            $items = ContentBlock::find()->where(['in', 'id', $items])->all();
            foreach ($items as $item) {
                $item->delete();
            }
        }
        return $this->redirect(['index']);
    }
}

1		<?php
2
3		namespace app\modules\core\controllers;
4
5		use app\backend\components\BackendController;
6		use app\backend\traits\BackendRedirect;
7		use app\modules\core\models\ContentBlockGroup;
8		use devgroup\JsTreeWidget\AdjacencyFullTreeDataAction;
9		use devgroup\JsTreeWidget\TreeNodeMoveAction;
10		use devgroup\JsTreeWidget\TreeNodesReorderAction;
11		use yii\filters\AccessControl;
12		use app\modules\core\models\ContentBlock;
13		use Yii;
14		use yii\helpers\Url;
15		use yii\web\NotFoundHttpException;
16
17		class BackendChunkController extends BackendController
18		{
19		use BackendRedirect;
20
21		public function actions()
22		{
23		return [
24		'getTree' => [
25		'class' => AdjacencyFullTreeDataAction::className(),
26		'class_name' => ContentBlockGroup::className(),
27		'model_label_attribute' => 'name',
28		],
29		'move' => [
30		'class' => TreeNodeMoveAction::className(),
31		'className' => ContentBlockGroup::className(),
32		],
33		'reorder' => [
34		'class' => TreeNodesReorderAction::className(),
35		'className' => ContentBlockGroup::className(),
36		],
37		];
38		}
39
40	View Code Duplication	public function behaviors()
41		{
42		return [
43		'access' => [
44		'class' => AccessControl::className(),
45		'rules' => [
46		[
47		'allow' => true,
48		'roles' => ['content manage'],
49		],
50		],
51		],
52		];
53		}
54
55		public function actionIndex()
		0 ignored issues – show Documentation introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Coding Style introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report `actionIndex` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
56		{
57		$searchModel = new ContentBlock(['scenario' => 'search']);
58		$group_id = Yii::$app->request->get('group_id', null);
59		$searchModel->group_id = $group_id;
60		$dataProvider = $searchModel->search($_GET);
61
62
63		return $this->render(
64		'index',
65		[
66		'dataProvider' => $dataProvider,
67		'searchModel' => $searchModel,
68		'parent_id' => $group_id
69		]
70		);
71		}
72
73		public function actionEdit($id = null, $group_id = null)
		0 ignored issues – show Documentation introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
74		{
75		/** @var null\|ContentBlock $model */
76		$model = new ContentBlock();
77		if ($id !== null) {
78		$model = ContentBlock::findOne($id);
79		}
80
81		if ($model->isNewRecord === true && $group_id !== null) {
82		$model->group_id = $group_id;
83		}
84		$model->loadDefaultValues();
85
86
87		$post = \Yii::$app->request->post();
88		if ($model->load($post) && $model->validate()) {
89		if (!empty($model->newGroup)) {
90		$group = new ContentBlockGroup([
91		'name' => $model->newGroup,
92		]);
93		$group->loadDefaultValues();
94		if ($group->save()) {
95		$model->group_id = $group->id;
96		}
97		}
98		$save_result = $model->save();
99		if ($save_result) {
100		Yii::$app->session->setFlash('info', Yii::t('app', 'Object saved'));
101		$this->redirectUser($model->id);
102		} else {
103		\Yii::$app->session->setFlash('error', Yii::t('app', 'Cannot update data'));
104		}
105		}
106		return $this->render(
107		'edit',
108		[
109		'model' => $model,
110		]
111		);
112		}
113
114	View Code Duplication	public function actionDelete($id = null)
115		{
116		if ((null === $id) \|\| (null === $model = ContentBlock::findOne($id))) {
117		throw new NotFoundHttpException;
118		}
119		if ($model->delete()) {
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `delete` cannot be called on `$model` (of type `array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
120		Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
121		}
122		return $this->redirect(
123		Yii::$app->request->get(
124		'returnUrl',
125		Url::toRoute(['index'])
126		)
127		);
128		}
129
130		public function actionRemoveAll()
131		{
132		$items = Yii::$app->request->post('items', []);
133		if (!empty($items)) {
134		$items = ContentBlock::find()->where(['in', 'id', $items])->all();
135		foreach ($items as $item) {
136		$item->delete();
137		}
138		}
139		return $this->redirect(['index']);
140		}
141		}

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — master ( e91cf6...3a6b3f )

BackendChunkController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like