PropertyStaticValues - Code Metrics - Inspection of "Epic merge of filters and master begins" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( e91cf6...3a6b3f )

by Alexander

created 2016-01-26 06:30 UTC

PropertyStaticValues B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	367
Duplicated Lines	26.43 %

Coupling/Cohesion

Components	1
Dependencies	16

Importance

Changes	4
Bugs	2	Features	0

Metric	Value
wmc	39
c	4
b	2
f	0
lcom	1
cbo	16
dl	97
loc	367
rs	7.0627

15 Methods

Rating	Name	Duplication	Size	Complexity
A	tableName()	0	4	1
A	getProperty()	0	4	1
A	rules()	9	9	1
A	attributeLabels()	0	14	1
A	search()	20	20	2
B	findById()	28	28	4
A	getValuesForPropertyId()	0	10	3
A	getSelectForPropertyId()	0	9	2
A	initSubQuery()	0	17	1
B	arrayOfValuesForPropertyId()	16	30	3
A	afterSave()	0	7	2
A	beforeDelete()	0	7	2
A	afterDelete()	0	5	1
A	behaviors()	0	18	1
D	getValuesForFilter()	24	120	14

How to fix Duplicated Code

<?php

namespace app\models;

use app\modules\shop\models\Product;
use app\properties\HasProperties;
use app\traits\GetImages;
use app\traits\SortModels;
use devgroup\TagDependencyHelper\ActiveRecordHelper;
use Yii;
use yii\behaviors\AttributeBehavior;
use yii\caching\TagDependency;
use yii\data\ActiveDataProvider;
use yii\db\ActiveQuery;
use yii\db\ActiveRecord;
use yii\db\Expression;

/**
 * This is the model class for table "property_static_values".
 * @property integer $id
 * @property integer $property_id
 * @property string $name
 * @property string $value
 * @property string $slug
 * @property integer $sort_order
 * @property Property $property
 * @property integer $dont_filter
 */
class PropertyStaticValues extends ActiveRecord
{
    use GetImages;

    public static $identity_map_by_property_id = [];
    private static $identity_map = [];

    use SortModels;

    /**
     * @inheritdoc
     */
    public function behaviors()
    {
        return [
            [
                'class' => AttributeBehavior::className(),
                'attributes' => [
                    \yii\db\ActiveRecord::EVENT_BEFORE_INSERT => 'sort_order',
                ],
                'value' => 0,
            ],
            [
                'class' => ActiveRecordHelper::className(),
            ],
            [
                'class' => HasProperties::className(),
            ],
        ];
    }

    /**
     * @inheritdoc
     */
    public static function tableName()
    {
        return '{{%property_static_values}}';
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            [['property_id', 'name', 'value'], 'required'],
            [['property_id', 'sort_order', 'dont_filter'], 'integer'],
            [['title_prepend'], 'boolean'],
            [['name', 'value', 'slug', 'title_append'], 'string']
        ];
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'id' => Yii::t('app', 'ID'),
            'property_id' => Yii::t('app', 'Property ID'),
            'name' => Yii::t('app', 'Name'),
            'value' => Yii::t('app', 'Value'),
            'slug' => Yii::t('app', 'Slug'),
            'sort_order' => Yii::t('app', 'Sort Order'),
            'title_append' => Yii::t('app', 'Title append'),
            'title_prepend' => Yii::t('app', 'Prepend title?'),
            'dont_filter' => Yii::t('app', 'Don\'t filter (for FilterWidget only)'),
        ];
    }

    /**
     * Search tasks
     * @param $params
     * @return ActiveDataProvider
     */
    public function search($params)
    {
        $query = static::find()->where(['property_id' => $this->property_id]);
        $dataProvider = new ActiveDataProvider(
            [
                'query' => $query,
                'pagination' => [
                    'pageSize' => 10,
                ],
            ]
        );
        if (!($this->load($params))) {
            return $dataProvider;
        }
        $query->andFilterWhere(['id' => $this->id]);
        $query->andFilterWhere(['like', 'name', $this->name]);
        $query->andFilterWhere(['like', 'value', $this->value]);
        $query->andFilterWhere(['like', 'slug', $this->slug]);
        return $dataProvider;
    }

    public function getProperty()
    {
        return $this->hasOne(Property::className(), ['id' => 'property_id']);
    }

    /**
     * Возвращает Массив! по ID с использованием IdentityMap
     * @param int $id
     * @return null|PropertyStaticValues
     */
    public static function findById($id)
    {
        if (!isset(static::$identity_map[$id])) {
            $cacheKey = "PropertyStaticValue:$id";

            if (false === $property = Yii::$app->cache->get($cacheKey)) {
                if (null !== $property = static::find()->where(['id' => $id])->asArray()->one()) {
                    Yii::$app->cache->set(
                        $cacheKey,
                        $property,
                        0,
                        new TagDependency(
                            [
                                'tags' => [
                                    \devgroup\TagDependencyHelper\ActiveRecordHelper::getObjectTag(
                                        static::className(),
                                        $id
                                    ),
                                ],
                            ]
                        )
                    );
                }
            }
            static::$identity_map[$id] = $property;
        }
        return static::$identity_map[$id];
    }

    /**
     * Возвращает массив возможных значений свойств по property_id
     * Внимание! Это массивы, а не объекты!
     * Это сделано для экономии памяти.
     * Используется identity_map
     *
     * @return array
     */
    public static function getValuesForPropertyId($property_id)
    {
        if (!isset(static::$identity_map_by_property_id[$property_id])) {
            static::$identity_map_by_property_id[$property_id] = static::arrayOfValuesForPropertyId($property_id);
            foreach (static::$identity_map_by_property_id[$property_id] as $psv) {
                static::$identity_map[$psv['id']] = $psv;
            }
        }
        return static::$identity_map_by_property_id[$property_id];
    }

    public static function getSelectForPropertyId($property_id)
    {
        $values = PropertyStaticValues::getValuesForPropertyId($property_id);
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}
        $result = [];
        foreach ($values as $row) {
            $result[$row['id']] = $row['name'];
        }
        return $result;
    }

    /**
     * @param $property_id
     * @param $category_id
     * @param $properties
     * @return PropertyStaticValues[]
     */
    public static function getValuesForFilter($property_id, $category_id, $properties, $multiple = false, $parentsOnly = true)

    {
        $priceMin = Yii::$app->request->get('price_min');
        $priceMax = Yii::$app->request->get('price_max');
        $cacheKey = "getValuesForFilter:" . json_encode([$property_id, $category_id, $properties, $priceMin, $priceMax]);

        if (false === $allSelections = Yii::$app->cache->get($cacheKey)) {
            $joinCondition = (true === $parentsOnly) ?
                'p.id = {{%product_category}}.object_model_id AND p.active = 1 AND p.parent_id = 0'
                : 'p.id = {{%product_category}}.object_model_id AND p.active = 1';
            $objectModel = Object::getForClass(Product::className());
            $objectId = $objectModel !== null ? $objectModel->id : 0;
            $allSelections = static::find()
                ->asArray(true)
                ->select([self::tableName() . '.id', self::tableName() . '.name', 'value', self::tableName() . '.slug'])
                ->innerJoin(
                    ObjectStaticValues::tableName(),
                    ObjectStaticValues::tableName() . '.property_static_value_id=' . self::tableName() . '.id'
                )
                ->innerJoin(
                    '{{%product_category}}',
                    '{{%product_category}}.object_model_id = ' . ObjectStaticValues::tableName() . '.object_model_id'
                )
                ->innerJoin(
                    Product::tableName() . ' p',
                    $joinCondition
                )
                ->where(
                    [
                        self::tableName() . '.property_id' => $property_id,
                        self::tableName() . '.dont_filter' => 0,
                        '{{%product_category}}.category_id' => $category_id,
                    ]
                )
                ->orderBy(
                    [
                        self::tableName() . '.sort_order' => SORT_ASC,
                        self::tableName() . '.name' => SORT_ASC,
                    ]
                )
                ->all();
            /** @var ActiveQuery $query */
            $query = ObjectStaticValues::find()
                ->distinct(true)
                ->select(ObjectStaticValues::tableName() . '.object_model_id')
                ->where(['object_id' => $objectId]);
            if (false === empty($properties)) {
                foreach ($properties as $propertyId => $propertyStaticValues) {
                    $subQuery = self::initSubQuery($category_id, $joinCondition);
                    $subQuery->andWhere(['property_static_value_id' => $propertyStaticValues,]);
                    $subQueryOptimisation = Yii::$app->db->cache(function($db) use ($subQuery) {
                        $ids = implode(', ', $subQuery->createCommand($db)->queryColumn());
                        return empty($ids) === true ? '(-1)' : "($ids)";
                    }, 86400, new TagDependency([
                        'tags' => [
                            ActiveRecordHelper::getCommonTag(ObjectStaticValues::className()),
                        ]
                    ]));
                    $query->andWhere(new Expression('`object_model_id` IN ' . $subQueryOptimisation));
                }
            }
            if (false === empty($priceMin) && false === empty($priceMax)) {
                $subQuery = self::initSubQuery($category_id, $joinCondition);
                $subQuery
                    ->andWhere(['>=', 'p.price', $priceMin])
                    ->andWhere(['<=', 'p.price', $priceMax]);
                $subQueryOptimisation = Yii::$app->db->cache(function($db) use ($subQuery) {
                    $ids = implode(', ', $subQuery->createCommand($db)->queryColumn());
                    return empty($ids) === true ? '(-1)' : "($ids)";
                }, 86400, new TagDependency([
                    'tags' => [
                        ActiveRecordHelper::getCommonTag(ObjectStaticValues::className()),
                    ]
                ]));
                $query->andWhere(new Expression('`object_model_id` IN ' . $subQueryOptimisation));
            }
            $selectedQuery = static::find()
                ->select(static::tableName() . '.id')
                ->asArray(true)
                ->innerJoin(
                    ObjectStaticValues::tableName(),
                    ObjectStaticValues::tableName() . '.property_static_value_id = ' . static::tableName() . '.id'
                )
                ->where([
                    'property_id' => $property_id,
                ])
                ->andWhere(
                    new Expression(
                        ObjectStaticValues::tableName() . '.object_model_id IN (' . $query->createCommand()->getRawSql() . ')'

                    )
                );
            if (false == $multiple) {

                if (isset($properties[$property_id])) {
                    $selectedQuery->andWhere([self::tableName() . '.id' => $properties[$property_id]]);
                }
            } else {
                unset($properties[$property_id]);
            }
            $selected = $selectedQuery->column();
            foreach ($allSelections as $index => $selection) {
                $allSelections[$index]['active'] = in_array($selection['id'], $selected);
            }
            if (null !== $allSelections) {
                Yii::$app->cache->set(
                    $cacheKey,
                    $allSelections,
                    0,
                    new TagDependency(
                        [
                            'tags' => [
                                ActiveRecordHelper::getCommonTag(PropertyStaticValues::className()),
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}
                                ActiveRecordHelper::getCommonTag(Property::className()),
                            ]

                        ]
                    )
                );
            }
        }
        return $allSelections;
    }

    private static function initSubQuery($category_id, $joinCondition)
    {
        $subQuery = ObjectStaticValues::find();
        return $subQuery
            ->select(ObjectStaticValues::tableName() . '.object_model_id')
            ->innerJoin(
                '{{%product_category}}',
                '{{%product_category}}.object_model_id = ' . ObjectStaticValues::tableName() . '.object_model_id'
            )->innerJoin(
                Product::tableName() . ' p',
                $joinCondition
            )->where(
                [
                    'category_id' => $category_id,
                ]
            );
    }
    /**
     * Аналогично getValuesForPropertyId
     * Но identity_map не используется
     * @param int $property_id
     * @return array|mixed|\yii\db\ActiveRecord[]
     */
    public static function arrayOfValuesForPropertyId($property_id)
    {
        $cacheKey = "ValuesForProperty:$property_id";

        if (false === $values = Yii::$app->cache->get($cacheKey)) {
            $values = static::find()->where(['property_id' => $property_id])->orderBy(
                [
                    'sort_order' => SORT_ASC,
                    'name' => SORT_ASC
                ]
            )->asArray()->all();
            if (null !== $values) {
                Yii::$app->cache->set(
                    $cacheKey,
                    $values,
                    0,
                    new TagDependency(
                        [
                            'tags' => [
                                ActiveRecordHelper::getCommonTag(PropertyStaticValues::className()),
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}
                                ActiveRecordHelper::getCommonTag(Property::className()),
                            ]

                        ]
                    )
                );
            }
        }
        return $values;
    }

    public function afterSave($insert, $changedAttributes)
    {
        if (null !== $parent = Property::findById($this->property_id)) {
            $parent->invalidateModelCache();
        }
        parent::afterSave($insert, $changedAttributes);
    }

    public function beforeDelete()
    {
        if (null !== $parent = Property::findById($this->property_id)) {
            $parent->invalidateModelCache();
        }
        return parent::beforeDelete();
    }

    public function afterDelete()
    {
        ObjectStaticValues::deleteAll(['property_static_value_id' => $this->id]);
        parent::afterDelete();
    }
}


1		<?php
2
3		namespace app\models;
4
5		use app\modules\shop\models\Product;
6		use app\properties\HasProperties;
7		use app\traits\GetImages;
8		use app\traits\SortModels;
9		use devgroup\TagDependencyHelper\ActiveRecordHelper;
10		use Yii;
11		use yii\behaviors\AttributeBehavior;
12		use yii\caching\TagDependency;
13		use yii\data\ActiveDataProvider;
14		use yii\db\ActiveQuery;
15		use yii\db\ActiveRecord;
16		use yii\db\Expression;
17
18		/**
19		* This is the model class for table "property_static_values".
20		* @property integer $id
21		* @property integer $property_id
22		* @property string $name
23		* @property string $value
24		* @property string $slug
25		* @property integer $sort_order
26		* @property Property $property
27		* @property integer $dont_filter
28		*/
29		class PropertyStaticValues extends ActiveRecord
30		{
31		use GetImages;
32
33		public static $identity_map_by_property_id = [];
34		private static $identity_map = [];
35
36		use SortModels;
37
38		/**
39		* @inheritdoc
40		*/
41		public function behaviors()
42		{
43		return [
44		[
45		'class' => AttributeBehavior::className(),
46		'attributes' => [
47		\yii\db\ActiveRecord::EVENT_BEFORE_INSERT => 'sort_order',
48		],
49		'value' => 0,
50		],
51		[
52		'class' => ActiveRecordHelper::className(),
53		],
54		[
55		'class' => HasProperties::className(),
56		],
57		];
58		}
59
60		/**
61		* @inheritdoc
62		*/
63		public static function tableName()
64		{
65		return '{{%property_static_values}}';
66		}
67
68		/**
69		* @inheritdoc
70		*/
71	View Code Duplication	public function rules()
72		{
73		return [
74		[['property_id', 'name', 'value'], 'required'],
75		[['property_id', 'sort_order', 'dont_filter'], 'integer'],
76		[['title_prepend'], 'boolean'],
77		[['name', 'value', 'slug', 'title_append'], 'string']
78		];
79		}
80
81		/**
82		* @inheritdoc
83		*/
84		public function attributeLabels()
85		{
86		return [
87		'id' => Yii::t('app', 'ID'),
88		'property_id' => Yii::t('app', 'Property ID'),
89		'name' => Yii::t('app', 'Name'),
90		'value' => Yii::t('app', 'Value'),
91		'slug' => Yii::t('app', 'Slug'),
92		'sort_order' => Yii::t('app', 'Sort Order'),
93		'title_append' => Yii::t('app', 'Title append'),
94		'title_prepend' => Yii::t('app', 'Prepend title?'),
95		'dont_filter' => Yii::t('app', 'Don\'t filter (for FilterWidget only)'),
96		];
97		}
98
99		/**
100		* Search tasks
101		* @param $params
102		* @return ActiveDataProvider
103		*/
104	View Code Duplication	public function search($params)
105		{
106		$query = static::find()->where(['property_id' => $this->property_id]);
107		$dataProvider = new ActiveDataProvider(
108		[
109		'query' => $query,
110		'pagination' => [
111		'pageSize' => 10,
112		],
113		]
114		);
115		if (!($this->load($params))) {
116		return $dataProvider;
117		}
118		$query->andFilterWhere(['id' => $this->id]);
119		$query->andFilterWhere(['like', 'name', $this->name]);
120		$query->andFilterWhere(['like', 'value', $this->value]);
121		$query->andFilterWhere(['like', 'slug', $this->slug]);
122		return $dataProvider;
123		}
124
125		public function getProperty()
126		{
127		return $this->hasOne(Property::className(), ['id' => 'property_id']);
128		}
129
130		/**
131		* Возвращает Массив! по ID с использованием IdentityMap
132		* @param int $id
133		* @return null\|PropertyStaticValues
134		*/
135	View Code Duplication	public static function findById($id)
136		{
137		if (!isset(static::$identity_map[$id])) {
138		$cacheKey = "PropertyStaticValue:$id";
139
140		if (false === $property = Yii::$app->cache->get($cacheKey)) {
141		if (null !== $property = static::find()->where(['id' => $id])->asArray()->one()) {
142		Yii::$app->cache->set(
143		$cacheKey,
144		$property,
145		0,
146		new TagDependency(
147		[
148		'tags' => [
149		\devgroup\TagDependencyHelper\ActiveRecordHelper::getObjectTag(
150		static::className(),
151		$id
152		),
153		],
154		]
155		)
156		);
157		}
158		}
159		static::$identity_map[$id] = $property;
160		}
161		return static::$identity_map[$id];
162		}
163
164		/**
165		* Возвращает массив возможных значений свойств по property_id
166		* Внимание! Это массивы, а не объекты!
167		* Это сделано для экономии памяти.
168		* Используется identity_map
169		*
170		* @return array
171		*/
172		public static function getValuesForPropertyId($property_id)
173		{
174		if (!isset(static::$identity_map_by_property_id[$property_id])) {
175		static::$identity_map_by_property_id[$property_id] = static::arrayOfValuesForPropertyId($property_id);
176		foreach (static::$identity_map_by_property_id[$property_id] as $psv) {
177		static::$identity_map[$psv['id']] = $psv;
178		}
179		}
180		return static::$identity_map_by_property_id[$property_id];
181		}
182
183		public static function getSelectForPropertyId($property_id)
184		{
185		$values = PropertyStaticValues::getValuesForPropertyId($property_id);
		0 ignored issues – show Coding Style introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
186		$result = [];
187		foreach ($values as $row) {
188		$result[$row['id']] = $row['name'];
189		}
190		return $result;
191		}
192
193		/**
194		* @param $property_id
195		* @param $category_id
196		* @param $properties
197		* @return PropertyStaticValues[]
198		*/
199		public static function getValuesForFilter($property_id, $category_id, $properties, $multiple = false, $parentsOnly = true)
		0 ignored issues – show Coding Style introduced 2015-12-03 09:17 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 126 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
200		{
201		$priceMin = Yii::$app->request->get('price_min');
202		$priceMax = Yii::$app->request->get('price_max');
203		$cacheKey = "getValuesForFilter:" . json_encode([$property_id, $category_id, $properties, $priceMin, $priceMax]);
		0 ignored issues – show Coding Style introduced 2015-12-03 09:17 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 121 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
204		if (false === $allSelections = Yii::$app->cache->get($cacheKey)) {
205		$joinCondition = (true === $parentsOnly) ?
206		'p.id = {{%product_category}}.object_model_id AND p.active = 1 AND p.parent_id = 0'
207		: 'p.id = {{%product_category}}.object_model_id AND p.active = 1';
208		$objectModel = Object::getForClass(Product::className());
209		$objectId = $objectModel !== null ? $objectModel->id : 0;
210		$allSelections = static::find()
211		->asArray(true)
212		->select([self::tableName() . '.id', self::tableName() . '.name', 'value', self::tableName() . '.slug'])
213		->innerJoin(
214		ObjectStaticValues::tableName(),
215		ObjectStaticValues::tableName() . '.property_static_value_id=' . self::tableName() . '.id'
216		)
217		->innerJoin(
218		'{{%product_category}}',
219		'{{%product_category}}.object_model_id = ' . ObjectStaticValues::tableName() . '.object_model_id'
220		)
221		->innerJoin(
222		Product::tableName() . ' p',
223		$joinCondition
224		)
225		->where(
226		[
227		self::tableName() . '.property_id' => $property_id,
228		self::tableName() . '.dont_filter' => 0,
229		'{{%product_category}}.category_id' => $category_id,
230		]
231		)
232		->orderBy(
233		[
234		self::tableName() . '.sort_order' => SORT_ASC,
235		self::tableName() . '.name' => SORT_ASC,
236		]
237		)
238		->all();
239		/** @var ActiveQuery $query */
240		$query = ObjectStaticValues::find()
241		->distinct(true)
242		->select(ObjectStaticValues::tableName() . '.object_model_id')
243		->where(['object_id' => $objectId]);
244		if (false === empty($properties)) {
245		foreach ($properties as $propertyId => $propertyStaticValues) {
246		$subQuery = self::initSubQuery($category_id, $joinCondition);
247		$subQuery->andWhere(['property_static_value_id' => $propertyStaticValues,]);
248	View Code Duplication	$subQueryOptimisation = Yii::$app->db->cache(function($db) use ($subQuery) {
249		$ids = implode(', ', $subQuery->createCommand($db)->queryColumn());
250		return empty($ids) === true ? '(-1)' : "($ids)";
251		}, 86400, new TagDependency([
252		'tags' => [
253		ActiveRecordHelper::getCommonTag(ObjectStaticValues::className()),
254		]
255		]));
256		$query->andWhere(new Expression('`object_model_id` IN ' . $subQueryOptimisation));
257		}
258		}
259		if (false === empty($priceMin) && false === empty($priceMax)) {
260		$subQuery = self::initSubQuery($category_id, $joinCondition);
261		$subQuery
262		->andWhere(['>=', 'p.price', $priceMin])
263		->andWhere(['<=', 'p.price', $priceMax]);
264	View Code Duplication	$subQueryOptimisation = Yii::$app->db->cache(function($db) use ($subQuery) {
265		$ids = implode(', ', $subQuery->createCommand($db)->queryColumn());
266		return empty($ids) === true ? '(-1)' : "($ids)";
267		}, 86400, new TagDependency([
268		'tags' => [
269		ActiveRecordHelper::getCommonTag(ObjectStaticValues::className()),
270		]
271		]));
272		$query->andWhere(new Expression('`object_model_id` IN ' . $subQueryOptimisation));
273		}
274		$selectedQuery = static::find()
275		->select(static::tableName() . '.id')
276		->asArray(true)
277		->innerJoin(
278		ObjectStaticValues::tableName(),
279		ObjectStaticValues::tableName() . '.property_static_value_id = ' . static::tableName() . '.id'
280		)
281		->where([
282		'property_id' => $property_id,
283		])
284		->andWhere(
285		new Expression(
286		ObjectStaticValues::tableName() . '.object_model_id IN (' . $query->createCommand()->getRawSql() . ')'
		0 ignored issues – show Coding Style introduced 2015-12-03 09:17 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 126 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
287		)
288		);
289		if (false == $multiple) {
		0 ignored issues – show Coding Style Best Practice introduced 2015-12-03 09:17 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
290		if (isset($properties[$property_id])) {
291		$selectedQuery->andWhere([self::tableName() . '.id' => $properties[$property_id]]);
292		}
293		} else {
294		unset($properties[$property_id]);
295		}
296		$selected = $selectedQuery->column();
297		foreach ($allSelections as $index => $selection) {
298		$allSelections[$index]['active'] = in_array($selection['id'], $selected);
299		}
300	View Code Duplication	if (null !== $allSelections) {
301		Yii::$app->cache->set(
302		$cacheKey,
303		$allSelections,
304		0,
305		new TagDependency(
306		[
307		'tags' => [
308		ActiveRecordHelper::getCommonTag(PropertyStaticValues::className()),
		0 ignored issues – show Coding Style introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
309		ActiveRecordHelper::getCommonTag(Property::className()),
310		]
311
312		]
313		)
314		);
315		}
316		}
317		return $allSelections;
318		}
319
320		private static function initSubQuery($category_id, $joinCondition)
321		{
322		$subQuery = ObjectStaticValues::find();
323		return $subQuery
324		->select(ObjectStaticValues::tableName() . '.object_model_id')
325		->innerJoin(
326		'{{%product_category}}',
327		'{{%product_category}}.object_model_id = ' . ObjectStaticValues::tableName() . '.object_model_id'
328		)->innerJoin(
329		Product::tableName() . ' p',
330		$joinCondition
331		)->where(
332		[
333		'category_id' => $category_id,
334		]
335		);
336		}
337		/**
338		* Аналогично getValuesForPropertyId
339		* Но identity_map не используется
340		* @param int $property_id
341		* @return array\|mixed\|\yii\db\ActiveRecord[]
342		*/
343		public static function arrayOfValuesForPropertyId($property_id)
344		{
345		$cacheKey = "ValuesForProperty:$property_id";
346
347		if (false === $values = Yii::$app->cache->get($cacheKey)) {
348		$values = static::find()->where(['property_id' => $property_id])->orderBy(
349		[
350		'sort_order' => SORT_ASC,
351		'name' => SORT_ASC
352		]
353		)->asArray()->all();
354	View Code Duplication	if (null !== $values) {
355		Yii::$app->cache->set(
356		$cacheKey,
357		$values,
358		0,
359		new TagDependency(
360		[
361		'tags' => [
362		ActiveRecordHelper::getCommonTag(PropertyStaticValues::className()),
		0 ignored issues – show Coding Style introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
363		ActiveRecordHelper::getCommonTag(Property::className()),
364		]
365
366		]
367		)
368		);
369		}
370		}
371		return $values;
372		}
373
374		public function afterSave($insert, $changedAttributes)
375		{
376		if (null !== $parent = Property::findById($this->property_id)) {
377		$parent->invalidateModelCache();
378		}
379		parent::afterSave($insert, $changedAttributes);
380		}
381
382		public function beforeDelete()
383		{
384		if (null !== $parent = Property::findById($this->property_id)) {
385		$parent->invalidateModelCache();
386		}
387		return parent::beforeDelete();
388		}
389
390		public function afterDelete()
391		{
392		ObjectStaticValues::deleteAll(['property_static_value_id' => $this->id]);
393		parent::afterDelete();
394		}
395		}
396

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — master ( e91cf6...3a6b3f )

PropertyStaticValues B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like