PageModule::attachEventsHandlers() - Code Metrics - Inspection of "add "create child page" button to admin-bar" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0d3847...631d1f )

by Alexander

created 2016-12-25 08:31 UTC

PageModule::attachEventsHandlers() B

↳ Parent: PageModule

Complexity

Conditions	4
Paths	1

Size

Total Lines	31
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	31
rs	8.5806
cc	4
eloc	20
nc	1
nop	0

<?php

namespace app\modules\page;

use app;
use app\modules\event\interfaces\EventInterface;
use app\modules\floatPanel\widgets\FloatingPanel;
use kartik\icons\Icon;
use Yii;
use yii\base\Event;

/**
 * Base configuration module for DotPlant2 CMS
 * @package app\modules\page
 */
class PageModule extends app\components\BaseModule implements EventInterface
{
    const BACKEND_PAGE_GRID = 'pageGrid';
    /**
     * @var int minimum pages per list to show
     */
    public $minPagesPerList = 1;

    /**
     * @var int maximum pages per list to show
     */
    public $maxPagesPerList = 50;

    /**
     * @var int pages per list to show
     */
    public $pagesPerList = 10;

    /**
     * @var int How much pages to show on search results page
     */
    public $searchResultsLimit = 10;

    public $controllerMap = [
        'backend' => 'app\modules\page\backend\PageController',
    ];

    /**
     * @inheritdoc
     */
    public function behaviors()
    {
        return [
            'configurableModule' => [
                'class' => 'app\modules\config\behaviors\ConfigurableModuleBehavior',
                'configurationView' => '@app/modules/page/views/configurable/_config',
                'configurableModel' => 'app\modules\page\models\ConfigConfigurationModel',
            ]
        ];
    }

    /** @inheritdoc */
    public function getBackendGrids()
    {
        return [
            [
                'defaultValue' => app\backend\BackendModule::BACKEND_GRID_ONE_TO_ONE,
                'key' => self::BACKEND_PAGE_GRID,
                'label' => Yii::t('app', 'Page edit'),
            ],
        ];
    }

    /**
     * @return void
     */
    public static function attachEventsHandlers()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        Event::on(
            FloatingPanel::class,
            FloatingPanel::EVENT_BEFORE_RENDER,
            function($event) {
                if (in_array(\Yii::$app->requestedRoute, ['/page/page/show', '/page/page/list'])) {
                    if (isset($_GET['id'])) {
                        $page = app\modules\page\models\Page::findById($_GET['id']);
                        $event->items[] = [
                            'label' => Icon::show('pencil') . ' ' . Yii::t('app', 'Edit page'),
                            'url' => [
                                '/page/backend/edit',
                                'id' => $page->id,
                                'parent_id' =>$page->parent_id,
                            ],
                        ];
                        if (Yii::$app->requestedRoute == "/page/page/list") {
                            $event->items[] = [
                                'label' => Icon::show('plus') .  Yii::t('app', 'Add child page'),
                                'url' => [
                                    '/page/backend/edit',
                                    'parent_id' => $page->id
                                ]
                            ];
                        }
                    }
                }
            }
        );
    }
}


1			<?php
2
3			namespace app\modules\page;
4
5			use app;
6			use app\modules\event\interfaces\EventInterface;
7			use app\modules\floatPanel\widgets\FloatingPanel;
8			use kartik\icons\Icon;
9			use Yii;
10			use yii\base\Event;
11
12			/**
13			* Base configuration module for DotPlant2 CMS
14			* @package app\modules\page
15			*/
16			class PageModule extends app\components\BaseModule implements EventInterface
17			{
18			const BACKEND_PAGE_GRID = 'pageGrid';
19			/**
20			* @var int minimum pages per list to show
21			*/
22			public $minPagesPerList = 1;
23
24			/**
25			* @var int maximum pages per list to show
26			*/
27			public $maxPagesPerList = 50;
28
29			/**
30			* @var int pages per list to show
31			*/
32			public $pagesPerList = 10;
33
34			/**
35			* @var int How much pages to show on search results page
36			*/
37			public $searchResultsLimit = 10;
38
39			public $controllerMap = [
40			'backend' => 'app\modules\page\backend\PageController',
41			];
42
43			/**
44			* @inheritdoc
45			*/
46			public function behaviors()
47			{
48			return [
49			'configurableModule' => [
50			'class' => 'app\modules\config\behaviors\ConfigurableModuleBehavior',
51			'configurationView' => '@app/modules/page/views/configurable/_config',
52			'configurableModel' => 'app\modules\page\models\ConfigConfigurationModel',
53			]
54			];
55			}
56
57			/** @inheritdoc */
58			public function getBackendGrids()
59			{
60			return [
61			[
62			'defaultValue' => app\backend\BackendModule::BACKEND_GRID_ONE_TO_ONE,
63			'key' => self::BACKEND_PAGE_GRID,
64			'label' => Yii::t('app', 'Page edit'),
65			],
66			];
67			}
68
69			/**
70			* @return void
71			*/
72			public static function attachEventsHandlers()
			0 ignored issues – show Coding Style introduced 2016-05-29 11:01 UTC by Report Bug Copy Issue Report `attachEventsHandlers` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
73			{
74			Event::on(
75			FloatingPanel::class,
76			FloatingPanel::EVENT_BEFORE_RENDER,
77			function($event) {
78			if (in_array(\Yii::$app->requestedRoute, ['/page/page/show', '/page/page/list'])) {
79			if (isset($_GET['id'])) {
80			$page = app\modules\page\models\Page::findById($_GET['id']);
81			$event->items[] = [
82			'label' => Icon::show('pencil') . ' ' . Yii::t('app', 'Edit page'),
83			'url' => [
84			'/page/backend/edit',
85			'id' => $page->id,
86			'parent_id' =>$page->parent_id,
87			],
88			];
89			if (Yii::$app->requestedRoute == "/page/page/list") {
90			$event->items[] = [
91			'label' => Icon::show('plus') . Yii::t('app', 'Add child page'),
92			'url' => [
93			'/page/backend/edit',
94			'parent_id' => $page->id
95			]
96			];
97			}
98			}
99			}
100			}
101			);
102			}
103			}
104

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — master ( 0d3847...631d1f )

PageModule::attachEventsHandlers() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like