app\modules\shop\models\ShippingDiscount

Complexity

Total Complexity

10

Size/Duplication

Total Lines	74
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	4
Bugs	3	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getShippingOption()	4	4	1
A	getFullName()	4	4	2
A	checkDiscount()	20	20	4
A	tableName()	4	4	1
A	rules()	7	7	1
A	attributeLabels()	8	8	1

<?php

namespace app\modules\shop\models;

use Yii;

/**
 * This is the model class for table "shipping_discount".
 *
 * @property integer $id
 * @property integer $shipping_option_id
 * @property integer $discount_id
 * @property shippingOption $shippingOption
 */
class ShippingDiscount extends \app\modules\shop\models\AbstractDiscountType
{
    /**
     * getShippingOption
     * @return ShippingOption

Should the return type not be \yii\db\ActiveQuery?

     */
    public function getShippingOption()
    {
        return $this->hasOne(ShippingOption::className(), ['id' => 'shipping_option_id']);
    }

    /**
     * @inheritdoc
     */
    public function getFullName() {
        $model = $this->shippingOption;
        return null === $model ? '(none)' : $model->name;
    }

    /**
     * @inheritdoc
     */
    public function checkDiscount(Discount $discount, Product $product = null, Order $order = null)
    {
        $odi = $order->orderDeliveryInformation;
        if (null === $order || null === $odi) {
            return false;
        }

        $q = self::find()->where(
            [
                'discount_id' => $discount->id,
                'shipping_option_id' => $odi->shipping_option_id
            ]
        )->count();

        if (0 === intval($q)) {

This if statement, and the following return statement can be replaced with return !(0 === intval($q));.

            return false;
        }

        return true;
    }

    /**
     * @inheritdoc
     */
    public static function tableName()
    {
        return 'shipping_discount';
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            [['shipping_option_id', 'discount_id'], 'required'],
            [['shipping_option_id', 'discount_id'], 'integer'],
        ];
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'id' => Yii::t('app', 'ID'),
            'shipping_option_id' => Yii::t('app', 'Shipping Option ID'),
            'discount_id' => Yii::t('app', 'Discount ID'),
        ];
    }
}