app\modules\core\behaviors\SetCanonicalBehavior::setCanonical()

Complexity

Conditions	7
Paths	20

Size

Total Lines	30
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function setCanonical()
    {
        $request = Yii::$app->request;
        $setCanonical = false;
        $queryParams = !empty($request->queryParams) ? $request->queryParams : [];
        $this->_canonical = $request->absoluteUrl;

        foreach ($this->labels as $label) {
            foreach ($queryParams as $key => $value) {
                if ($key == $label) {
                    if (false == empty($value)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

                        $rm = $key .'='. $value;
                    } else {
                        $rm = $key;
                    }
                    $this->_canonical = str_replace(['?'.$rm.'&', '?'.$rm, '&'.$rm], ['?','',''], $this->_canonical);
                    $setCanonical = true;
                }
            }
        }

        if ($setCanonical) {
            $this->owner->view->registerLinkTag(
                [
                    'rel' => 'canonical',
                    'href' => $this->_canonical
                ]
            );
        }
    }
}