AdminController::actionThumbnails() - Code Metrics - Inspection of "Merge branch 'master' into filters-dev" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — filters-dev ( b32603 )

unknown

created 2016-03-03 10:51 UTC

AdminController::actionThumbnails() B

↳ Parent: AdminController

Complexity

Conditions	5
Paths	5

Size

Total Lines	28
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	28
rs	8.439
cc	5
eloc	20
nc	5
nop	2

<?php

namespace app\commands;

use Imagine\Image\ManipulatorInterface;
use app\backend\actions\FlushCacheConsoleAction;
use Yii;
use yii\console\Controller;
use app;
use app\modules\image\models\Image;

/**
 * Admin commands
 * @package app\commands
 */
class AdminController extends Controller
{

    public function actions()
    {
        return [
            'flush-cache' => [
                'class' => FlushCacheConsoleAction::className(),
            ],
        ];
    }

    /**
     * Generate thumbnails for Image model
     * @param bool $updateThumbnailSrc
     * @param bool $deleteIfNotExists
     * @throws \Exception
     */
    public function actionThumbnails($updateThumbnailSrc = false, $deleteIfNotExists = false)
    {
        $images = Image::find()->all();
        /** @var $images Image[] */
        foreach ($images as $image) {
            $dir = '@webroot' . mb_substr($image->filename, 0, mb_strrpos($image->filename, '/')) . '/';
            $filename = \Yii::getAlias($dir . $image->filename);
            if (!file_exists($filename)) {
                echo "File not found: " . $filename . "\n";
                if ($deleteIfNotExists) {
                    $image->delete();
                }
                continue;
            }
            $img = \yii\imagine\Image::thumbnail(
                $filename,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                80,
                80,
                ManipulatorInterface::THUMBNAIL_INSET
            );
            $img->save(\Yii::getAlias($dir . 'small-' . $image->filename));

            if ($updateThumbnailSrc) {
                $image->thumbnail_src = mb_substr($image->filename, 0, mb_strrpos($image->filename, '/'))
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    . '/small-' . $image->filename;
                $image->save(true, ['thumbnail_src']);
            }
        }
    }

    /**
     * Clear test review, orders and other information
     * @throws \yii\db\Exception
     */
    public function actionClearTests()
    {
        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\models\ErrorLog::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\models\ErrorUrl::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\backend\models\Notification::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\modules\shop\models\Order::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\modules\shop\models\OrderItem::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\modules\shop\models\OrderTransaction::tableName())->execute();

        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\backend\models\OrderChat::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE {{%order_category}}')->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE {{%order_eav}}')->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE {{%order_property}}')->execute();
//        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\reviews\models\Review::tableName())->execute(); @todo need to implement correct reviews deleting

        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\models\Submission::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE {{%submission_category}}')->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE {{%submission_eav}}')->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE {{%submission_property}}')->execute();
        Yii::$app->db->createCommand('DELETE FROM ' . app\models\ObjectPropertyGroup::tableName()
            . ' WHERE `object_id` IN (SELECT `id` FROM ' . app\models\Object::tableName()
            . ' WHERE `object_class` IN (\'app\\models\\Submission\', \'app\\models\\Order\'))')->execute();
        Yii::$app->db->createCommand('DELETE FROM ' . app\models\ObjectStaticValues::tableName()
            . ' WHERE `object_id` IN (SELECT `id` FROM ' . app\models\Object::tableName()
            . ' WHERE `object_class` IN (\'app\\models\\Submission\', \'app\\models\\Order\'))')->execute();
    }

    public function actionTestMail($email)
    {

        $mailComponent = Yii::$app->mail;

        $status = $mailComponent->compose('test')
            ->setFrom(Yii::$app->getModule('core')->emailConfig['mailFrom'])
            ->setTo($email)
            ->setSubject(
                Yii::t(
                    'app', 'subject test mail on {site}',
                    [
                        'site' => 'Site'
                    ]
                )
            )->send();
        echo $status ? "OK\n" : "NOT OK\n";
    }


    protected function createStructure($path, $children, $themeName)
    {
        foreach ($children as $child) {
            $newPath = $path . DIRECTORY_SEPARATOR . $child['name'];
            if (isset($child['type']) && $child['type'] == 'dir') {
                mkdir($newPath);
                chmod($newPath, isset($child['writable']) && $child['writable'] ? 0777 : 0775);
                if (isset($child['children']) && !empty($child['children'])) {
                    $this->createStructure($newPath, $child['children'], $themeName);
                } else {
                    file_put_contents($newPath . DIRECTORY_SEPARATOR . '.keep', '');
                }
            } else {
                file_put_contents($newPath,
                    isset($child['content']) ? str_replace('{%theme-name%}', $themeName, $child['content']) : '');
            }
        }
    }

    /**
     * Create theme structure
     * @param string $name
     * @throws \yii\base\ExitException
     */
    public function actionCreateTheme($name = 'theme')
    {
        $name = trim($name);
        if (preg_match('#^[a-z]+$#i', $name) == 0) {
            echo "Bad theme name" . PHP_EOL;
            Yii::$app->end();
        }
        $themeRoot = Yii::getAlias('@webroot/' . $name);
        if (file_exists($themeRoot)) {
            echo "Directory \"{$themeRoot}\" already exists: " . PHP_EOL;
            Yii::$app->end();
        }
        $structure = include __DIR__ . DIRECTORY_SEPARATOR . 'data' . DIRECTORY_SEPARATOR . 'theme-structure.php';
        mkdir($themeRoot);
        $this->createStructure($themeRoot, $structure, $name);
        echo "Theme \"{$name}\" has been created" . PHP_EOL;
        if (exec("which npm")) {
            echo "Installing node.js dependencies" . PHP_EOL;
            exec("cd $themeRoot ; npm install");
        }
    }
}

1			<?php
2
3			namespace app\commands;
4
5			use Imagine\Image\ManipulatorInterface;
6			use app\backend\actions\FlushCacheConsoleAction;
7			use Yii;
8			use yii\console\Controller;
9			use app;
10			use app\modules\image\models\Image;
11
12			/**
13			* Admin commands
14			* @package app\commands
15			*/
16			class AdminController extends Controller
17			{
18
19			public function actions()
20			{
21			return [
22			'flush-cache' => [
23			'class' => FlushCacheConsoleAction::className(),
24			],
25			];
26			}
27
28			/**
29			* Generate thumbnails for Image model
30			* @param bool $updateThumbnailSrc
31			* @param bool $deleteIfNotExists
32			* @throws \Exception
33			*/
34			public function actionThumbnails($updateThumbnailSrc = false, $deleteIfNotExists = false)
35			{
36			$images = Image::find()->all();
37			/** @var $images Image[] */
38			foreach ($images as $image) {
39			$dir = '@webroot' . mb_substr($image->filename, 0, mb_strrpos($image->filename, '/')) . '/';
40			$filename = \Yii::getAlias($dir . $image->filename);
41			if (!file_exists($filename)) {
42			echo "File not found: " . $filename . "\n";
43			if ($deleteIfNotExists) {
44			$image->delete();
45			}
46			continue;
47			}
48			$img = \yii\imagine\Image::thumbnail(
49			$filename,
			0 ignored issues – show Bug introduced 2016-02-05 12:50 UTC by Report Bug Copy Issue Report It seems like `$filename` defined by `\Yii::getAlias($dir . $image->filename)` on line `40` can also be of type `boolean`; however, `yii\imagine\BaseImage::thumbnail()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
50			80,
51			80,
52			ManipulatorInterface::THUMBNAIL_INSET
53			);
54			$img->save(\Yii::getAlias($dir . 'small-' . $image->filename));
			0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report It seems like `\Yii::getAlias($dir . 's...l-' . $image->filename)` targeting `yii\BaseYii::getAlias()` can also be of type `boolean`; however, `Imagine\Image\ManipulatorInterface::save()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
55			if ($updateThumbnailSrc) {
56			$image->thumbnail_src = mb_substr($image->filename, 0, mb_strrpos($image->filename, '/'))
			0 ignored issues – show Documentation introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The property `thumbnail_src` does not exist on `object<app\modules\image\models\Image>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
57			. '/small-' . $image->filename;
58			$image->save(true, ['thumbnail_src']);
59			}
60			}
61			}
62
63			/**
64			* Clear test review, orders and other information
65			* @throws \yii\db\Exception
66			*/
67			public function actionClearTests()
68			{
69			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\models\ErrorLog::tableName())->execute();
70			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\models\ErrorUrl::tableName())->execute();
71			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\backend\models\Notification::tableName())->execute();
72			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\modules\shop\models\Order::tableName())->execute();
73			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\modules\shop\models\OrderItem::tableName())->execute();
74			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\modules\shop\models\OrderTransaction::tableName())->execute();
			0 ignored issues – show Coding Style introduced 2016-02-05 12:50 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 123 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
75			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\backend\models\OrderChat::tableName())->execute();
76			Yii::$app->db->createCommand('TRUNCATE TABLE {{%order_category}}')->execute();
77			Yii::$app->db->createCommand('TRUNCATE TABLE {{%order_eav}}')->execute();
78			Yii::$app->db->createCommand('TRUNCATE TABLE {{%order_property}}')->execute();
79			// Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\reviews\models\Review::tableName())->execute(); @todo need to implement correct reviews deleting
			0 ignored issues – show Coding Style Best Practice introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history... Unused Code Comprehensibility introduced 2016-02-05 12:50 UTC by Report Bug Copy Issue Report `37%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history... Coding Style introduced 2016-02-05 12:50 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 159 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
80			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\models\Submission::tableName())->execute();
81			Yii::$app->db->createCommand('TRUNCATE TABLE {{%submission_category}}')->execute();
82			Yii::$app->db->createCommand('TRUNCATE TABLE {{%submission_eav}}')->execute();
83			Yii::$app->db->createCommand('TRUNCATE TABLE {{%submission_property}}')->execute();
84			Yii::$app->db->createCommand('DELETE FROM ' . app\models\ObjectPropertyGroup::tableName()
85			. ' WHERE `object_id` IN (SELECT `id` FROM ' . app\models\Object::tableName()
86			. ' WHERE `object_class` IN (\'app\\models\\Submission\', \'app\\models\\Order\'))')->execute();
87			Yii::$app->db->createCommand('DELETE FROM ' . app\models\ObjectStaticValues::tableName()
88			. ' WHERE `object_id` IN (SELECT `id` FROM ' . app\models\Object::tableName()
89			. ' WHERE `object_class` IN (\'app\\models\\Submission\', \'app\\models\\Order\'))')->execute();
90			}
91
92			public function actionTestMail($email)
93			{
94
95			$mailComponent = Yii::$app->mail;
96
97			$status = $mailComponent->compose('test')
98			->setFrom(Yii::$app->getModule('core')->emailConfig['mailFrom'])
99			->setTo($email)
100			->setSubject(
101			Yii::t(
102			'app', 'subject test mail on {site}',
103			[
104			'site' => 'Site'
105			]
106			)
107			)->send();
108			echo $status ? "OK\n" : "NOT OK\n";
109			}
110
111
112			protected function createStructure($path, $children, $themeName)
113			{
114			foreach ($children as $child) {
115			$newPath = $path . DIRECTORY_SEPARATOR . $child['name'];
116			if (isset($child['type']) && $child['type'] == 'dir') {
117			mkdir($newPath);
118			chmod($newPath, isset($child['writable']) && $child['writable'] ? 0777 : 0775);
119			if (isset($child['children']) && !empty($child['children'])) {
120			$this->createStructure($newPath, $child['children'], $themeName);
121			} else {
122			file_put_contents($newPath . DIRECTORY_SEPARATOR . '.keep', '');
123			}
124			} else {
125			file_put_contents($newPath,
126			isset($child['content']) ? str_replace('{%theme-name%}', $themeName, $child['content']) : '');
127			}
128			}
129			}
130
131			/**
132			* Create theme structure
133			* @param string $name
134			* @throws \yii\base\ExitException
135			*/
136			public function actionCreateTheme($name = 'theme')
137			{
138			$name = trim($name);
139			if (preg_match('#^[a-z]+$#i', $name) == 0) {
140			echo "Bad theme name" . PHP_EOL;
141			Yii::$app->end();
142			}
143			$themeRoot = Yii::getAlias('@webroot/' . $name);
144			if (file_exists($themeRoot)) {
145			echo "Directory \"{$themeRoot}\" already exists: " . PHP_EOL;
146			Yii::$app->end();
147			}
148			$structure = include __DIR__ . DIRECTORY_SEPARATOR . 'data' . DIRECTORY_SEPARATOR . 'theme-structure.php';
149			mkdir($themeRoot);
150			$this->createStructure($themeRoot, $structure, $name);
151			echo "Theme \"{$name}\" has been created" . PHP_EOL;
152			if (exec("which npm")) {
153			echo "Installing node.js dependencies" . PHP_EOL;
154			exec("cd $themeRoot ; npm install");
155			}
156			}
157			}

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — filters-dev ( b32603 )

AdminController::actionThumbnails() B

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like