SliderController::actionUpdate() - Code Metrics - Inspection of "Merge branch 'master' into filters-dev" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — filters-dev ( b32603 )

unknown

created 2016-03-03 10:51 UTC

SliderController::actionUpdate() C

↳ Parent: SliderController

Complexity

Conditions	10
Paths	40

Size

Total Lines	54
Code Lines	35

Duplication

Lines	21
Ratio	38.89 %

Metric	Value
dl	21
loc	54
rs	6.8372
cc	10
eloc	35
nc	40
nop	1

How to fix Long Method Complexity

<?php

namespace app\backend\controllers;

use app\backend\traits\BackendRedirect;
use app\models\Slide;
use app\slider\BaseSliderEditModel;
use Imagine\Image\ManipulatorInterface;
use kartik\icons\Icon;
use Yii;
use app\models\Slider;
use app\components\SearchModel;
use yii\filters\AccessControl;
use yii\web\BadRequestHttpException;
use yii\web\Controller;
use yii\web\HttpException;
use yii\web\NotFoundHttpException;
use yii\web\Response;
use yii\web\UploadedFile;

/**
 * SliderController implements the CRUD actions for Slider model.
 */
class SliderController extends Controller
{
    use BackendRedirect;
    /**
     * @inheritdoc
     */
    public function behaviors()
    {
        return [
            'access' => [
                'class' => AccessControl::className(),
                'rules' => [
                    [
                        'allow' => true,
                        'roles' => ['content manage'],
                    ],
                ],
            ],
        ];
    }


    /**
     * Lists all Slider models.
     * @return mixed

     */
    public function actionIndex()
    {
        $searchModel = new SearchModel(
            [
                'model' => Slider::className(),
                'partialMatchAttributes' => ['name'],
                'scenario' => 'default',
            ]
        );
        $dataProvider = $searchModel->search(Yii::$app->request->queryParams);
        return $this->render(
            'index',
            [
                'searchModel' => $searchModel,
                'dataProvider' => $dataProvider,
            ]
        );
    }

    /**
     * Updates an existing Slider model.
     * If update is successful, the browser will be redirected to the 'view' page.
     * @param null|string $id
     * @return mixed

     */
    public function actionUpdate($id = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $abstractModel = new BaseSliderEditModel();

        if (is_null($id)) {
            $model = new Slider;
            $model->loadDefaultValues();
        } else {
            $model = $this->findModel($id);
            if ($model->handler() !== null) {
                $abstractModel = Yii::createObject(['class'=>$model->handler()->edit_model]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                if (!empty($model->params)) {
                    $abstractModel->unserialize($model->params);
                }
            }
        }

        $post = Yii::$app->request->post();

        if ($model->load($post) && $model->validate()) {
            if ($model->handler() !== null) {
                $abstractModel = Yii::createObject(['class'=>$model->handler()->edit_model]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                if (!empty($model->params)) {
                    $abstractModel->unserialize($model->params);
                }
            }
            $abstractModel->load($post);
            if ($abstractModel->validate()) {
                $model->params = $abstractModel->serialize();
                if ($model->save()) {
                    return $this->redirectUser($model->id, true, 'index', 'update');

                } else {
                    Yii::$app->session->setFlash('error', Yii::t('app', 'Cannot save data'));
                }
            } else {
                Yii::$app->session->setFlash('error', Yii::t('app', 'Cannot save data'));
            }
        }

        $searchModel = new Slide();
        $searchModel->slider_id = $model->id;
        $dataProvider = $searchModel->search($_GET);

        return $this->render(
            'update',
            [
                'model' => $model,
                'abstractModel' => $abstractModel,
                'dataProvider' => $dataProvider,
                'searchModel' => $searchModel,
            ]
        );
    }

    /**
     * @param integer $slider_id
     */
    public function actionNewSlide($slider_id)
    {
        Yii::$app->response->format = Response::FORMAT_JSON;
        $slider = $this->findModel($slider_id);
        $model = new Slide();
        $model->slider_id = $slider->id;
        $model->active = 0;

        $model->sort_order = count($slider->getSlides());
        $model->save();
        return $this->redirect(['update', 'id' => $slider_id]);
    }

    /**
     * Update slide attributes
     * @return array
     * @throws \yii\web\BadRequestHttpException
     */
    public function actionUpdateSlide()
    {
        Yii::$app->response->format = Response::FORMAT_JSON;
        $post = Yii::$app->request->post();

        if (!isset($post['editableIndex'], $post['editableKey'])) {
            throw new BadRequestHttpException;
        }
        $id = $post['editableKey'];
        /** @var Slide $model */
        $model = Slide::findOne($id);
        if ($model === null) {
            throw new BadRequestHttpException;
        }
        $index = $post['editableIndex'];
        if (!is_array($post['Slide'][$index])) {
            throw new BadRequestHttpException;
        }
        if (count($post['Slide'][$index])===0) {
            throw new BadRequestHttpException;
        }

        $modifiedAttribute = array_keys($post['Slide'][$index])[0];

        $model->setAttributes($post['Slide'][$index]);


        if (!$model->save()) {
            return [
                'message' => Yii::t('app', 'Cannot save object'),
            ];
        }

        if ($modifiedAttribute === 'active') {
            $model->active ? Icon::show('check txt-color-green') : Icon::show('times txt-color-red');

        }

        return [
            'output' => $model->getAttribute($modifiedAttribute),
        ];
    }

    public function actionDeleteSlide($id)
    {
        $slide = Slide::findOne($id);
        $slider_id = $slide->slider_id;
        $slide->delete();

        return $this->redirect(['update', 'id'=>$slider_id]);
    }

    public function actionUploadSlide()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!isset($_POST['slide_id'], $_POST['attribute'], $_POST['slider_id'])) {
            throw new BadRequestHttpException();
        }

        $model = Slider::findById($_POST['slider_id']);
        $slide = Slide::findOne($_POST['slide_id']);
        if ($model === null || $slide === null) {
            throw new NotFoundHttpException;
        }

        $file = UploadedFile::getInstanceByName('file');
        if ($file === null) {
            throw new HttpException(500, "Upload file error");
        }
        if ($file->hasError) {
            throw new HttpException(500, 'Upload error');
        }

        $fileName = $file->name;
        $uploadDir = Yii::getAlias(Yii::$app->getModule('core')->fileUploadPath);
        $fn = $uploadDir . $fileName;
        if (file_exists($fn)) {
            $fileName = $file->baseName . '-' . uniqid() . '.' . $file->extension;
            $fn = $uploadDir . $fileName;
        }


        $file->saveAs($fn);

        $image = \yii\imagine\Image::thumbnail($uploadDir . $fileName,
            $model->image_width,
            $model->image_height,
            ManipulatorInterface::THUMBNAIL_INSET
        );
        $image->save($uploadDir . 'small-' . $fileName, ['quality'=>95]);

        $slide->setAttribute($_POST['attribute'], str_replace(Yii::getAlias('@webroot'), '', $uploadDir) . 'small-' . $fileName);

        $slide->save();


        return $this->redirect(['update', 'id' => $model->id]);
    }

    /**
     * Deletes an existing Slider model.
     * If deletion is successful, the browser will be redirected to the 'index' page.
     * @param string $id
     * @return mixed

     */
    public function actionDelete($id)
    {
        $this->findModel($id)->delete();

        return $this->redirect(['index']);
    }

    /**
     * Finds the Slider model based on its primary key value.
     * If the model is not found, a 404 HTTP exception will be thrown.
     * @param string $id
     * @return Slider the loaded model
     * @throws NotFoundHttpException if the model cannot be found
     */
    protected function findModel($id)
    {
        if (($model = Slider::findById($id)) !== null) {
            return $model;
        } else {
            throw new NotFoundHttpException('The requested page does not exist.');
        }
    }
}

1		<?php
2
3		namespace app\backend\controllers;
4
5		use app\backend\traits\BackendRedirect;
6		use app\models\Slide;
7		use app\slider\BaseSliderEditModel;
8		use Imagine\Image\ManipulatorInterface;
9		use kartik\icons\Icon;
10		use Yii;
11		use app\models\Slider;
12		use app\components\SearchModel;
13		use yii\filters\AccessControl;
14		use yii\web\BadRequestHttpException;
15		use yii\web\Controller;
16		use yii\web\HttpException;
17		use yii\web\NotFoundHttpException;
18		use yii\web\Response;
19		use yii\web\UploadedFile;
20
21		/**
22		* SliderController implements the CRUD actions for Slider model.
23		*/
24		class SliderController extends Controller
25		{
26		use BackendRedirect;
27		/**
28		* @inheritdoc
29		*/
30	View Code Duplication	public function behaviors()
31		{
32		return [
33		'access' => [
34		'class' => AccessControl::className(),
35		'rules' => [
36		[
37		'allow' => true,
38		'roles' => ['content manage'],
39		],
40		],
41		],
42		];
43		}
44
45
46		/**
47		* Lists all Slider models.
48		* @return mixed
		0 ignored issues – show Documentation introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `string`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
49		*/
50		public function actionIndex()
51		{
52		$searchModel = new SearchModel(
53		[
54		'model' => Slider::className(),
55		'partialMatchAttributes' => ['name'],
56		'scenario' => 'default',
57		]
58		);
59		$dataProvider = $searchModel->search(Yii::$app->request->queryParams);
60		return $this->render(
61		'index',
62		[
63		'searchModel' => $searchModel,
64		'dataProvider' => $dataProvider,
65		]
66		);
67		}
68
69		/**
70		* Updates an existing Slider model.
71		* If update is successful, the browser will be redirected to the 'view' page.
72		* @param null\|string $id
73		* @return mixed
		0 ignored issues – show Documentation introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `Response\|string`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
74		*/
75		public function actionUpdate($id = null)
		0 ignored issues – show Coding Style introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report `actionUpdate` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
76		{
77		$abstractModel = new BaseSliderEditModel();
78
79		if (is_null($id)) {
80		$model = new Slider;
81		$model->loadDefaultValues();
82	View Code Duplication	} else {
83		$model = $this->findModel($id);
84		if ($model->handler() !== null) {
85		$abstractModel = Yii::createObject(['class'=>$model->handler()->edit_model]);
		0 ignored issues – show Documentation introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The property `edit_model` does not exist on `object<app\models\SliderHandler>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
86		if (!empty($model->params)) {
87		$abstractModel->unserialize($model->params);
88		}
89		}
90		}
91
92		$post = Yii::$app->request->post();
93
94		if ($model->load($post) && $model->validate()) {
95	View Code Duplication	if ($model->handler() !== null) {
96		$abstractModel = Yii::createObject(['class'=>$model->handler()->edit_model]);
		0 ignored issues – show Documentation introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The property `edit_model` does not exist on `object<app\models\SliderHandler>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
97		if (!empty($model->params)) {
98		$abstractModel->unserialize($model->params);
99		}
100		}
101		$abstractModel->load($post);
102		if ($abstractModel->validate()) {
103		$model->params = $abstractModel->serialize();
104	View Code Duplication	if ($model->save()) {
105		return $this->redirectUser($model->id, true, 'index', 'update');
106
107		} else {
108		Yii::$app->session->setFlash('error', Yii::t('app', 'Cannot save data'));
109		}
110		} else {
111		Yii::$app->session->setFlash('error', Yii::t('app', 'Cannot save data'));
112		}
113		}
114
115		$searchModel = new Slide();
116		$searchModel->slider_id = $model->id;
117		$dataProvider = $searchModel->search($_GET);
118
119		return $this->render(
120		'update',
121		[
122		'model' => $model,
123		'abstractModel' => $abstractModel,
124		'dataProvider' => $dataProvider,
125		'searchModel' => $searchModel,
126		]
127		);
128		}
129
130		/**
131		* @param integer $slider_id
132		*/
133		public function actionNewSlide($slider_id)
134		{
135		Yii::$app->response->format = Response::FORMAT_JSON;
136		$slider = $this->findModel($slider_id);
137		$model = new Slide();
138		$model->slider_id = $slider->id;
139		$model->active = 0;
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The property `active` does not seem to exist. Did you mean `activeValidators`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
140		$model->sort_order = count($slider->getSlides());
141		$model->save();
142		return $this->redirect(['update', 'id' => $slider_id]);
143		}
144
145		/**
146		* Update slide attributes
147		* @return array
148		* @throws \yii\web\BadRequestHttpException
149		*/
150		public function actionUpdateSlide()
151		{
152		Yii::$app->response->format = Response::FORMAT_JSON;
153		$post = Yii::$app->request->post();
154
155		if (!isset($post['editableIndex'], $post['editableKey'])) {
156		throw new BadRequestHttpException;
157		}
158		$id = $post['editableKey'];
159		/** @var Slide $model */
160		$model = Slide::findOne($id);
161		if ($model === null) {
162		throw new BadRequestHttpException;
163		}
164		$index = $post['editableIndex'];
165		if (!is_array($post['Slide'][$index])) {
166		throw new BadRequestHttpException;
167		}
168		if (count($post['Slide'][$index])===0) {
169		throw new BadRequestHttpException;
170		}
171
172		$modifiedAttribute = array_keys($post['Slide'][$index])[0];
173
174		$model->setAttributes($post['Slide'][$index]);
175
176
177		if (!$model->save()) {
178		return [
179		'message' => Yii::t('app', 'Cannot save object'),
180		];
181		}
182
183		if ($modifiedAttribute === 'active') {
184		$model->active ? Icon::show('check txt-color-green') : Icon::show('times txt-color-red');
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The property `active` does not seem to exist. Did you mean `activeValidators`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
185		}
186
187		return [
188		'output' => $model->getAttribute($modifiedAttribute),
189		];
190		}
191
192		public function actionDeleteSlide($id)
193		{
194		$slide = Slide::findOne($id);
195		$slider_id = $slide->slider_id;
196		$slide->delete();
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `delete` cannot be called on `$slide` (of type `array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
197		return $this->redirect(['update', 'id'=>$slider_id]);
198		}
199
200		public function actionUploadSlide()
		0 ignored issues – show Coding Style introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report `actionUploadSlide` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
201		{
202		if (!isset($_POST['slide_id'], $_POST['attribute'], $_POST['slider_id'])) {
203		throw new BadRequestHttpException();
204		}
205
206		$model = Slider::findById($_POST['slider_id']);
207		$slide = Slide::findOne($_POST['slide_id']);
208		if ($model === null \|\| $slide === null) {
209		throw new NotFoundHttpException;
210		}
211
212		$file = UploadedFile::getInstanceByName('file');
213		if ($file === null) {
214		throw new HttpException(500, "Upload file error");
215		}
216		if ($file->hasError) {
217		throw new HttpException(500, 'Upload error');
218		}
219
220		$fileName = $file->name;
221		$uploadDir = Yii::getAlias(Yii::$app->getModule('core')->fileUploadPath);
222		$fn = $uploadDir . $fileName;
223		if (file_exists($fn)) {
224		$fileName = $file->baseName . '-' . uniqid() . '.' . $file->extension;
225		$fn = $uploadDir . $fileName;
226		}
227
228
229		$file->saveAs($fn);
230
231		$image = \yii\imagine\Image::thumbnail($uploadDir . $fileName,
232		$model->image_width,
233		$model->image_height,
234		ManipulatorInterface::THUMBNAIL_INSET
235		);
236		$image->save($uploadDir . 'small-' . $fileName, ['quality'=>95]);
237
238		$slide->setAttribute($_POST['attribute'], str_replace(Yii::getAlias('@webroot'), '', $uploadDir) . 'small-' . $fileName);
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `setAttribute` cannot be called on `$slide` (of type `array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history... Coding Style introduced 2016-02-05 12:50 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 129 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
239		$slide->save();
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `save` cannot be called on `$slide` (of type `array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
240
241		return $this->redirect(['update', 'id' => $model->id]);
242		}
243
244		/**
245		* Deletes an existing Slider model.
246		* If deletion is successful, the browser will be redirected to the 'index' page.
247		* @param string $id
248		* @return mixed
		0 ignored issues – show Documentation introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `Response`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
249		*/
250		public function actionDelete($id)
251		{
252		$this->findModel($id)->delete();
253
254		return $this->redirect(['index']);
255		}
256
257		/**
258		* Finds the Slider model based on its primary key value.
259		* If the model is not found, a 404 HTTP exception will be thrown.
260		* @param string $id
261		* @return Slider the loaded model
262		* @throws NotFoundHttpException if the model cannot be found
263		*/
264		protected function findModel($id)
265		{
266		if (($model = Slider::findById($id)) !== null) {
267		return $model;
268		} else {
269		throw new NotFoundHttpException('The requested page does not exist.');
270		}
271		}
272		}

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — filters-dev ( b32603 )

SliderController::actionUpdate() C

Complexity

Size

Duplication

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like