FormController::actionEdit() - Code Metrics - Inspection of "Merge branch 'master' into filters-dev" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — filters-dev ( b32603 )

unknown

created 2016-03-03 10:51 UTC

FormController::actionEdit() D

↳ Parent: FormController

Complexity

Conditions	12
Paths	152

Size

Total Lines	117
Code Lines	74

Duplication

Lines	7
Ratio	5.98 %

Metric	Value
dl	7
loc	117
rs	4.6933
cc	12
eloc	74
nc	152
nop	1

How to fix Long Method Complexity

<?php

namespace app\backend\controllers;

use app\models\Form;
use app\models\Object;
use app\models\ObjectPropertyGroup;
use app\models\PropertyGroup;
use app\models\Submission;
use app\properties\DynamicSearchModel;
use Yii;
use yii\db\Query;
use yii\filters\AccessControl;
use yii\helpers\ArrayHelper;
use yii\web\Controller;
use yii\web\NotFoundHttpException;
use yii\helpers\Url;

class FormController extends Controller
{

    public function behaviors()
    {
        return [
            'access' => [
                'class' => AccessControl::className(),
                'rules' => [
                    [
                        'allow' => true,
                        'roles' => ['form manage'],
                    ],
                ],
            ],
        ];
    }

    public function actionIndex()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $searchModel = new Form();
        $dataProvider = $searchModel->search($_GET);

        return $this->render(
            'index',
            [
                'dataProvider' => $dataProvider,
                'searchModel' => $searchModel,
            ]
        );
    }

    public function actionEdit($id = null)
    {
        $model = new Form();
        if ($id > 0) {
            $model = Form::findOne($id);
        }

        /** @var \app\models\Object $object */
        $object = Object::getForClass(Form::className());

        $propIds = (new Query())->select('property_group_id')->from([ObjectPropertyGroup::tableName()])->where(
            [
                'and',
                'object_id = :object',
                'object_model_id = :id'
            ],
            [
                ':object' => $object->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                ':id' => $id
            ]
        )->column();

        $post = \Yii::$app->request->post();
        $properties = isset($post['Form']['properties']) ? $post['Form']['properties'] : [];

        if ($model->load($post) && $model->validate()) {
            if ($model->save()) {
                $id = $model->id;
                $remove = [];
                $add = [];

                foreach ($propIds as $value) {
                    $key = array_search($value, $properties);
                    if ($key === false) {
                        $remove[] = $value;
                    } else {
                        unset($properties[$key]);
                    }
                }
                foreach ($properties as $value) {
                    $add[] = [
                        $value,
                        $object->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        $id
                    ];
                }

                Yii::$app->db->createCommand()->delete(
                    ObjectPropertyGroup::tableName(),
                    [
                        'and',
                        'object_id = :object',
                        'object_model_id = :id',
                        ['in', 'property_group_id', $remove]
                    ],
                    [
                        ':object' => $object->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        ':id' => $id,
                    ]
                )->execute();

                if (!empty($add)) {
                    Yii::$app->db->createCommand()->batchInsert(
                        ObjectPropertyGroup::tableName(),
                        ['property_group_id', 'object_id', 'object_model_id'],
                        $add
                    )->execute();
                }

                \Yii::$app->session->setFlash('info', Yii::t('app', 'Object saved'));
                $returnUrl = Yii::$app->request->get('returnUrl', ['/backend/form/index', 'id' => $model->id]);
                switch (Yii::$app->request->post('action', 'save')) {
                    case 'next':
                        return $this->redirect(
                            [
                                '/backend/form/edit',
                                'returnUrl' => $returnUrl,
                            ]
                        );
                    case 'back':
                        return $this->redirect($returnUrl);
                    default:
                        return $this->redirect(
                            Url::toRoute(
                                [
                                    '/backend/form/edit',
                                    'id' => $model->id,
                                    'returnUrl' => $returnUrl,
                                ]
                            )
                        );
                }
            } else {
                \Yii::$app->session->setFlash('error', Yii::t('app', 'Cannot update data'));
            }
        }

        $items = ArrayHelper::map(
            PropertyGroup::find()->where(
                'object_id = :object',
                [
                    ':object' => $object->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                ]
            )->all(),
            'id',
            'name'
        );

        return $this->render(
            'edit',
            [
                'model' => $model,
                'items' => $items,
                'selected' => $propIds,
            ]
        );
    }

    public function actionView($id, $show_deleted = 0)
    {
        $form = Form::findById($id);
        $propertyGroups = $form->getPropertyGroups();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $submission = new Submission();

        $dynamicModel = new DynamicSearchModel($submission, $propertyGroups);
        $data = $dynamicModel->search(Yii::$app->request->get());
        $data->query->andWhere('form_id = :form_id', [':form_id' => $form->id]);

        $data->query->andWhere(['is_deleted' => $show_deleted]);
        $data->query->andFilterWhere(['sending_status' => $dynamicModel->sending_status]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $data->query->andFilterWhere(['like', 'ip', $dynamicModel->ip]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $data->query->andFilterWhere(['like', 'user_agent', $dynamicModel->user_agent]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}


        return $this->render(
            'view',
            [
                'searchModel' => $dynamicModel,
                'dataProvider' => $data,
                'form' => $form,
            ]
        );
    }
    
    public function actionViewSubmission($id)
    {
        $submission = Submission::findOne($id);
        if ($submission === null) {
            throw new NotFoundHttpException('Submission not found');
        }

        return $this->render(
            'view-submission',
            [
                'submission' => $submission,
            ]
        );
    }

    public function actionDeleteSubmission($id)
    {
        $submission = Submission::findOne($id);
        $form_id = $submission->form_id;
        if ($submission === null) {
            throw new NotFoundHttpException('Submission not found');
        }
        $res = false;
        if ($submission->is_deleted == 1) {
            if ($submission->delete()) {

                $res = true;
            }
        } else {
            $submission->setAttribute('is_deleted', 1);

            if ($submission->save()) {

                $res = true;
            }
        }
        if ($res === false) {
            Yii::$app->session->setFlash('error', Yii::t('app', 'Object not removed'));
        } else {
            Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
        }
        return $this->redirect(Url::toRoute(['view', 'id' => $form_id]));
    }

    public function actionRestoreSubmission($id)
    {
        $submission = Submission::findOne($id);
        if ($submission === null) {
            throw new NotFoundHttpException('Submission not found');
        }
        $submission->setAttribute('is_deleted', 0);

        $submission->save();

        Yii::$app->session->setFlash('success', Yii::t('app', 'Object successfully restored'));

        return $this->redirect(Url::toRoute(['view', 'id' => $submission->form_id]));
    }

    public function actionDownload($key, $submissionId)

    {
        $submission = Submission::findOne($submissionId);
        if ($submission === null) {
            throw new NotFoundHttpException('Submission not found');
        }
        $prop = $submission->getPropertyValuesByKey($key);

        return \Yii::$app->response->sendFile(
            Yii::getAlias(Yii::$app->getModule('core')->visitorsFileUploadPath) .
            DIRECTORY_SEPARATOR .
            $prop->values[0]['value']
        );
    }

    public function actionDelete($id = null)
    {
        if ((null === $id) || (null === $model = Form::findOne($id))) {
            throw new NotFoundHttpException;
        }

        if (!$model->delete()) {

            Yii::$app->session->setFlash('error', Yii::t('app', 'Object not removed'));
        } else {
            Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
        }

        return $this->redirect(Url::toRoute('index'));
    }

    public function actionRemoveAll()
    {
        $items = Yii::$app->request->post('items', []);
        if (!empty($items)) {
            $items = Form::find()->where(['in', 'id', $items])->all();
            foreach ($items as $item) {
                $item->delete();
            }
        }

        return $this->redirect(['index']);
    }
}


1		<?php
2
3		namespace app\backend\controllers;
4
5		use app\models\Form;
6		use app\models\Object;
7		use app\models\ObjectPropertyGroup;
8		use app\models\PropertyGroup;
9		use app\models\Submission;
10		use app\properties\DynamicSearchModel;
11		use Yii;
12		use yii\db\Query;
13		use yii\filters\AccessControl;
14		use yii\helpers\ArrayHelper;
15		use yii\web\Controller;
16		use yii\web\NotFoundHttpException;
17		use yii\helpers\Url;
18
19		class FormController extends Controller
20		{
21
22	View Code Duplication	public function behaviors()
23		{
24		return [
25		'access' => [
26		'class' => AccessControl::className(),
27		'rules' => [
28		[
29		'allow' => true,
30		'roles' => ['form manage'],
31		],
32		],
33		],
34		];
35		}
36
37	View Code Duplication	public function actionIndex()
		0 ignored issues – show Coding Style introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report `actionIndex` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
38		{
39		$searchModel = new Form();

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — filters-dev ( b32603 )

FormController::actionEdit() D

Complexity

Size

Duplication

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like