PropertyHandler::run() - Code Metrics - Inspection of "Merge branch 'master' into filters-dev" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — filters-dev ( b32603 )

unknown

created 2016-03-03 10:51 UTC

PropertyHandler::run() B

↳ Parent: PropertyHandler

Complexity

Conditions	5
Paths	3

Size

Total Lines	23
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	23
rs	8.5906
cc	5
eloc	15
nc	3
nop	3

<?php

namespace app\backend\actions;

use app\models\Object;
use app\models\Property;
use app\properties\PropertyHandlers;
use yii;
use yii\base\Action;

class PropertyHandler extends Action
{
    public $modelName = null;
    public $objectId = null;

    /**
     * @throws yii\web\ServerErrorHttpException
     */
    public function init()
    {
        parent::init();
        if (null === $this->modelName) {
            throw new yii\web\ServerErrorHttpException('Model name should be set in controller actions');
        }

        if (!is_subclass_of($this->modelName, '\yii\db\ActiveRecord')) {

            throw new yii\web\ServerErrorHttpException('Model class does not exists');
        }

        $this->objectId = Object::getForClass($this->modelName);
        if (null === $this->objectId) {
            throw new yii\web\ServerErrorHttpException('Object does not exists for model.');
        }
    }

    /**
     * @param null $property_id
     * @param null $handler_action
     * @param null $model_id
     * @return mixed
     */
    public function run($property_id = null, $handler_action = null, $model_id = null)
    {
        if (null === $handler_action
            || null === $property_id
            || null === $model_id)
        {
            return '';
        }

        $property = Property::findById($property_id);
        if (null === $property) {
            return '';
        }

        $actionParams = [
            'model_name' => $this->modelName,
            'model_id' => $model_id,
            'object_id' => $this->objectId,
            'property' => $property,
        ];
        $propertyHandler = PropertyHandlers::createHandler($property->handler);

        return $propertyHandler->runAction($handler_action, $actionParams);
    }
}


1		<?php
2
3		namespace app\backend\actions;
4
5		use app\models\Object;
6		use app\models\Property;
7		use app\properties\PropertyHandlers;
8		use yii;
9		use yii\base\Action;
10
11		class PropertyHandler extends Action
12		{
13		public $modelName = null;
14		public $objectId = null;
15
16		/**
17		* @throws yii\web\ServerErrorHttpException
18		*/
19	View Code Duplication	public function init()
20		{
21		parent::init();
22		if (null === $this->modelName) {
23		throw new yii\web\ServerErrorHttpException('Model name should be set in controller actions');
24		}
25
26		if (!is_subclass_of($this->modelName, '\yii\db\ActiveRecord')) {
		0 ignored issues – show Bug introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` returns inconsistent results on some PHP versions for interfaces; you could instead use `ReflectionClass::implementsInterface`. Loading history...
27		throw new yii\web\ServerErrorHttpException('Model class does not exists');
28		}
29
30		$this->objectId = Object::getForClass($this->modelName);
31		if (null === $this->objectId) {
32		throw new yii\web\ServerErrorHttpException('Object does not exists for model.');
33		}
34		}
35
36		/**
37		* @param null $property_id
38		* @param null $handler_action
39		* @param null $model_id
40		* @return mixed
41		*/
42		public function run($property_id = null, $handler_action = null, $model_id = null)
43		{
44		if (null === $handler_action
45		\|\| null === $property_id
46		\|\| null === $model_id)
47		{
48		return '';
49		}
50
51		$property = Property::findById($property_id);
52		if (null === $property) {
53		return '';
54		}
55
56		$actionParams = [
57		'model_name' => $this->modelName,
58		'model_id' => $model_id,
59		'object_id' => $this->objectId,
60		'property' => $property,
61		];
62		$propertyHandler = PropertyHandlers::createHandler($property->handler);
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The property `handler` does not seem to exist. Did you mean `handlerAdditionalParams`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
63		return $propertyHandler->runAction($handler_action, $actionParams);
64		}
65		}
66

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — filters-dev ( b32603 )

PropertyHandler::run() B

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like