BackendWarehouseController - Code Metrics - Inspection of "Merge branch 'master' into filters-dev" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — filters-dev ( b32603 )

unknown

created 2016-03-03 10:51 UTC

BackendWarehouseController C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	288
Duplicated Lines	54.86 %

Coupling/Cohesion

Components	1
Dependencies	20

Metric	Value
wmc	38
lcom	1
cbo	20
dl	158
loc	288
rs	5.4352

10 Methods

Rating	Name	Duplication	Size	Complexity
A	actionUpdateRemains()	0	22	3
A	behaviors()	14	14	1
A	actions()	0	19	1
A	actionIndex()	0	19	1
D	actionEdit()	57	105	17
A	actionDelete()	19	19	3
A	actionEditPhone()	16	16	3
A	actionEditEmail()	14	14	3
A	actionDeletePhone()	19	19	3
A	actionDeleteEmail()	19	19	3

How to fix Duplicated Code

<?php

namespace app\modules\shop\controllers;

use app\backend\components\BackendController;
use app\components\SearchModel;
use app\modules\shop\models\WarehouseEmail;
use app\modules\shop\models\WarehouseOpeninghours;
use app\modules\shop\models\WarehousePhone;
use devgroup\TagDependencyHelper\ActiveRecordHelper;
use app\backend\actions\DeleteOne;
use app\backend\actions\MultipleDelete;
use app\backend\actions\UpdateEditable;
use app\modules\shop\models\Warehouse;
use app\modules\shop\models\WarehouseProduct;
use yii\helpers\Url;
use Yii;
use yii\data\ActiveDataProvider;
use yii\filters\AccessControl;
use yii\web\HttpException;
use yii\web\NotFoundHttpException;
use yii\caching\TagDependency;

class BackendWarehouseController extends BackendController
{
    /**
     * @inheritdoc
     */
    public function behaviors()
    {
        return [
            'access' => [
                'class' => AccessControl::className(),
                'rules' => [
                    [
                        'allow' => true,
                        'roles' => ['product manage'],
                    ],
                ],
            ],
        ];
    }

    /**
     * @inheritdoc
     */
    public function actions()
    {
        return [
            'remove-all' => [
                'class' => MultipleDelete::className(),
                'modelName' => Warehouse::className(),
            ],
            'delete' => [
                'class' => DeleteOne::className(),
                'modelName' => Warehouse::className(),
            ],
            'update-editable' => [
                'class' => UpdateEditable::className(),
                'modelName' => Warehouse::className(),
                'allowedAttributes' => [
                ],
            ],
        ];
    }

    public function actionIndex()

    {
        ;
        $searchModel = new SearchModel(
            [
                'model' => Warehouse::className(),
                'partialMatchAttributes' => ['name'],
                'scenario' => 'default',
            ]
        );
        $dataProvider = $searchModel->search(Yii::$app->request->queryParams);
        return $this->render(
            'index',
            [
                'dataProvider' => $dataProvider,
                'searchModel' => $searchModel,
            ]
        );
    }

    public function actionEdit($id = null)

    {
        $model = new Warehouse;
        $model->loadDefaultValues();

        if ($id !== null) {
            $model = Warehouse::findOne($id);
        }


        if ($model->load(Yii::$app->request->post()) && $model->validate()) {
            if ($model->save()) {
                Yii::$app->session->setFlash('info', Yii::t('app', 'Object saved'));
                $returnUrl = Yii::$app->request->get(
                    'returnUrl',
                    ['/shop/backend-warehouse/index']
                );
                switch (Yii::$app->request->post('action', 'save')) {
                    case 'next':
                        return $this->redirect(
                            [
                                '/shop/backend-warehouse/edit',
                                'returnUrl' => $returnUrl,
                            ]
                        );
                    case 'back':
                        return $this->redirect($returnUrl);
                    default:
                        return $this->redirect(
                            Url::toRoute(
                                [
                                    '/shop/backend-warehouse/edit',
                                    'id' => $model->id,
                                    'returnUrl' => $returnUrl,
                                ]
                            )
                        );
                }
            }


        }

        $wareHouseOpeningHours = WarehouseOpeninghours::find()->where(['warehouse_id' => $model->id])->one();
        if ($wareHouseOpeningHours === null) {
            $wareHouseOpeningHours = new WarehouseOpeninghours();
        }
        $wareHouseOpeningHours->loadDefaultValues();
        if (Yii::$app->request->post('WarehouseOpeninghours') && !$model->isNewRecord) {
            $wareHouseOpeningHours->load(Yii::$app->request->post());
            $wareHouseOpeningHours->warehouse_id = $model->id;
            if ($wareHouseOpeningHours->save()) {
                $this->refresh();
            }
        }

        $warehousePhone = new WarehousePhone();

        if (Yii::$app->request->post('WarehousePhone') && !$model->isNewRecord) {
            $warehousePhone->loadDefaultValues();
            $warehousePhone->load(Yii::$app->request->post());
            $warehousePhone->warehouse_id = $model->id;
            if ($warehousePhone->save()) {
                $this->refresh();
            }

        }
        $warehousePhoneProvider = new ActiveDataProvider([
            'query' => $warehousePhone::find()->where(['warehouse_id' => $model->id]),
            'pagination' => [
                'pageSize' => 20,
            ],
        ]);


        $warehouseEmail = new WarehouseEmail();
        if (Yii::$app->request->post('WarehouseEmail') && !$model->isNewRecord) {
            $warehouseEmail->loadDefaultValues();
            $warehouseEmail->load(Yii::$app->request->post());
            $warehouseEmail->warehouse_id = $model->id;
            if ($warehouseEmail->save()) {
                $this->refresh();
            }

        }
        $warehouseEmailProvider = new ActiveDataProvider([
            'query' => $warehouseEmail::find()->where(['warehouse_id' => $model->id]),
            'pagination' => [
                'pageSize' => 20,
            ],
        ]);


        return $this->render(
            'form',
            [
                'model' => $model,
                'wareHouseOpeningHours' => $wareHouseOpeningHours,
                'warehousePhone' => $warehousePhone,
                'warehousePhoneProvider' => $warehousePhoneProvider,
                'warehouseEmail' => $warehouseEmail,
                'warehouseEmailProvider' => $warehouseEmailProvider
            ]
        );
    }


    public function actionDelete($id)
    {
        if (!$model = Warehouse::findOne($id)) {
            throw new NotFoundHttpException;
        }

        if (!$model->delete()) {

            Yii::$app->session->setFlash('info', Yii::t('app', 'Object not removed'));
        } else {
            Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
        }

        return $this->redirect(
            Yii::$app->request->get(
                'returnUrl',
                '/shop/backend-warehouse/index'
            )
        );
    }

    public function actionEditPhone($id, $returnUrl)

    {
        $warehousePhone = WarehousePhone::findOne($id);

        if (Yii::$app->request->post('WarehousePhone')) {
            $warehousePhone->loadDefaultValues();

            $warehousePhone->load(Yii::$app->request->post());

            if ($warehousePhone->save()) {

                $this->redirect($returnUrl);
            }
        }



        return $this->render('form_edit_phone', ['warehousePhone' => $warehousePhone]);
    }


    public function actionEditEmail($id, $returnUrl)

    {
        $warehouseEmail = WarehouseEmail::findOne($id);

        if (Yii::$app->request->post('WarehouseEmail')) {
            $warehouseEmail->loadDefaultValues();

            $warehouseEmail->load(Yii::$app->request->post());

            if ($warehouseEmail->save()) {

                $this->redirect($returnUrl);
            }
        }

        return $this->render('form_edit_email', ['warehouseEmail' => $warehouseEmail]);
    }

    public function actionDeletePhone($id)
    {
        if (!$model = WarehousePhone::findOne($id)) {
            throw new NotFoundHttpException;
        }

        if (!$model->delete()) {

            Yii::$app->session->setFlash('info', Yii::t('app', 'Object not removed'));
        } else {
            Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
        }

        return $this->redirect(
            Yii::$app->request->get(
                'returnUrl',
                '/shop/backend-warehouse/index'
            )
        );
    }

    public function actionDeleteEmail($id)
    {
        if (!$model = WarehouseEmail::findOne($id)) {
            throw new NotFoundHttpException;
        }

        if (!$model->delete()) {

            Yii::$app->session->setFlash('info', Yii::t('app', 'Object not removed'));
        } else {
            Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
        }

        return $this->redirect(
            Yii::$app->request->get(
                'returnUrl',
                '/shop/backend-warehouse/index'
            )
        );
    }


    public function actionUpdateRemains()
    {
        $post = Yii::$app->request->post('remain', null);
        if (isset($post)) {
            Yii::$app->response->format = \yii\web\Response::FORMAT_JSON;
            $remainId = current(array_keys($post));
            /** @var WarehouseProduct $model */
            $model = WarehouseProduct::findOne($remainId);
            if ($model === null) {
                throw new NotFoundHttpException;
            }

            $model->setAttributes(current($post));
            TagDependency::invalidate(Yii::$app->cache,
                ActiveRecordHelper::getObjectTag(\app\modules\shop\models\Product::className(), $model->product_id));
            return $model->save();


        } else {
            throw new HttpException(400);
        }
    }

}


1		<?php
2
3		namespace app\modules\shop\controllers;
4
5		use app\backend\components\BackendController;
6		use app\components\SearchModel;
7		use app\modules\shop\models\WarehouseEmail;
8		use app\modules\shop\models\WarehouseOpeninghours;
9		use app\modules\shop\models\WarehousePhone;
10		use devgroup\TagDependencyHelper\ActiveRecordHelper;
11		use app\backend\actions\DeleteOne;
12		use app\backend\actions\MultipleDelete;
13		use app\backend\actions\UpdateEditable;
14		use app\modules\shop\models\Warehouse;
15		use app\modules\shop\models\WarehouseProduct;
16		use yii\helpers\Url;
17		use Yii;
18		use yii\data\ActiveDataProvider;
19		use yii\filters\AccessControl;
20		use yii\web\HttpException;
21		use yii\web\NotFoundHttpException;
22		use yii\caching\TagDependency;
23
24		class BackendWarehouseController extends BackendController
25		{
26		/**
27		* @inheritdoc
28		*/
29	View Code Duplication	public function behaviors()
30		{
31		return [
32		'access' => [
33		'class' => AccessControl::className(),
34		'rules' => [
35		[
36		'allow' => true,
37		'roles' => ['product manage'],
38		],
39		],
40		],
41		];
42		}
43
44		/**
45		* @inheritdoc
46		*/
47		public function actions()
48		{
49		return [
50		'remove-all' => [
51		'class' => MultipleDelete::className(),
52		'modelName' => Warehouse::className(),
53		],
54		'delete' => [
55		'class' => DeleteOne::className(),
56		'modelName' => Warehouse::className(),
57		],
58		'update-editable' => [
59		'class' => UpdateEditable::className(),
60		'modelName' => Warehouse::className(),
61		'allowedAttributes' => [
62		],
63		],
64		];
65		}
66
67		public function actionIndex()
		0 ignored issues – show Documentation introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
68		{
69		;
70		$searchModel = new SearchModel(
71		[
72		'model' => Warehouse::className(),
73		'partialMatchAttributes' => ['name'],
74		'scenario' => 'default',
75		]
76		);
77		$dataProvider = $searchModel->search(Yii::$app->request->queryParams);
78		return $this->render(
79		'index',
80		[
81		'dataProvider' => $dataProvider,
82		'searchModel' => $searchModel,
83		]
84		);
85		}
86
87		public function actionEdit($id = null)
		0 ignored issues – show Documentation introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
88		{
89		$model = new Warehouse;
90		$model->loadDefaultValues();
91
92		if ($id !== null) {
93		$model = Warehouse::findOne($id);
94		}
95
96
97	View Code Duplication	if ($model->load(Yii::$app->request->post()) && $model->validate()) {
98		if ($model->save()) {
99		Yii::$app->session->setFlash('info', Yii::t('app', 'Object saved'));
100		$returnUrl = Yii::$app->request->get(
101		'returnUrl',
102		['/shop/backend-warehouse/index']
103		);
104		switch (Yii::$app->request->post('action', 'save')) {
105		case 'next':
106		return $this->redirect(
107		[
108		'/shop/backend-warehouse/edit',
109		'returnUrl' => $returnUrl,
110		]
111		);
112		case 'back':
113		return $this->redirect($returnUrl);
114		default:
115		return $this->redirect(
116		Url::toRoute(
117		[
118		'/shop/backend-warehouse/edit',
119		'id' => $model->id,
120		'returnUrl' => $returnUrl,
121		]
122		)
123		);
124		}
125		}
126
127
128		}
129
130		$wareHouseOpeningHours = WarehouseOpeninghours::find()->where(['warehouse_id' => $model->id])->one();
131		if ($wareHouseOpeningHours === null) {
132		$wareHouseOpeningHours = new WarehouseOpeninghours();
133		}
134		$wareHouseOpeningHours->loadDefaultValues();
135	View Code Duplication	if (Yii::$app->request->post('WarehouseOpeninghours') && !$model->isNewRecord) {
136		$wareHouseOpeningHours->load(Yii::$app->request->post());
137		$wareHouseOpeningHours->warehouse_id = $model->id;
138		if ($wareHouseOpeningHours->save()) {
139		$this->refresh();
140		}
141		}
142
143		$warehousePhone = new WarehousePhone();
144
145	View Code Duplication	if (Yii::$app->request->post('WarehousePhone') && !$model->isNewRecord) {
146		$warehousePhone->loadDefaultValues();
147		$warehousePhone->load(Yii::$app->request->post());
148		$warehousePhone->warehouse_id = $model->id;
149		if ($warehousePhone->save()) {
150		$this->refresh();
151		}
152
153		}
154		$warehousePhoneProvider = new ActiveDataProvider([
155		'query' => $warehousePhone::find()->where(['warehouse_id' => $model->id]),
156		'pagination' => [
157		'pageSize' => 20,
158		],
159		]);
160
161
162		$warehouseEmail = new WarehouseEmail();
163	View Code Duplication	if (Yii::$app->request->post('WarehouseEmail') && !$model->isNewRecord) {
164		$warehouseEmail->loadDefaultValues();
165		$warehouseEmail->load(Yii::$app->request->post());
166		$warehouseEmail->warehouse_id = $model->id;
167		if ($warehouseEmail->save()) {
168		$this->refresh();
169		}
170
171		}
172		$warehouseEmailProvider = new ActiveDataProvider([
173		'query' => $warehouseEmail::find()->where(['warehouse_id' => $model->id]),
174		'pagination' => [
175		'pageSize' => 20,
176		],
177		]);
178
179
180		return $this->render(
181		'form',
182		[
183		'model' => $model,
184		'wareHouseOpeningHours' => $wareHouseOpeningHours,
185		'warehousePhone' => $warehousePhone,
186		'warehousePhoneProvider' => $warehousePhoneProvider,
187		'warehouseEmail' => $warehouseEmail,
188		'warehouseEmailProvider' => $warehouseEmailProvider
189		]
190		);
191		}
192
193
194	View Code Duplication	public function actionDelete($id)
195		{
196		if (!$model = Warehouse::findOne($id)) {
197		throw new NotFoundHttpException;
198		}
199
200		if (!$model->delete()) {
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `delete` cannot be called on `$model` (of type `array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
201		Yii::$app->session->setFlash('info', Yii::t('app', 'Object not removed'));
202		} else {
203		Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
204		}
205
206		return $this->redirect(
207		Yii::$app->request->get(
208		'returnUrl',
209		'/shop/backend-warehouse/index'
210		)
211		);
212		}
213
214	View Code Duplication	public function actionEditPhone($id, $returnUrl)
		0 ignored issues – show Documentation introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
215		{
216		$warehousePhone = WarehousePhone::findOne($id);
217
218		if (Yii::$app->request->post('WarehousePhone')) {
219		$warehousePhone->loadDefaultValues();
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `loadDefaultValues` cannot be called on `$warehousePhone` (of type `array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
220		$warehousePhone->load(Yii::$app->request->post());
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `load` cannot be called on `$warehousePhone` (of type `array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
221		if ($warehousePhone->save()) {
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `save` cannot be called on `$warehousePhone` (of type `array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
222		$this->redirect($returnUrl);
223		}
224		}
225
226
227
228		return $this->render('form_edit_phone', ['warehousePhone' => $warehousePhone]);
229		}
230
231
232	View Code Duplication	public function actionEditEmail($id, $returnUrl)
		0 ignored issues – show Documentation introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
233		{
234		$warehouseEmail = WarehouseEmail::findOne($id);
235
236		if (Yii::$app->request->post('WarehouseEmail')) {
237		$warehouseEmail->loadDefaultValues();
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `loadDefaultValues` cannot be called on `$warehouseEmail` (of type `array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
238		$warehouseEmail->load(Yii::$app->request->post());
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `load` cannot be called on `$warehouseEmail` (of type `array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
239		if ($warehouseEmail->save()) {
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `save` cannot be called on `$warehouseEmail` (of type `array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
240		$this->redirect($returnUrl);
241		}
242		}
243
244		return $this->render('form_edit_email', ['warehouseEmail' => $warehouseEmail]);
245		}
246
247	View Code Duplication	public function actionDeletePhone($id)
248		{
249		if (!$model = WarehousePhone::findOne($id)) {
250		throw new NotFoundHttpException;
251		}
252
253		if (!$model->delete()) {
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `delete` cannot be called on `$model` (of type `array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
254		Yii::$app->session->setFlash('info', Yii::t('app', 'Object not removed'));
255		} else {
256		Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
257		}
258
259		return $this->redirect(
260		Yii::$app->request->get(
261		'returnUrl',
262		'/shop/backend-warehouse/index'
263		)
264		);
265		}
266
267	View Code Duplication	public function actionDeleteEmail($id)
268		{
269		if (!$model = WarehouseEmail::findOne($id)) {
270		throw new NotFoundHttpException;
271		}
272
273		if (!$model->delete()) {
		0 ignored issues – show Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `delete` cannot be called on `$model` (of type `array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
274		Yii::$app->session->setFlash('info', Yii::t('app', 'Object not removed'));
275		} else {
276		Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
277		}
278
279		return $this->redirect(
280		Yii::$app->request->get(
281		'returnUrl',
282		'/shop/backend-warehouse/index'
283		)
284		);
285		}
286
287
288		public function actionUpdateRemains()
289		{
290		$post = Yii::$app->request->post('remain', null);
291		if (isset($post)) {
292		Yii::$app->response->format = \yii\web\Response::FORMAT_JSON;
293		$remainId = current(array_keys($post));
294		/** @var WarehouseProduct $model */
295		$model = WarehouseProduct::findOne($remainId);
296		if ($model === null) {
297		throw new NotFoundHttpException;
298		}
299
300		$model->setAttributes(current($post));
301		TagDependency::invalidate(Yii::$app->cache,
302		ActiveRecordHelper::getObjectTag(\app\modules\shop\models\Product::className(), $model->product_id));
303		return $model->save();
304
305
306		} else {
307		throw new HttpException(400);
308		}
309		}
310
311		}
312

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — filters-dev ( b32603 )

BackendWarehouseController C

Complexity

Size/Duplication

Coupling/Cohesion

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like