app\modules\review\widgets\rating\RatingShowWidget

Complexity

Total Complexity

15

Size/Duplication

Total Lines	94
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	init()	0	16	6
C	run()	0	47	7
A	calculateRating()	0	8	2

<?php

namespace app\modules\review\widgets\rating;

use app\modules\review\models\RatingItem;
use app\modules\review\models\RatingValues;
use app\modules\review\models\Review;
use Yii;
use yii\base\Widget;
use yii\helpers\ArrayHelper;

class RatingShowWidget extends Widget
{
    public $objectModel;
    public $calcFunction;
    public $viewFile = 'rating-show';
    /**
     * @var Review|null
     */
    public $reviewModel = null;

    /**
     * @inheritdoc
     */
    public function init()
    {
        parent::init();
        RatingAsset::register($this->view);
        if (is_array($this->calcFunction) && count($this->calcFunction) >= 2) {
            $class = array_shift($this->calcFunction);
            $method = array_shift($this->calcFunction);
            if (class_exists($class) && method_exists($class, $method)) {
                $this->calcFunction = [$class, $method];
            } else {
                $this->calcFunction = [$this, 'calculateRating'];
            }
        } elseif (!$this->calcFunction instanceof \Closure) {
            $this->calcFunction = [$this, 'calculateRating'];
        }
    }

    /**
     * @inheritdoc
     */
    public function run()
    {
        parent::run();
        if (!is_null($this->objectModel)) {
            $groupedRatingValues = RatingValues::getValuesByObjectModel($this->objectModel);
            if (!empty($groupedRatingValues)) {
                $groups = [];
                foreach ($groupedRatingValues as $groupId => $group) {
                    $ratingItem = RatingItem::findById($groupId);
                    $groups[] = [
                        'name' => !is_null($ratingItem) ? $ratingItem->name : Yii::t('app', 'Unknown rating'),
                        'rating' => call_user_func($this->calcFunction, $group),
                        'votes' => count($group),
                    ];
                }
            } else {
                $groups = null;
            }
            return $this->render(
                $this->viewFile,
                [
                    'groups' => $groups,
                ]
            );
        } elseif (!is_null($this->reviewModel)) {
            $value = RatingValues::findOne(['rating_id' => $this->reviewModel->rating_id]);
            $groups = [];

            $ratingItem = RatingItem::findById(ArrayHelper::getValue($value, 'rating_item_id', 0));

It seems like $value defined by \app\modules\review\models\RatingValues::findOne(array('rating_id' => $this->reviewModel->rating_id)) on line 70 can also be of type boolean; however, yii\helpers\BaseArrayHelper::getValue() does only seem to accept array|object, maybe add an additional type check?

            $group = [ArrayHelper::getValue($value, 'value')];

It seems like $value defined by \app\modules\review\models\RatingValues::findOne(array('rating_id' => $this->reviewModel->rating_id)) on line 70 can also be of type boolean; however, yii\helpers\BaseArrayHelper::getValue() does only seem to accept array|object, maybe add an additional type check?

            $groups[] = [
                'name' => !is_null($ratingItem) ? $ratingItem->name : Yii::t('app', 'Unknown rating'),
                'rating' => call_user_func($this->calcFunction, $group),
            ];

            return $this->render(
                $this->viewFile,
                [
                    'groups' => $groups,
                ]
            );
        } else {
            return '';
        }

    }

    /**
     * @param $values
     * @return float|int
     */
    private function calculateRating($values)
    {
        $count = count($values);
        if (0 === $sum = array_sum($values)) {
            return 0;
        }
        return $sum / $count;
    }
}