AdminController::actionParseUrl() - Code Metrics - Inspection of "add admin/parse-url console command" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/ParseUrlCommand ( c58f1c )

by Alexander

created 2016-12-07 06:59 UTC

AdminController::actionParseUrl() A

↳ Parent: AdminController

Complexity

Conditions	2
Paths	1

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	1
nop	2

<?php

namespace app\commands;

use Imagine\Image\ManipulatorInterface;
use app\backend\actions\FlushCacheConsoleAction;
use Yii;
use yii\console\Controller;
use app;
use app\modules\image\models\Image;

/**
 * Admin commands
 * @package app\commands
 */
class AdminController extends Controller
{

    public function actions()
    {
        return [
            'flush-cache' => [
                'class' => FlushCacheConsoleAction::className(),
            ],
        ];
    }

    /**
     * Generate thumbnails for Image model
     * @param bool $updateThumbnailSrc
     * @param bool $deleteIfNotExists
     * @throws \Exception
     */
    public function actionThumbnails($updateThumbnailSrc = false, $deleteIfNotExists = false)
    {
        $images = Image::find()->all();
        /** @var $images Image[] */
        foreach ($images as $image) {
            $dir = '@webroot' . mb_substr($image->filename, 0, mb_strrpos($image->filename, '/')) . '/';
            $filename = \Yii::getAlias($dir . $image->filename);
            if (!file_exists($filename)) {
                echo "File not found: " . $filename . "\n";
                if ($deleteIfNotExists) {
                    $image->delete();
                }
                continue;
            }
            $img = \yii\imagine\Image::thumbnail(
                $filename,
                80,
                80,
                ManipulatorInterface::THUMBNAIL_INSET
            );
            $img->save(\Yii::getAlias($dir . 'small-' . $image->filename));
            if ($updateThumbnailSrc) {
                $image->thumbnail_src = mb_substr($image->filename, 0, mb_strrpos($image->filename, '/'))
                    . '/small-' . $image->filename;
                $image->save(true, ['thumbnail_src']);
            }
        }
    }

    /**
     * Clear test review, orders and other information
     * @throws \yii\db\Exception
     */
    public function actionClearTests()
    {
        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\models\ErrorLog::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\models\ErrorUrl::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\backend\models\Notification::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\modules\shop\models\Order::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\modules\shop\models\OrderItem::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\modules\shop\models\OrderTransaction::tableName())->execute();

        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\backend\models\OrderChat::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE {{%order_category}}')->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE {{%order_eav}}')->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE {{%order_property}}')->execute();
//        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\reviews\models\Review::tableName())->execute(); @todo need to implement correct reviews deleting

        Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\models\Submission::tableName())->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE {{%submission_category}}')->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE {{%submission_eav}}')->execute();
        Yii::$app->db->createCommand('TRUNCATE TABLE {{%submission_property}}')->execute();
        Yii::$app->db->createCommand('DELETE FROM ' . app\models\ObjectPropertyGroup::tableName()
            . ' WHERE `object_id` IN (SELECT `id` FROM ' . app\models\Object::tableName()
            . ' WHERE `object_class` IN (\'app\\models\\Submission\', \'app\\models\\Order\'))')->execute();
        Yii::$app->db->createCommand('DELETE FROM ' . app\models\ObjectStaticValues::tableName()
            . ' WHERE `object_id` IN (SELECT `id` FROM ' . app\models\Object::tableName()
            . ' WHERE `object_class` IN (\'app\\models\\Submission\', \'app\\models\\Order\'))')->execute();
    }

    public function actionTestMail($email)
    {

        $mailComponent = Yii::$app->mail;

        $status = $mailComponent->compose('test')
            ->setFrom(Yii::$app->getModule('core')->emailConfig['mailFrom'])
            ->setTo($email)
            ->setSubject(
                Yii::t(
                    'app', 'subject test mail on {site}',
                    [
                        'site' => 'Site'
                    ]
                )
            )->send();
        echo $status ? "OK\n" : "NOT OK\n";
    }


    protected function createStructure($path, $children, $themeName)
    {
        foreach ($children as $child) {
            $newPath = $path . DIRECTORY_SEPARATOR . $child['name'];
            if (isset($child['type']) && $child['type'] == 'dir') {
                mkdir($newPath);
                chmod($newPath, isset($child['writable']) && $child['writable'] ? 0777 : 0775);
                if (isset($child['children']) && !empty($child['children'])) {
                    $this->createStructure($newPath, $child['children'], $themeName);
                } else {
                    file_put_contents($newPath . DIRECTORY_SEPARATOR . '.keep', '');
                }
            } else {
                file_put_contents($newPath,
                    isset($child['content']) ? str_replace('{%theme-name%}', $themeName, $child['content']) : '');
            }
        }
    }

    /**
     * Create theme structure
     * @param string $name
     * @throws \yii\base\ExitException
     */
    public function actionCreateTheme($name = 'theme')
    {
        $name = trim($name);
        if (preg_match('#^[a-z]+$#i', $name) == 0) {
            echo "Bad theme name" . PHP_EOL;
            Yii::$app->end();
        }
        $themeRoot = Yii::getAlias('@webroot/' . $name);
        if (file_exists($themeRoot)) {
            echo "Directory \"{$themeRoot}\" already exists: " . PHP_EOL;
            Yii::$app->end();
        }
        $structure = include __DIR__ . DIRECTORY_SEPARATOR . 'data' . DIRECTORY_SEPARATOR . 'theme-structure.php';
        mkdir($themeRoot);
        $this->createStructure($themeRoot, $structure, $name);
        echo "Theme \"{$name}\" has been created" . PHP_EOL;
        if (exec("which npm")) {
            echo "Installing node.js dependencies" . PHP_EOL;
            exec("cd $themeRoot ; npm install");
        }
    }
    /**
    * Parse url to route and corresponding params
    *
    * @param string $url
    * @param bool $prettify
    * @return string json_encode'd

    */
    public function actionParseUrl($url = "/", $prettify = false) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        $_SERVER["SERVER_NAME"] = \Yii::$app->getModule('core')->serverName;

        $this->stdout(
            json_encode(
                \Yii::$app->getUrlManager()->parseRequest(
                    new \yii\web\Request(
                        [
                            "url" => $url,
                            "pathInfo" => ltrim($url, "/")
                        ]
                    )
                ),
                $prettify ? JSON_PRETTY_PRINT : 0
            )
        );
    }
}


1			<?php
2
3			namespace app\commands;
4
5			use Imagine\Image\ManipulatorInterface;
6			use app\backend\actions\FlushCacheConsoleAction;
7			use Yii;
8			use yii\console\Controller;
9			use app;
10			use app\modules\image\models\Image;
11
12			/**
13			* Admin commands
14			* @package app\commands
15			*/
16			class AdminController extends Controller
17			{
18
19			public function actions()
20			{
21			return [
22			'flush-cache' => [
23			'class' => FlushCacheConsoleAction::className(),
24			],
25			];
26			}
27
28			/**
29			* Generate thumbnails for Image model
30			* @param bool $updateThumbnailSrc
31			* @param bool $deleteIfNotExists
32			* @throws \Exception
33			*/
34			public function actionThumbnails($updateThumbnailSrc = false, $deleteIfNotExists = false)
35			{
36			$images = Image::find()->all();
37			/** @var $images Image[] */
38			foreach ($images as $image) {
39			$dir = '@webroot' . mb_substr($image->filename, 0, mb_strrpos($image->filename, '/')) . '/';
40			$filename = \Yii::getAlias($dir . $image->filename);
41			if (!file_exists($filename)) {
42			echo "File not found: " . $filename . "\n";
43			if ($deleteIfNotExists) {
44			$image->delete();
45			}
46			continue;
47			}
48			$img = \yii\imagine\Image::thumbnail(
49			$filename,
50			80,
51			80,
52			ManipulatorInterface::THUMBNAIL_INSET
53			);
54			$img->save(\Yii::getAlias($dir . 'small-' . $image->filename));
55			if ($updateThumbnailSrc) {
56			$image->thumbnail_src = mb_substr($image->filename, 0, mb_strrpos($image->filename, '/'))
57			. '/small-' . $image->filename;
58			$image->save(true, ['thumbnail_src']);
59			}
60			}
61			}
62
63			/**
64			* Clear test review, orders and other information
65			* @throws \yii\db\Exception
66			*/
67			public function actionClearTests()
68			{
69			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\models\ErrorLog::tableName())->execute();
70			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\models\ErrorUrl::tableName())->execute();
71			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\backend\models\Notification::tableName())->execute();
72			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\modules\shop\models\Order::tableName())->execute();
73			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\modules\shop\models\OrderItem::tableName())->execute();
74			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\modules\shop\models\OrderTransaction::tableName())->execute();
			0 ignored issues – show Coding Style introduced 2016-02-05 12:50 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 123 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
75			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\backend\models\OrderChat::tableName())->execute();
76			Yii::$app->db->createCommand('TRUNCATE TABLE {{%order_category}}')->execute();
77			Yii::$app->db->createCommand('TRUNCATE TABLE {{%order_eav}}')->execute();
78			Yii::$app->db->createCommand('TRUNCATE TABLE {{%order_property}}')->execute();
79			// Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\reviews\models\Review::tableName())->execute(); @todo need to implement correct reviews deleting
			0 ignored issues – show Coding Style Best Practice introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history... Unused Code Comprehensibility introduced 2016-02-05 12:50 UTC by Report Bug Copy Issue Report `37%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history... Coding Style introduced 2016-02-05 12:50 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 159 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
80			Yii::$app->db->createCommand('TRUNCATE TABLE ' . app\models\Submission::tableName())->execute();
81			Yii::$app->db->createCommand('TRUNCATE TABLE {{%submission_category}}')->execute();
82			Yii::$app->db->createCommand('TRUNCATE TABLE {{%submission_eav}}')->execute();
83			Yii::$app->db->createCommand('TRUNCATE TABLE {{%submission_property}}')->execute();
84			Yii::$app->db->createCommand('DELETE FROM ' . app\models\ObjectPropertyGroup::tableName()
85			. ' WHERE `object_id` IN (SELECT `id` FROM ' . app\models\Object::tableName()
86			. ' WHERE `object_class` IN (\'app\\models\\Submission\', \'app\\models\\Order\'))')->execute();
87			Yii::$app->db->createCommand('DELETE FROM ' . app\models\ObjectStaticValues::tableName()
88			. ' WHERE `object_id` IN (SELECT `id` FROM ' . app\models\Object::tableName()
89			. ' WHERE `object_class` IN (\'app\\models\\Submission\', \'app\\models\\Order\'))')->execute();
90			}
91
92			public function actionTestMail($email)
93			{
94
95			$mailComponent = Yii::$app->mail;
96
97			$status = $mailComponent->compose('test')
98			->setFrom(Yii::$app->getModule('core')->emailConfig['mailFrom'])
99			->setTo($email)
100			->setSubject(
101			Yii::t(
102			'app', 'subject test mail on {site}',
103			[
104			'site' => 'Site'
105			]
106			)
107			)->send();
108			echo $status ? "OK\n" : "NOT OK\n";
109			}
110
111
112			protected function createStructure($path, $children, $themeName)
113			{
114			foreach ($children as $child) {
115			$newPath = $path . DIRECTORY_SEPARATOR . $child['name'];
116			if (isset($child['type']) && $child['type'] == 'dir') {
117			mkdir($newPath);
118			chmod($newPath, isset($child['writable']) && $child['writable'] ? 0777 : 0775);
119			if (isset($child['children']) && !empty($child['children'])) {
120			$this->createStructure($newPath, $child['children'], $themeName);
121			} else {
122			file_put_contents($newPath . DIRECTORY_SEPARATOR . '.keep', '');
123			}
124			} else {
125			file_put_contents($newPath,
126			isset($child['content']) ? str_replace('{%theme-name%}', $themeName, $child['content']) : '');
127			}
128			}
129			}
130
131			/**
132			* Create theme structure
133			* @param string $name
134			* @throws \yii\base\ExitException
135			*/
136			public function actionCreateTheme($name = 'theme')
137			{
138			$name = trim($name);
139			if (preg_match('#^[a-z]+$#i', $name) == 0) {
140			echo "Bad theme name" . PHP_EOL;
141			Yii::$app->end();
142			}
143			$themeRoot = Yii::getAlias('@webroot/' . $name);
144			if (file_exists($themeRoot)) {
145			echo "Directory \"{$themeRoot}\" already exists: " . PHP_EOL;
146			Yii::$app->end();
147			}
148			$structure = include __DIR__ . DIRECTORY_SEPARATOR . 'data' . DIRECTORY_SEPARATOR . 'theme-structure.php';
149			mkdir($themeRoot);
150			$this->createStructure($themeRoot, $structure, $name);
151			echo "Theme \"{$name}\" has been created" . PHP_EOL;
152			if (exec("which npm")) {
153			echo "Installing node.js dependencies" . PHP_EOL;
154			exec("cd $themeRoot ; npm install");
155			}
156			}
157			/**
158			* Parse url to route and corresponding params
159			*
160			* @param string $url
161			* @param bool $prettify
162			* @return string json_encode'd
			0 ignored issues – show Documentation introduced 2016-12-07 07:06 UTC by Report Bug Copy Issue Report Should the return type not be `string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
163			*/
164			public function actionParseUrl($url = "/", $prettify = false) {
			0 ignored issues – show Coding Style introduced 2016-12-07 07:06 UTC by Report Bug Copy Issue Report `actionParseUrl` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
165			$_SERVER["SERVER_NAME"] = \Yii::$app->getModule('core')->serverName;
166
167			$this->stdout(
168			json_encode(
169			\Yii::$app->getUrlManager()->parseRequest(
170			new \yii\web\Request(
171			[
172			"url" => $url,
173			"pathInfo" => ltrim($url, "/")
174			]
175			)
176			),
177			$prettify ? JSON_PRETTY_PRINT : 0
178			)
179			);
180			}
181			}
182

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — feature/ParseUrlCommand ( c58f1c )

AdminController::actionParseUrl() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like