Yml::prepareProperties() - Code Metrics - Inspection of "[Feature] ability to change product class" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( c721cc...3ff35f )

by Ivan
created 2017-03-17 10:40 UTC
Yml::prepareProperties() D

↳ Parent: Yml
Complexity

Conditions	9
Paths	7
Size

Total Lines	35
Code Lines	27
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
c	1
b	0
f	0
dl	0
loc	35
rs	4.909
cc	9
eloc	27
nc	7
nop	0
<?php
namespace app\modules\shop\components\yml;

use app\models\ObjectStaticValues;
use app\models\Property;
use app\models\PropertyStaticValues;
use app\modules\shop\events\yml\YmlOffersEvent;
use app\modules\shop\helpers\CurrencyHelper;
use app\modules\shop\models\Category;
use app\modules\shop\models\Currency;
use app\modules\shop\models\Product;
use devgroup\TagDependencyHelper\ActiveRecordHelper;
use Yii;
use yii\base\Component;
use app\modules\shop\models\Yml as YmlModel;
use yii\caching\TagDependency;
use yii\db\Query;
use yii\helpers\Json;
use yii\helpers\Url;
use yii\web\View;

class Yml extends Component
{
    const PARAM_TYPE_FIELD = 'field';
    const PARAM_TYPE_RELATION = 'relation';
    const USE_GZIP = 1;
    const USE_OFFER_PARAM = 1;
    const USE_ADULT = 1;
    const USE_STORE = 1;
    const USE_PICKUP = 1;
    const USE_DELIVERY = 1;

    const EVENT_PROCESS_OFFER = 'ymlProcessOffer';

    /**
     * @property \app\modules\shop\models\Yml $model
     * @property string $viewFile
     * @property Currency $currency
     */
    protected $model = null;
    protected $viewFile = null;
    protected $currency = null;

    static public $_noImg = '';
    static public $ymlEavProperties = [];
    static public $ymlStaticProperties = [];

    /**
     * @inheritdoc
     */
    public function __construct(YmlModel $model, $config = [])
    {
        $this->model = $model;
        parent::__construct($config);
    }

    /**
     * @inheritdoc
     */
    public function init()
    {
        parent::init();

        if (false === $this->model instanceof YmlModel) {
            return false;
        }

        if (null === $this->viewFile) {
            $this->viewFile = Yii::$app->getModule('shop')->getViewPath() . '/backend-yml/generate/yml.php';
        }

        /** @var YmlModel $config */
        $config = $this->model;
        Yii::$app->urlManager->setHostInfo($config->shop_url);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->currency = CurrencyHelper::findCurrencyByIso($config->currency_id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if (static::USE_OFFER_PARAM == $config->offer_param) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->prepareProperties();
        }

        static::$_noImg = Yii::$app->getModule('image')->noImageSrc;
    }

    /**
     * @return bool
     */
    public function generate()
    {
        if (false === $this->model instanceof YmlModel) {
            return false;
        }

        /** @var \app\modules\shop\models\Yml $yml */
        $config = $this->model;
        /** @var View $view */
        $view = Yii::$app->getView();

        $outputParams = [];
        $outputParams['shop'] = $this->generateSectionShop($config);
        $outputParams['offers'] = [];

        $eventOffer = new YmlOffersEvent();
        $product = Yii::$container->get(Product::class);
        /** @var Product $model */
        foreach ($product::find()->where(['active' => 1])->batch() as $offers) {
            $eventOffer
                ->clearHandled()
                ->setOffers(array_reduce($offers, function ($r, $i) use ($config) {
                    if (null !== $o = $this->generateSingleOffer($config, $i)) {
                        $r[] = $o;
                    }
                    return $r;
                }, []));
            $this->trigger(static::EVENT_PROCESS_OFFER, $eventOffer);

            $outputParams['offers'] = array_merge($outputParams['offers'], array_column($eventOffer->getOffers(), 'result'));

        }

        $output = $view->renderFile($this->viewFile, $outputParams);

        $fileName = Yii::getAlias('@webroot') . '/' . $config->general_yml_filename;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $result = static::USE_GZIP === $config->use_gzip
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ? file_put_contents($fileName . '.gz', gzencode($output), 5)
            : file_put_contents($fileName, $output);

        return false !== $result;
    }

    /**
     * @param YmlModel $config
     * @param string $name
     * @param Product $model
     * @param string $default
     * @return mixed
     */
    public static function getOfferValue(YmlModel $config, $name, Product $model, $default = '')
    {
        $param = $config->$name;

        if (static::PARAM_TYPE_FIELD === $param['type']) {
            $field = $param['key'];
            $result = $model->$field;
        } elseif (static::PARAM_TYPE_RELATION === $param['type']) {
            $rel = call_user_func([$model, $param['key']]);
            $attr = $param['value'];
            $rel = $rel->one();
            if (false === empty($rel)) {
                $result = $rel->$attr;
            }
        }

        return false === empty($result) ? $result : $default;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     *
     */
    private function prepareProperties()
    {
        $props = Property::getDb()->cache(function ($db) {

            return Property::find()->select([
                'id',
                'name',
                'property_handler_id',
                'key',
                'property_group_id',
                'has_static_values',
                'is_eav',
                'handler_additional_params'
            ])->all();
        }, 86400, new TagDependency(['tags' => [ActiveRecordHelper::getCommonTag(Property::className()),]]));
        foreach ($props as $one) {
            $additionalParams = Json::decode($one['handler_additional_params']);
            if (false === empty($additionalParams['use_in_file'])) {
                if (1 == $one['is_eav'] && false === isset(self::$ymlEavProperties[$one['id']])) {
                    self::$ymlEavProperties[$one['id']] = [
                        'name' => $one['name'],
                        'unit' => empty($additionalParams['unit']) ? '' : $additionalParams['unit'],
                        'key' => $one['key'],
                        'group_id' => $one['property_group_id'],
                        'handler_id' => $one['property_handler_id'],
                    ];
                } elseif (1 == $one['has_static_values'] && false === isset(self::$ymlStaticProperties[$one['id']])) {
                    self::$ymlStaticProperties[$one['id']] = [
                        'name' => $one['name'],
                        'unit' => empty($additionalParams['unit']) ? '' : $additionalParams['unit'],
                    ];
                }

            }
        }
    }

    /**
     * @param Product $model
     * @return array
     */
    public static function getOfferParams(Product $model)
    {
        $params = [];
        $eav = Yii::$app->getDb()->cache(function ($db) use ($model) {

            /**
             * @var \app\models\Object $object
             */
            $object = $model->object;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return (new Query())
                ->from($object->eav_table_name)
                ->select(Property::tableName() . '.id, ' . $object->eav_table_name . '.value')
                ->innerJoin(
                    Property::tableName(),
                    Property::tableName() . '.property_group_id = ' . $object->eav_table_name . '.property_group_id'
                    . ' AND ' . Property::tableName() . '.key = ' . $object->eav_table_name . '.key'
                )
                ->where([
                    'object_model_id' => $model->id,
                    $object->eav_table_name . '.key' => array_column(static::$ymlEavProperties, 'key'),
                    $object->eav_table_name . '.property_group_id' => array_column(static::$ymlEavProperties, 'group_id'),

                    Property::tableName() . '.id' => array_keys(static::$ymlEavProperties),
                ])
                ->andWhere(['<>','value', ''])
                ->all();
        });
        foreach ($eav as $prop) {
            if (false === isset($prop['id'])) {
                continue ;
            }

            $val = htmlspecialchars($prop['value']);
            switch (static::$ymlEavProperties[$prop['id']]['handler_id']) {
                case 3 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
                    $val = $val == 1 ? Yii::t('yii', 'Yes') : Yii::t('yii', 'No');
                    break;
            }
            $_key = static::$ymlEavProperties[$prop['id']]['name'];
            $params[htmlspecialchars(trim($_key))] = [
                'unit' => false === empty(static::$ymlEavProperties[$prop['id']]['unit'])
                    ? htmlspecialchars(trim(static::$ymlEavProperties[$prop['id']]['unit']))
                    : null,
                'value' => $val,
            ];
        }

        $psv = Yii::$app->getDb()->cache(function ($db) use ($model) {

            return  (new Query())
                ->from(PropertyStaticValues::tableName())
                ->innerJoin(
                    ObjectStaticValues::tableName(),
                    ObjectStaticValues::tableName() . '.property_static_value_id = ' . PropertyStaticValues::tableName() . '.id'

                )
                ->where([
                    'object_model_id' => $model->id,
                    'object_id' => $model->object->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'property_id' => array_keys(static::$ymlStaticProperties)
                ])
                ->andWhere(['<>','value', ''])
                ->all();
        });
        foreach ($psv as $prop) {
            if (false === isset($prop['property_id'])) {
                continue ;
            }

            $_key = static::$ymlStaticProperties[$prop['property_id']]['name'];
            $params[htmlspecialchars(trim($_key))] = [
                'unit' => false === empty(static::$ymlStaticProperties[$prop['property_id']]['unit'])
                    ? htmlspecialchars(trim(static::$ymlStaticProperties[$prop['property_id']]['unit']))
                    : null,
                'value' => htmlspecialchars(trim($prop['value'])),
            ];
        }

        return $params;
    }

    /**
     * @param YmlModel $config
     * @return array
     */
    private function generateSectionShop(YmlModel $config)
    {
        return [
            'name' => $config->shop_name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'company' => $config->shop_company,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'url' => $config->shop_url,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'currency' => $this->currency->iso_code,
            'categories' => Category::find()->where(['active' => 1])->asArray(),
            'store' => static::USE_STORE == $config->shop_store ? 'true' : 'false',
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'pickup' => static::USE_PICKUP == $config->shop_pickup ? 'true' : 'false',
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'delivery' => static::USE_DELIVERY == $config->shop_delivery ? 'true' : 'false',
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'local_delivery_cost' => $config->shop_local_delivery_cost,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'adult' => static::USE_ADULT == $config->shop_adult ? 'true' : 'false',
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        ];
    }

    /**
     * @param YmlModel $config
     * @param Product $model
     * @return null|array

     */
    private function generateSingleOffer(YmlModel $config, Product $model)
    {
        $result = $this->offerSimplified($config, $model);
        if (null === $result) {
            return null;
        }

        return [
            'model' => $model,
            'result' => $result,
        ];
    }

    /**
     * @param YmlModel $config
     * @param Product $model
     * @return OfferTag|null
     */
    private function offerSimplified(YmlModel $config, Product $model)
    {
        $offer = new OfferTag('offer', [], ['id' => $model->id, 'available' => 'true',]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $price = static::getOfferValue($config, 'offer_price', $model, 0);
        $price = CurrencyHelper::convertCurrencies($price, $model->currency, $this->currency);

        if ($price <= 0 || $price >= 1000000000) {
            return null;
        }

        $values = [];

        $name = static::getOfferValue($config, 'offer_name', $model, null);
        if (true === empty($name)) {
            return null;
        }
        if (mb_strlen($name) > 120) {
            $name = mb_substr($name, 0, 120);
            $name = mb_substr($name, 0, mb_strrpos($name, ' '));
        }
        $values[] = new OfferTag('name', htmlspecialchars(trim(strip_tags($name))));
        $values[] = new OfferTag('price', $price);
        $values[] = new OfferTag('currencyId', $this->currency->iso_code);

        /** @var Category $category */
        if (null === $category = $model->category) {
            return null;
        }
        $values[] = new OfferTag('categoryId', $category->id);
        $values[] = new OfferTag('url', Url::toRoute([
            '@product',
            'model' => $model,
            'category_group_id' => $category->category_group_id,
        ], true));

        $picture = static::getOfferValue($config, 'offer_picture', $model, static::$_noImg);
        if (static::$_noImg !== $picture) {
            $picture = htmlspecialchars(trim($picture, '/'));
            $picture = implode('/', array_map('rawurlencode', explode('/', $picture)));
            $values[] = new OfferTag('picture', trim($config->shop_url, '/') . '/' . $picture);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        $description = static::getOfferValue($config, 'offer_description', $model, null);

        if (false === empty($description)) {
            $description = preg_replace("/([\r\n\t])/", ' ', $description);
            $description = preg_replace("/[ ]{2,}/", '', $description);
            $description = htmlspecialchars(trim(strip_tags($description)));

            if (mb_strlen($description) > 175) {
                $description = mb_substr($description, 0, 175);
                $description = mb_substr($description, 0, mb_strrpos($description, ' '));
            }

            $values[] = new OfferTag('description', $description);
        }

        if (static::USE_OFFER_PARAM == $config->offer_param) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            foreach (static::getOfferParams($model) as $k => $v) {
                $values[] = new OfferTag('param', $v['value'], ['name' => $k, 'unit' => $v['unit']]);
            }
        }

        return $offer->setValue($values);
    }
}

GitHub Access Token became invalid

Push — master ( c721cc...3ff35f )

Yml::prepareProperties() D

Complexity

Size

Duplication

Importance

Available Fixes

1			<?php
2			namespace app\modules\shop\components\yml;
3
4			use app\models\ObjectStaticValues;
5			use app\models\Property;
6			use app\models\PropertyStaticValues;
7			use app\modules\shop\events\yml\YmlOffersEvent;
8			use app\modules\shop\helpers\CurrencyHelper;
9			use app\modules\shop\models\Category;
10			use app\modules\shop\models\Currency;
11			use app\modules\shop\models\Product;
12			use devgroup\TagDependencyHelper\ActiveRecordHelper;
13			use Yii;
14			use yii\base\Component;
15			use app\modules\shop\models\Yml as YmlModel;
16			use yii\caching\TagDependency;
17			use yii\db\Query;
18			use yii\helpers\Json;
19			use yii\helpers\Url;
20			use yii\web\View;
21
22			class Yml extends Component
23			{
24			const PARAM_TYPE_FIELD = 'field';
25			const PARAM_TYPE_RELATION = 'relation';
26			const USE_GZIP = 1;
27			const USE_OFFER_PARAM = 1;
28			const USE_ADULT = 1;
29			const USE_STORE = 1;
30			const USE_PICKUP = 1;
31			const USE_DELIVERY = 1;
32
33			const EVENT_PROCESS_OFFER = 'ymlProcessOffer';
34
35			/**
36			* @property \app\modules\shop\models\Yml $model
37			* @property string $viewFile
38			* @property Currency $currency
39			*/
40			protected $model = null;
DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — master ( c721cc...3ff35f )

Yml::prepareProperties() D

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like
