User - Code Metrics - Inspection of "[Feature] ability to change product class" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c721cc...3ff35f )

by Ivan

created 2017-03-17 10:40 UTC

User B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	373
Duplicated Lines	5.09 %

Coupling/Cohesion

Components	6
Dependencies	10

Importance

Changes

Metric	Value
wmc	34
lcom	6
cbo	10
dl	19
loc	373
rs	8.3636
c	0
b	0
f	0

25 Methods

Rating	Name	Duplication	Size	Complexity
B	rules()	0	27	1
A	scenarios()	0	18	1
A	tableName()	0	4	1
A	attributeLabels()	0	18	1
A	getStatuses()	0	7	1
A	behaviors()	0	16	1
A	findIdentityByAccessToken()	0	5	1
B	findIdentity()	19	30	4
A	findByUsername()	0	4	1
A	findByPasswordResetToken()	0	11	2
A	isPasswordResetTokenValid()	0	10	2
A	getId()	0	4	1
A	getAuthKey()	0	4	1
A	validateAuthKey()	0	4	1
A	validatePassword()	0	4	1
A	setPassword()	0	4	1
A	generateAuthKey()	0	4	1
A	generatePasswordResetToken()	0	4	1
A	removePasswordResetToken()	0	4	1
A	afterSave()	0	17	2
A	getPropertyIdsForUsers()	0	16	1
A	gravatar()	0	5	1
A	getServices()	0	4	1
A	getDisplayName()	0	5	2
A	beforeSave()	0	10	3

How to fix Duplicated Code

<?php

namespace app\modules\user\models;

use app\modules\shop\models\Customer;
use app\properties\HasProperties;
use app\models\PropertyGroup;
use app\models\ObjectPropertyGroup;

use devgroup\TagDependencyHelper\ActiveRecordHelper;
use Yii;
use yii\base\NotSupportedException;
use yii\behaviors\TimestampBehavior;
use yii\caching\TagDependency;
use yii\db\ActiveRecord;
use yii\web\IdentityInterface;

/**
 * Class User
 * @package app\models
 *
 * @property integer $id
 * @property string $username
 * @property string $password_hash
 * @property string $password_reset_token
 * @property string $email
 * @property string $auth_key
 * @property integer $status
 * @property integer $create_time
 * @property integer $update_time
 * @property string $first_name
 * @property string $last_name
 * @property \app\modules\user\models\UserService[] $services
 * @property string $displayName  Display name for the user visual identification
 * Relations:
 */
class User extends ActiveRecord implements IdentityInterface
{
    const STATUS_DELETED = 0;
    const STATUS_ACTIVE = 10;
    const USER_GUEST = 0;

    public $confirmPassword;
    public $newPassword;
    public $password;

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            ['status', 'default', 'value' => self::STATUS_ACTIVE],
            ['status', 'in', 'range' => [self::STATUS_ACTIVE, self::STATUS_DELETED]],

            ['username', 'filter', 'filter' => 'trim'],
            ['username', 'required'],
            ['username', 'string', 'min' => 2, 'max' => 255],
            ['username', 'unique'],

            ['email', 'filter', 'filter' => 'trim'],
            ['email', 'required', 'except' => ['registerService']],
            ['email', 'email'],
            ['email', 'unique', 'message' => Yii::t('app', 'This email address has already been taken.')],
            ['email', 'exist', 'message' => Yii::t('app', 'There is no user with such email.'), 'on' => 'requestPasswordResetToken'],


            ['password', 'required', 'on' => ['adminSignup', 'changePassword']],
            ['password', 'string', 'min' => 8],
            [['first_name', 'last_name',], 'string', 'max' => 255],

            // change password
            [['newPassword', 'confirmPassword'], 'required'],
            [['newPassword', 'confirmPassword'], 'string', 'min' => 8],
            [['confirmPassword'], 'compare', 'compareAttribute' => 'newPassword'],
        ];
    }

    /**
     * @inheritdoc
     */
    public function scenarios()
    {
        return [
            'signup' => ['username', 'email', 'password', 'first_name', 'last_name'],
            'resetPassword' => ['password_hash', 'password_reset_token'],
            'requestPasswordResetToken' => ['email'],

            'registerService' => ['email', 'first_name', 'last_name'],
            'updateProfile' => ['email', 'first_name', 'last_name'],
            'completeRegistration' => ['first_name', 'last_name', 'username', 'email'],
            'changePassword' => ['password', 'newPassword', 'confirmPassword'],
            // admin
            'search' => ['id', 'username', 'email', 'status', 'create_time', 'first_name', 'last_name'],
            'admin' => ['username', 'status', 'email', 'password', 'first_name', 'last_name'],
            'adminSignup' => ['username', 'status', 'email', 'password', 'first_name', 'last_name', 'auth_key'],
            'passwordResetToken' => ['password_reset_token'],
        ];
    }

    /**
     * @inheritdoc
     */
    public static function tableName()
    {
        return '{{%user}}';
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'id' => Yii::t('app', 'ID'),
            'username' => Yii::t('app', 'Username'),
            'auth_key' => Yii::t('app', 'Auth Key'),
            'password' => Yii::t('app', 'Password'),
            'password_reset_token' => Yii::t('app', 'Password Reset Token'),
            'email' => Yii::t('app', 'E-mail'),
            'status' => Yii::t('app', 'Status'),
            'create_time' => Yii::t('app', 'Create Time'),
            'update_time' => Yii::t('app', 'Update Time'),
            'first_name' => Yii::t('app', 'First Name'),
            'last_name' => Yii::t('app', 'Last Name'),
            'newPassword' => Yii::t('app', 'New Password'),
            'confirmPassword' => Yii::t('app', 'Confirm Password'),
        ];
    }

    /**
     * @return array List of all possible statuses for User instance

     */
    public static function getStatuses()
    {
        return [
            self::STATUS_ACTIVE => Yii::t('app', 'Active'),
            self::STATUS_DELETED => Yii::t('app', 'Deleted'),
        ];
    }

    /**
     * @inheritdoc
     */
    public function behaviors()
    {
        return [
            [
                'class' => TimestampBehavior::className(),
                'createdAtAttribute' => 'create_time',
                'updatedAtAttribute' => 'update_time',
            ],
            [
                'class' => \devgroup\TagDependencyHelper\ActiveRecordHelper::className(),
            ],
            [
                'class' => HasProperties::className(),
            ],
        ];
    }

    /**
     * @inheritdoc
     */
    public static function findIdentityByAccessToken($token, $type = null)
    {
        // see https://github.com/yiisoft/yii2/issues/2689
        throw new NotSupportedException('"findIdentityByAccessToken" is not implemented.');
    }

    /**
     * Finds an identity by the given ID.
     *
     * @param string|integer $id the ID to be looked for
     * @return IdentityInterface|null the identity object that matches the given ID.
     */
    public static function findIdentity($id)
    {

        if (is_numeric($id)) {
            $model = Yii::$app->cache->get("User:$id");
            if ($model === false) {
                $model = static::find()
                    ->with('services')
                    ->where('id=:id', [':id'=>$id])
                    ->one();
                if ($model !== null) {
                    Yii::$app->cache->set(
                        "User:$id",
                        $model,
                        3600,
                        new TagDependency([
                            'tags' => [
                                ActiveRecordHelper::getObjectTag($model->className(), $model->id)
                            ]
                        ])
                    );
                }

            }
            return $model;
        } else {
            return null;
        }

    }

    /**
     * Finds user by username
     *
     * @param string $username
     * @return null|User
     */
    public static function findByUsername($username)
    {
        return static::findOne(['username' => $username, 'status' => static::STATUS_ACTIVE]);
    }

    /**
     * Finds user by password reset token
     *
     * @param string $token password reset token
     * @return User|null
     */
    public static function findByPasswordResetToken($token)
    {
        if (static::isPasswordResetTokenValid($token) === false) {
            return null;
        }

        return static::findOne([
            'password_reset_token' => $token,
            'status' => self::STATUS_ACTIVE,
        ]);
    }

    /**
     * Finds out if password reset token is valid
     *
     * @param string $token password reset token
     * @return boolean
     */
    public static function isPasswordResetTokenValid($token)
    {
        if (empty($token) === true) {
            return false;
        }
        $expire = Yii::$app->modules['user']->passwordResetTokenExpire;
        $parts = explode('_', $token);
        $timestamp = (int) end($parts);
        return $timestamp + $expire >= time();
    }

    /**
     * @return int|string current user ID
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return string current user auth key
     */
    public function getAuthKey()
    {
        return $this->auth_key;
    }

    /**
     * @param string $authKey
     * @return boolean if auth key is valid for current user
     */
    public function validateAuthKey($authKey)
    {
        return $this->getAuthKey() === $authKey;
    }

    /**
     * @param string $password password to validate
     * @return bool if password provided is valid for current user
     */
    public function validatePassword($password)
    {
        return Yii::$app->security->validatePassword($password, $this->password_hash);
    }

    /**
     * Generates password hash from password and sets it to the model
     *
     * @param string $password
     */
    public function setPassword($password)
    {
        $this->password_hash = Yii::$app->security->generatePasswordHash($password);
    }

    /**
     * Generates "remember me" authentication key
     */
    public function generateAuthKey()
    {
        $this->auth_key = Yii::$app->security->generateRandomString();
    }

    /**
     * Generates new password reset token
     */
    public function generatePasswordResetToken()
    {
        $this->password_reset_token = Yii::$app->security->generateRandomString() . '_' . time();
    }

    /**
     * Removes password reset token
     */
    public function removePasswordResetToken()
    {
        $this->password_reset_token = null;
    }


    /**
     * @param bool $insert
     * @param array $changedAttributes
     */
    public function afterSave($insert, $changedAttributes)
    {
        parent::afterSave($insert, $changedAttributes);

        // save bindings to property groups for properties support

        $ids = $this->getPropertyIdsForUsers();

        $currentGroups = array_keys($this->getPropertyGroups());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $newIds = array_diff($ids, $currentGroups);

        foreach ($newIds as $group_id) {
            $this->addPropertyGroup($group_id, false);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
        $this->updatePropertyGroupsInformation();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * Returns array of ids of propertyGroups for user model
     * @return array
     * @throws \Exception
     */
    private function getPropertyIdsForUsers()
    {
        return PropertyGroup::getDb()->cache(
            function ($db) {
                return PropertyGroup::find()
                    ->select('id')
                    ->where(['object_id' => $this->getObject()->id])
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    ->asArray()
                    ->column($db);
            },
            86400,
            new TagDependency([
                'tags' => ActiveRecordHelper::getCommonTag(PropertyGroup::className())
            ])
        );
    }


    /**
     * Returns gravatar image link for user
     * @param int $size Avatar size in pixels
     * @return string
     */
    public function gravatar($size = 40)
    {
        $hash = md5(strtolower(trim($this->email)));
        return '//www.gravatar.com/avatar/' . $hash . '?s=' . $size;
    }

    /**
     * Relation to UserService model describing social services available exact user to login
     * @return \yii\db\ActiveQuery
     */
    public function getServices()
    {
        return $this->hasMany(UserService::className(), ['user_id' => 'id']);
    }

    /**
     * @return mixed|string Display name for the user visual identification

     */
    public function getDisplayName()
    {
        $name = trim($this->first_name . ' ' . $this->last_name);
        return $name ? $name : $this->username;
    }

    /**
     * @inheritdoc
     */
    public function beforeSave($insert)
    {
        if (!parent::beforeSave($insert)) {
            return false;
        }
        if ($insert) {
            $this->setPassword($this->password);
        }
        return true;
    }
}


1		<?php
2
3		namespace app\modules\user\models;
4
5		use app\modules\shop\models\Customer;
6		use app\properties\HasProperties;
7		use app\models\PropertyGroup;
8		use app\models\ObjectPropertyGroup;
9
10		use devgroup\TagDependencyHelper\ActiveRecordHelper;
11		use Yii;
12		use yii\base\NotSupportedException;
13		use yii\behaviors\TimestampBehavior;
14		use yii\caching\TagDependency;
15		use yii\db\ActiveRecord;
16		use yii\web\IdentityInterface;
17
18		/**
19		* Class User
20		* @package app\models
21		*
22		* @property integer $id
23		* @property string $username
24		* @property string $password_hash
25		* @property string $password_reset_token
26		* @property string $email
27		* @property string $auth_key
28		* @property integer $status
29		* @property integer $create_time
30		* @property integer $update_time
31		* @property string $first_name
32		* @property string $last_name
33		* @property \app\modules\user\models\UserService[] $services
34		* @property string $displayName Display name for the user visual identification
35		* Relations:
36		*/
37		class User extends ActiveRecord implements IdentityInterface
38		{
39		const STATUS_DELETED = 0;
40		const STATUS_ACTIVE = 10;
41		const USER_GUEST = 0;
42
43		public $confirmPassword;
44		public $newPassword;
45		public $password;
46
47		/**
48		* @inheritdoc
49		*/
50		public function rules()
51		{
52		return [
53		['status', 'default', 'value' => self::STATUS_ACTIVE],
54		['status', 'in', 'range' => [self::STATUS_ACTIVE, self::STATUS_DELETED]],
55
56		['username', 'filter', 'filter' => 'trim'],
57		['username', 'required'],
58		['username', 'string', 'min' => 2, 'max' => 255],
59		['username', 'unique'],
60
61		['email', 'filter', 'filter' => 'trim'],
62		['email', 'required', 'except' => ['registerService']],
63		['email', 'email'],
64		['email', 'unique', 'message' => Yii::t('app', 'This email address has already been taken.')],
65		['email', 'exist', 'message' => Yii::t('app', 'There is no user with such email.'), 'on' => 'requestPasswordResetToken'],
		0 ignored issues – show Coding Style introduced 2016-02-05 12:50 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 133 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
66
67		['password', 'required', 'on' => ['adminSignup', 'changePassword']],
68		['password', 'string', 'min' => 8],
69		[['first_name', 'last_name',], 'string', 'max' => 255],
70
71		// change password
72		[['newPassword', 'confirmPassword'], 'required'],
73		[['newPassword', 'confirmPassword'], 'string', 'min' => 8],
74		[['confirmPassword'], 'compare', 'compareAttribute' => 'newPassword'],
75		];
76		}
77
78		/**
79		* @inheritdoc
80		*/
81		public function scenarios()
82		{
83		return [
84		'signup' => ['username', 'email', 'password', 'first_name', 'last_name'],
85		'resetPassword' => ['password_hash', 'password_reset_token'],
86		'requestPasswordResetToken' => ['email'],
87
88		'registerService' => ['email', 'first_name', 'last_name'],
89		'updateProfile' => ['email', 'first_name', 'last_name'],
90		'completeRegistration' => ['first_name', 'last_name', 'username', 'email'],
91		'changePassword' => ['password', 'newPassword', 'confirmPassword'],
92		// admin
93		'search' => ['id', 'username', 'email', 'status', 'create_time', 'first_name', 'last_name'],
94		'admin' => ['username', 'status', 'email', 'password', 'first_name', 'last_name'],
95		'adminSignup' => ['username', 'status', 'email', 'password', 'first_name', 'last_name', 'auth_key'],
96		'passwordResetToken' => ['password_reset_token'],
97		];
98		}
99
100		/**
101		* @inheritdoc
102		*/
103		public static function tableName()
104		{
105		return '{{%user}}';
106		}
107
108		/**
109		* @inheritdoc
110		*/
111		public function attributeLabels()
112		{
113		return [
114		'id' => Yii::t('app', 'ID'),
115		'username' => Yii::t('app', 'Username'),
116		'auth_key' => Yii::t('app', 'Auth Key'),
117		'password' => Yii::t('app', 'Password'),
118		'password_reset_token' => Yii::t('app', 'Password Reset Token'),
119		'email' => Yii::t('app', 'E-mail'),
120		'status' => Yii::t('app', 'Status'),
121		'create_time' => Yii::t('app', 'Create Time'),
122		'update_time' => Yii::t('app', 'Update Time'),
123		'first_name' => Yii::t('app', 'First Name'),
124		'last_name' => Yii::t('app', 'Last Name'),
125		'newPassword' => Yii::t('app', 'New Password'),
126		'confirmPassword' => Yii::t('app', 'Confirm Password'),
127		];
128		}
129
130		/**
131		* @return array List of all possible statuses for User instance
		0 ignored issues – show Documentation introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `string[]`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
132		*/
133		public static function getStatuses()
134		{
135		return [
136		self::STATUS_ACTIVE => Yii::t('app', 'Active'),
137		self::STATUS_DELETED => Yii::t('app', 'Deleted'),
138		];
139		}
140
141		/**
142		* @inheritdoc
143		*/
144		public function behaviors()
145		{
146		return [
147		[
148		'class' => TimestampBehavior::className(),
149		'createdAtAttribute' => 'create_time',
150		'updatedAtAttribute' => 'update_time',
151		],
152		[
153		'class' => \devgroup\TagDependencyHelper\ActiveRecordHelper::className(),
154		],
155		[
156		'class' => HasProperties::className(),
157		],
158		];
159		}
160
161		/**
162		* @inheritdoc
163		*/
164		public static function findIdentityByAccessToken($token, $type = null)
165		{
166		// see https://github.com/yiisoft/yii2/issues/2689
167		throw new NotSupportedException('"findIdentityByAccessToken" is not implemented.');
168		}
169
170		/**
171		* Finds an identity by the given ID.
172		*
173		* @param string\|integer $id the ID to be looked for
174		* @return IdentityInterface\|null the identity object that matches the given ID.
175		*/
176		public static function findIdentity($id)
177		{
178
179		if (is_numeric($id)) {
180		$model = Yii::$app->cache->get("User:$id");
181	View Code Duplication	if ($model === false) {
182		$model = static::find()
183		->with('services')
184		->where('id=:id', [':id'=>$id])
185		->one();
186		if ($model !== null) {
187		Yii::$app->cache->set(
188		"User:$id",
189		$model,
190		3600,
191		new TagDependency([
192		'tags' => [
193		ActiveRecordHelper::getObjectTag($model->className(), $model->id)
194		]
195		])
196		);
197		}
198
199		}
200		return $model;
201		} else {
202		return null;
203		}
204
205		}
206
207		/**
208		* Finds user by username
209		*
210		* @param string $username
211		* @return null\|User
212		*/
213		public static function findByUsername($username)
214		{
215		return static::findOne(['username' => $username, 'status' => static::STATUS_ACTIVE]);
216		}
217
218		/**
219		* Finds user by password reset token
220		*
221		* @param string $token password reset token
222		* @return User\|null
223		*/
224		public static function findByPasswordResetToken($token)
225		{
226		if (static::isPasswordResetTokenValid($token) === false) {
227		return null;
228		}
229
230		return static::findOne([
231		'password_reset_token' => $token,
232		'status' => self::STATUS_ACTIVE,
233		]);
234		}
235
236		/**
237		* Finds out if password reset token is valid
238		*
239		* @param string $token password reset token
240		* @return boolean
241		*/
242		public static function isPasswordResetTokenValid($token)
243		{
244		if (empty($token) === true) {
245		return false;
246		}
247		$expire = Yii::$app->modules['user']->passwordResetTokenExpire;
248		$parts = explode('_', $token);
249		$timestamp = (int) end($parts);
250		return $timestamp + $expire >= time();
251		}
252
253		/**
254		* @return int\|string current user ID
255		*/
256		public function getId()
257		{
258		return $this->id;
259		}
260
261		/**
262		* @return string current user auth key
263		*/
264		public function getAuthKey()
265		{
266		return $this->auth_key;
267		}
268
269		/**
270		* @param string $authKey
271		* @return boolean if auth key is valid for current user
272		*/
273		public function validateAuthKey($authKey)
274		{
275		return $this->getAuthKey() === $authKey;
276		}
277
278		/**
279		* @param string $password password to validate
280		* @return bool if password provided is valid for current user
281		*/
282		public function validatePassword($password)
283		{
284		return Yii::$app->security->validatePassword($password, $this->password_hash);
285		}
286
287		/**
288		* Generates password hash from password and sets it to the model
289		*
290		* @param string $password
291		*/
292		public function setPassword($password)
293		{
294		$this->password_hash = Yii::$app->security->generatePasswordHash($password);
295		}
296
297		/**
298		* Generates "remember me" authentication key
299		*/
300		public function generateAuthKey()
301		{
302		$this->auth_key = Yii::$app->security->generateRandomString();
303		}
304
305		/**
306		* Generates new password reset token
307		*/
308		public function generatePasswordResetToken()
309		{
310		$this->password_reset_token = Yii::$app->security->generateRandomString() . '_' . time();
311		}
312
313		/**
314		* Removes password reset token
315		*/
316		public function removePasswordResetToken()
317		{
318		$this->password_reset_token = null;
319		}
320
321
322		/**
323		* @param bool $insert
324		* @param array $changedAttributes
325		*/
326		public function afterSave($insert, $changedAttributes)
327		{
328		parent::afterSave($insert, $changedAttributes);
329
330		// save bindings to property groups for properties support
331
332		$ids = $this->getPropertyIdsForUsers();
333
334		$currentGroups = array_keys($this->getPropertyGroups());
		0 ignored issues – show Documentation Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `getPropertyGroups` does not exist on `object<app\modules\user\models\User>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
335
336		$newIds = array_diff($ids, $currentGroups);
337
338		foreach ($newIds as $group_id) {
339		$this->addPropertyGroup($group_id, false);
		0 ignored issues – show Documentation Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `addPropertyGroup` does not exist on `object<app\modules\user\models\User>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
340		}
341		$this->updatePropertyGroupsInformation();
		0 ignored issues – show Documentation Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `updatePropertyGroupsInformation` does not exist on `object<app\modules\user\models\User>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
342		}
343
344		/**
345		* Returns array of ids of propertyGroups for user model
346		* @return array
347		* @throws \Exception
348		*/
349		private function getPropertyIdsForUsers()
350		{
351		return PropertyGroup::getDb()->cache(
352		function ($db) {
353		return PropertyGroup::find()
354		->select('id')
355		->where(['object_id' => $this->getObject()->id])
		0 ignored issues – show Documentation Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `getObject` does not exist on `object<app\modules\user\models\User>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
356		->asArray()
357		->column($db);
358		},
359		86400,
360		new TagDependency([
361		'tags' => ActiveRecordHelper::getCommonTag(PropertyGroup::className())
362		])
363		);
364		}
365
366
367		/**
368		* Returns gravatar image link for user
369		* @param int $size Avatar size in pixels
370		* @return string
371		*/
372		public function gravatar($size = 40)
373		{
374		$hash = md5(strtolower(trim($this->email)));
375		return '//www.gravatar.com/avatar/' . $hash . '?s=' . $size;
376		}
377
378		/**
379		* Relation to UserService model describing social services available exact user to login
380		* @return \yii\db\ActiveQuery
381		*/
382		public function getServices()
383		{
384		return $this->hasMany(UserService::className(), ['user_id' => 'id']);
385		}
386
387		/**
388		* @return mixed\|string Display name for the user visual identification
		0 ignored issues – show Documentation introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `string`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
389		*/
390		public function getDisplayName()
391		{
392		$name = trim($this->first_name . ' ' . $this->last_name);
393		return $name ? $name : $this->username;
394		}
395
396		/**
397		* @inheritdoc
398		*/
399		public function beforeSave($insert)
400		{
401		if (!parent::beforeSave($insert)) {
402		return false;
403		}
404		if ($insert) {
405		$this->setPassword($this->password);
406		}
407		return true;
408		}
409		}
410

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — master ( c721cc...3ff35f )

User B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

25 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like