WysiwygController - Code Metrics - Inspection of "Wysiwyg editors Controller" - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — filters ( 8094dd...b8aa76 )

unknown

created 2015-12-17 10:55 UTC

WysiwygController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	120
Duplicated Lines	16.67 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	13
lcom	1
cbo	2
dl	20
loc	120
rs	10
c	1
b	0
f	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	behaviors()	0	20	1
A	actionIndex()	10	10	1
A	actionView()	0	6	1
A	actionCreate()	0	12	3
A	actionUpdate()	10	15	4
A	actionDelete()	0	6	1
A	findModel()	0	8	2

How to fix Duplicated Code

<?php

namespace app\modules\core\backend;

use app\backend\components\BackendController;
use app\modules\core\models\Wysiwyg;
use yii\filters\AccessControl;
use yii\filters\VerbFilter;
use Yii;
use yii\web\NotFoundHttpException;

class WysiwygController extends BackendController
{
    public function behaviors()
    {
        return [
            'access' => [
                'class' => AccessControl::className(),
                'rules' => [
                    [
                        'allow' => true,
                        'roles' => ['administrate'],
                    ],
                ],
            ],
            'verbs' => [
                'class' => VerbFilter::className(),
                'actions' => [
                    'delete' => ['POST'],
                ],
            ],
        ];
    }


    /**
     * Lists all Wysiwyg models.
     * @return mixed
     */
    public function actionIndex()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $searchModel = new Wysiwyg(['scenario' => 'search']);
        $dataProvider = $searchModel->search($_GET);

        return $this->render('index', [
            'dataProvider' => $dataProvider,
            'searchModel' => $searchModel
        ]);
    }

    /**
     * Displays a single Wysiwyg model.
     * @param integer $id
     * @return mixed
     */
    public function actionView($id)
    {
        return $this->render('view', [
            'model' => $this->findModel($id),
        ]);
    }

    /**
     * Creates a new Wysiwyg model.
     * If creation is successful, the browser will be redirected to the 'view' page.
     * @return mixed
     */
    public function actionCreate()
    {
        $model = new Wysiwyg();

        if ($model->load(\Yii::$app->request->post()) && $model->save()) {
            return $this->redirect(['view', 'id' => $model->id]);
        } else {
            return $this->render('create', [
                'model' => $model,
            ]);
        }
    }

    /**
     * Updates an existing Wysiwyg model.
     * If update is successful, the browser will be redirected to the 'view' page.
     * @param integer $id
     * @return mixed
     */
    public function actionUpdate($id, $returnUrl = null)
    {
        $model = $this->findModel($id);

        if ($model->load(Yii::$app->request->post()) && $model->save()) {

            if ($returnUrl !== null) {
                return $this->redirect($returnUrl);
            }
            return $this->redirect(['view', 'id' => $model->id]);
        } else {
            return $this->render('update', [
                'model' => $model,
            ]);
        }
    }

    /**
     * Deletes an existing Wysiwyg model.
     * If deletion is successful, the browser will be redirected to the 'index' page.
     * @param integer $id
     * @return mixed
     */
    public function actionDelete($id)
    {
        $this->findModel($id)->delete();

        return $this->redirect(['index']);
    }

    /**
     * Finds the Wysiwyg model based on its primary key value.
     * If the model is not found, a 404 HTTP exception will be thrown.
     * @param integer $id
     * @return Wysiwyg the loaded model
     * @throws NotFoundHttpException if the model cannot be found
     */
    protected function findModel($id)
    {
        if (($model = Wysiwyg::findOne($id)) !== null) {
            return $model;
        } else {
            throw new NotFoundHttpException('The requested page does not exist.');
        }
    }
}


1		<?php
2
3		namespace app\modules\core\backend;
4
5		use app\backend\components\BackendController;
6		use app\modules\core\models\Wysiwyg;
7		use yii\filters\AccessControl;
8		use yii\filters\VerbFilter;
9		use Yii;
10		use yii\web\NotFoundHttpException;
11
12		class WysiwygController extends BackendController
13		{
14		public function behaviors()
15		{
16		return [
17		'access' => [
18		'class' => AccessControl::className(),
19		'rules' => [
20		[
21		'allow' => true,
22		'roles' => ['administrate'],
23		],
24		],
25		],
26		'verbs' => [
27		'class' => VerbFilter::className(),
28		'actions' => [
29		'delete' => ['POST'],
30		],
31		],
32		];
33		}
34
35
36		/**
37		* Lists all Wysiwyg models.
38		* @return mixed
39		*/
40	View Code Duplication	public function actionIndex()
		1 ignored issue – show Duplication introduced 2015-12-17 11:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2015-12-17 11:12 UTC by Report Bug Copy Issue Report `actionIndex` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
41		{
42		$searchModel = new Wysiwyg(['scenario' => 'search']);
43		$dataProvider = $searchModel->search($_GET);
44
45		return $this->render('index', [
46		'dataProvider' => $dataProvider,
47		'searchModel' => $searchModel
48		]);
49		}
50
51		/**
52		* Displays a single Wysiwyg model.
53		* @param integer $id
54		* @return mixed
55		*/
56		public function actionView($id)
57		{
58		return $this->render('view', [
59		'model' => $this->findModel($id),
60		]);
61		}
62
63		/**
64		* Creates a new Wysiwyg model.
65		* If creation is successful, the browser will be redirected to the 'view' page.
66		* @return mixed
67		*/
68		public function actionCreate()
69		{
70		$model = new Wysiwyg();
71
72		if ($model->load(\Yii::$app->request->post()) && $model->save()) {
73		return $this->redirect(['view', 'id' => $model->id]);
74		} else {
75		return $this->render('create', [
76		'model' => $model,
77		]);
78		}
79		}
80
81		/**
82		* Updates an existing Wysiwyg model.
83		* If update is successful, the browser will be redirected to the 'view' page.
84		* @param integer $id
85		* @return mixed
86		*/
87		public function actionUpdate($id, $returnUrl = null)
88		{
89		$model = $this->findModel($id);
90
91	View Code Duplication	if ($model->load(Yii::$app->request->post()) && $model->save()) {
		1 ignored issue – show Duplication introduced 2015-12-17 11:12 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
92		if ($returnUrl !== null) {
93		return $this->redirect($returnUrl);
94		}
95		return $this->redirect(['view', 'id' => $model->id]);
96		} else {
97		return $this->render('update', [
98		'model' => $model,
99		]);
100		}
101		}
102
103		/**
104		* Deletes an existing Wysiwyg model.
105		* If deletion is successful, the browser will be redirected to the 'index' page.
106		* @param integer $id
107		* @return mixed
108		*/
109		public function actionDelete($id)
110		{
111		$this->findModel($id)->delete();
112
113		return $this->redirect(['index']);
114		}
115
116		/**
117		* Finds the Wysiwyg model based on its primary key value.
118		* If the model is not found, a 404 HTTP exception will be thrown.
119		* @param integer $id
120		* @return Wysiwyg the loaded model
121		* @throws NotFoundHttpException if the model cannot be found
122		*/
123		protected function findModel($id)
124		{
125		if (($model = Wysiwyg::findOne($id)) !== null) {
126		return $model;
127		} else {
128		throw new NotFoundHttpException('The requested page does not exist.');
129		}
130		}
131		}
132

DevGroup-ru / dotplant2

GitHub Access Token became invalid

Push — filters ( 8094dd...b8aa76 )

WysiwygController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like