app\traits\SortModels

Complexity

Total Complexity

6

Size/Duplication

Total Lines	55
Duplicated Lines	49.09 %

Coupling/Cohesion

Components	0
Dependencies	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	sortModels()	19	19	2
A	generateCase()	8	8	2
A	moveIdBefore()	0	7	1
A	moveIdAfter()	0	7	1

<?php

namespace app\traits;

use yii;

/**
 * Trait for sorting models, that use app\behaviors\Sortable
 */
trait SortModels
{
    /**
     * Sort records by their id list.
     * Note: you must manually call refresh() on needed models
     * @param array $ids array of records id in needed order(ie. [4, 3, 1, 2])
     * @param string $field Field that stores sort order
     * @return bool
     * @throws yii\db\Exception
     */
    public static function sortModels($ids, $field = 'sort_order')
    {
        $priorities = [];
        $start=0;
        $ids_sorted = $ids;
        sort($ids_sorted);
        foreach ($ids as $id) {
            $priorities[$id] = $ids_sorted[$start++];
        }
        $sql = "UPDATE "
            . static::tableName()
            . " SET $field = "
            . static::generateCase($priorities)
            . " WHERE id IN(" . implode(', ', $ids)
            . ")";
        return Yii::$app->db->createCommand(
            $sql
        )->execute() > 0;
    }

    public static function generateCase($priorities)
    {
        $result = 'CASE `id`';
        foreach ($priorities as $k => $v) {
            $result .= ' when "' . $k . '" then "' . $v . '"';
        }
        return $result . ' END';
    }

    public static function moveIdBefore($id, $id_before, $field = 'sort_order')

The return type could not be reliably inferred; please add a @return annotation.

    {
        //! @todo Переписать, чтобы не использовать ActiveRecord, а обходиться обычными запросами в базу(за один запрос можно получить sort_order для двух ID)

Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.

This line exceeds maximum limit of 120 characters; contains 158 characters

        $current_model = static::findOne($id);
        $another_model = static::findOne($id_before);
        return $current_model->moveBefore($another_model, $field);
    }

    public static function moveIdAfter($id, $id_after, $field = 'sort_order')

The return type could not be reliably inferred; please add a @return annotation.

    {
        //! @todo Переписать, чтобы не использовать ActiveRecord, а обходиться обычными запросами в базу(за один запрос можно получить sort_order для двух ID)

Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.

This line exceeds maximum limit of 120 characters; contains 158 characters

        $current_model = static::findOne($id);
        $another_model = static::findOne($id_after);
        return $current_model->moveAfter($another_model, $field);
    }
}