app\backend\controllers\FormController

Complexity

Total Complexity

34

Size/Duplication

Total Lines	271
Duplicated Lines	24.35 %

Coupling/Cohesion

Components	1
Dependencies	16

Importance

Changes	1
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	actionIndex()	13	13	1
D	actionEdit()	7	117	12
B	actionDeleteSubmission()	5	25	6
A	actionRestoreSubmission()	0	12	2
A	actionDelete()	14	14	4
A	actionRemoveAll()	0	12	3
B	actionView()	0	24	1
A	actionViewSubmission()	0	14	2
A	actionDownload()	13	13	2
A	behaviors()	14	14	1

<?php

namespace app\backend\controllers;

use app\models\Form;
use app\models\Object;
use app\models\ObjectPropertyGroup;
use app\models\PropertyGroup;
use app\models\Submission;
use app\properties\DynamicSearchModel;
use Yii;
use yii\db\Query;
use yii\filters\AccessControl;
use yii\helpers\ArrayHelper;
use yii\web\Controller;
use yii\web\NotFoundHttpException;
use yii\helpers\Url;

class FormController extends Controller
{

    public function behaviors()

This method seems to be duplicated in your project.

    {
        return [
            'access' => [
                'class' => AccessControl::className(),
                'rules' => [
                    [
                        'allow' => true,
                        'roles' => ['form manage'],
                    ],
                ],
            ],
        ];
    }

    public function actionIndex()

actionIndex uses the super-global variable $_GET which is generally not recommended.

    {
        $searchModel = new Form();
        $dataProvider = $searchModel->search($_GET);

        return $this->render(
            'index',
            [
                'dataProvider' => $dataProvider,
                'searchModel' => $searchModel,
            ]
        );
    }

    public function actionEdit($id = null)
    {
        $model = new Form();
        if ($id > 0) {
            $model = Form::findOne($id);
        }

        /** @var \app\models\Object $object */
        $object = Object::getForClass(Form::className());

        $propIds = (new Query())->select('property_group_id')->from([ObjectPropertyGroup::tableName()])->where(
            [
                'and',
                'object_id = :object',
                'object_model_id = :id'
            ],
            [
                ':object' => $object->id,

The property id does not exist on object<app\models\Object>. Since you implemented __get, maybe consider adding a @property annotation.

                ':id' => $id
            ]
        )->column();

        $post = \Yii::$app->request->post();
        $properties = isset($post['Form']['properties']) ? $post['Form']['properties'] : [];

        if ($model->load($post) && $model->validate()) {
            if ($model->save()) {
                $id = $model->id;
                $remove = [];
                $add = [];

                foreach ($propIds as $value) {
                    $key = array_search($value, $properties);
                    if ($key === false) {
                        $remove[] = $value;
                    } else {
                        unset($properties[$key]);
                    }
                }
                foreach ($properties as $value) {
                    $add[] = [
                        $value,
                        $object->id,

The property id does not exist on object<app\models\Object>. Since you implemented __get, maybe consider adding a @property annotation.

                        $id
                    ];
                }

                Yii::$app->db->createCommand()->delete(
                    ObjectPropertyGroup::tableName(),
                    [
                        'and',
                        'object_id = :object',
                        'object_model_id = :id',
                        ['in', 'property_group_id', $remove]
                    ],
                    [
                        ':object' => $object->id,

The property id does not exist on object<app\models\Object>. Since you implemented __get, maybe consider adding a @property annotation.

                        ':id' => $id,
                    ]
                )->execute();

                if (!empty($add)) {
                    Yii::$app->db->createCommand()->batchInsert(
                        ObjectPropertyGroup::tableName(),
                        ['property_group_id', 'object_id', 'object_model_id'],
                        $add
                    )->execute();
                }

                \Yii::$app->session->setFlash('info', Yii::t('app', 'Object saved'));
                $returnUrl = Yii::$app->request->get('returnUrl', ['/backend/form/index', 'id' => $model->id]);
                switch (Yii::$app->request->post('action', 'save')) {
                    case 'next':
                        return $this->redirect(
                            [
                                '/backend/form/edit',
                                'returnUrl' => $returnUrl,
                            ]
                        );
                    case 'back':
                        return $this->redirect($returnUrl);
                    default:
                        return $this->redirect(
                            Url::toRoute(
                                [
                                    '/backend/form/edit',
                                    'id' => $model->id,
                                    'returnUrl' => $returnUrl,
                                ]
                            )
                        );
                }
            } else {
                \Yii::$app->session->setFlash('error', Yii::t('app', 'Cannot update data'));
            }
        }

        $items = ArrayHelper::map(
            PropertyGroup::find()->where(
                'object_id = :object',
                [
                    ':object' => $object->id,

The property id does not exist on object<app\models\Object>. Since you implemented __get, maybe consider adding a @property annotation.

                ]
            )->all(),
            'id',
            'name'
        );

        return $this->render(
            'edit',
            [
                'model' => $model,
                'items' => $items,
                'selected' => $propIds,
            ]
        );
    }

    public function actionView($id, $show_deleted = 0)
    {
        $form = Form::findById($id);
        $propertyGroups = $form->getPropertyGroups();

The method getPropertyGroups does not exist on object<app\models\Form>? Since you implemented __call, maybe consider adding a @method annotation.

        $submission = new Submission();

        $dynamicModel = new DynamicSearchModel($submission, $propertyGroups);
        $data = $dynamicModel->search(Yii::$app->request->get());
        $data->query->andWhere('form_id = :form_id', [':form_id' => $form->id]);

The call to QueryInterface::andWhere() has too many arguments starting with array(':form_id' => $form->id).

        $data->query->andWhere(['is_deleted' => $show_deleted]);
        $data->query->andFilterWhere(['sending_status' => $dynamicModel->sending_status]);

The property sending_status does not exist on object<app\properties\DynamicSearchModel>. Since you implemented __get, maybe consider adding a @property annotation.

        $data->query->andFilterWhere(['like', 'ip', $dynamicModel->ip]);

The property ip does not exist on object<app\properties\DynamicSearchModel>. Since you implemented __get, maybe consider adding a @property annotation.

        $data->query->andFilterWhere(['like', 'user_agent', $dynamicModel->user_agent]);

The property user_agent does not exist on object<app\properties\DynamicSearchModel>. Since you implemented __get, maybe consider adding a @property annotation.

        return $this->render(
            'view',
            [
                'searchModel' => $dynamicModel,
                'dataProvider' => $data,
                'form' => $form,
            ]
        );
    }
    
    public function actionViewSubmission($id)
    {
        $submission = Submission::findOne($id);
        if ($submission === null) {
            throw new NotFoundHttpException('Submission not found');
        }

        return $this->render(
            'view-submission',
            [
                'submission' => $submission,
            ]
        );
    }

    public function actionDeleteSubmission($id)
    {
        $submission = Submission::findOne($id);
        $form_id = $submission->form_id;
        if ($submission === null) {
            throw new NotFoundHttpException('Submission not found');
        }
        $res = false;
        if ($submission->is_deleted == 1) {
            if ($submission->delete()) {

The method delete cannot be called on $submission (of type array|boolean).

                $res = true;
            }
        } else {
            $submission->setAttribute('is_deleted', 1);

The method setAttribute cannot be called on $submission (of type array|boolean).

            if ($submission->save()) {

The method save cannot be called on $submission (of type array|boolean).

                $res = true;
            }
        }
        if ($res === false) {
            Yii::$app->session->setFlash('error', Yii::t('app', 'Object not removed'));
        } else {
            Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
        }
        return $this->redirect(Url::toRoute(['view', 'id' => $form_id]));
    }

    public function actionRestoreSubmission($id)
    {
        $submission = Submission::findOne($id);
        if ($submission === null) {
            throw new NotFoundHttpException('Submission not found');
        }
        $submission->setAttribute('is_deleted', 0);

The method setAttribute cannot be called on $submission (of type array|boolean).

        $submission->save();

The method save cannot be called on $submission (of type array|boolean).

        Yii::$app->session->setFlash('success', Yii::t('app', 'Object successfully restored'));

        return $this->redirect(Url::toRoute(['view', 'id' => $submission->form_id]));
    }

    public function actionDownload($key, $submissionId)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $submission = Submission::findOne($submissionId);
        if ($submission === null) {
            throw new NotFoundHttpException('Submission not found');
        }
        $prop = $submission->getPropertyValuesByKey($key);

The method getPropertyValuesByKey cannot be called on $submission (of type array|boolean).

        return \Yii::$app->response->sendFile(
            Yii::getAlias(Yii::$app->getModule('core')->visitorsFileUploadPath) .
            DIRECTORY_SEPARATOR .
            $prop->values[0]['value']
        );
    }

    public function actionDelete($id = null)
    {
        if ((null === $id) || (null === $model = Form::findOne($id))) {
            throw new NotFoundHttpException;
        }

        if (!$model->delete()) {

The method delete cannot be called on $model (of type array|boolean).

            Yii::$app->session->setFlash('error', Yii::t('app', 'Object not removed'));
        } else {
            Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
        }

        return $this->redirect(Url::toRoute('index'));
    }

    public function actionRemoveAll()
    {
        $items = Yii::$app->request->post('items', []);
        if (!empty($items)) {
            $items = Form::find()->where(['in', 'id', $items])->all();
            foreach ($items as $item) {
                $item->delete();
            }
        }

        return $this->redirect(['index']);
    }
}