FilterWidget::run() - Code Metrics - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

FilterWidget::run() A
last analyzed 2020-02-16 09:05 UTC

↳ Parent: FilterWidget

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	34
rs	9.376
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace app\widgets\filter;

use app\models\BaseObject;
use app\models\ObjectStaticValues;
use app\models\Property;
use app\models\PropertyGroup;
use app\models\PropertyStaticValues;
use app\modules\Shop\models\Product;
use Yii;
use yii\base\Widget;
use yii\caching\TagDependency;
use yii\db\Query;
use yii\helpers\ArrayHelper;
use yii\helpers\Json;

class FilterWidget extends Widget
{
    protected $possibleSelections = null;
    public $categoryGroupId = 0;
    public $currentSelections = [];
    public $goBackAlignment = 'left';
    public $objectId = null;
    public $onlyAvailableFilters = true;
    public $disableInsteadOfHide = false;
    public $route = '/shop/product/list';
    public $title = 'Filter';
    public $viewFile = 'filterWidget';
    protected $disabled_ids = [];
    public $render_dynamic = true;
    public $currentObjects = [];

    /**
     * @var null|array Array of group ids to display in filter, null to display all available for Object
     */
    public $onlyGroupsIds = null;

    /**
     * @var array Additional params passed to filter view
     */
    public $additionalViewParams = [];

    /**
     * @inheritdoc
     */
    public function run()
    {
        Yii::beginProfile("FilterWidget");

        $view = $this->getView();
        FilterWidgetAsset::register($view);
        $view->registerJs(
            "jQuery('#{$this->id}').getFilters();"
        );

        Yii::beginProfile("GetPossibleSelections");
        $this->getPossibleSelections();
        Yii::endProfile("GetPossibleSelections");

        $result = $this->render(
            $this->viewFile,
            ArrayHelper::merge([
                'id' => $this->id,
                'current_selections' => $this->currentSelections,
                'possible_selections' => $this->possibleSelections,
                'object_id' => $this->objectId,
                'title' => $this->title,
                'go_back_alignment' => $this->goBackAlignment,
                'route' => $this->route,
                'category_group_id' => $this->categoryGroupId,
                'disabled_ids' => $this->disabled_ids,
                'render_dynamic' => $this->render_dynamic,
            ], $this->additionalViewParams)
        );

        Yii::endProfile("FilterWidget");

        return $result;
    }

    public function getPossibleSelections()
    {
        $data = [
            'propertyIds' => [],
            'propertyStaticValueIds' => [],
        ];
        if ($this->onlyAvailableFilters) {
            Yii::beginProfile("onlyAvailableFilters");
            $object = BaseObject::findById($this->objectId);
            if (!is_null($object) && isset($this->currentSelections['last_category_id'])) {

                $cacheKey = 'FilterWidget: ' . $object->id . ':' . $this->currentSelections['last_category_id'] . ':'
                    . Json::encode($this->currentSelections['properties']);
                $data = Yii::$app->cache->get($cacheKey);
                if ($data === false) {
                    $data = [];
                    Yii::beginProfile("ObjectIds for this category");
                    if (count($this->currentObjects) == 0) {
                        $psv = [];
                        array_walk_recursive($this->currentSelections['properties'], function ($item) use (&$psv) {
                            if (is_array($item) === false) {
                                $psv[] = $item;
                            }
                        });
                        $product = Yii::$container->get(Product::class);
                        $query = (new Query)
                            ->select('pc.object_model_id')
                            ->from($object->categories_table_name . ' pc')
                            ->innerJoin($product::tableName() . ' product', 'product.id = pc.object_model_id')
                            ->where([
                                'pc.category_id' => $this->currentSelections['last_category_id'],
                                'product.active' => 1,
                            ]);

                        if (count($this->currentSelections['properties'])) {
                            $query->innerJoin([
                                'osvm' => (new Query)
                                    ->select('object_model_id')
                                    ->distinct()
                                    ->from(ObjectStaticValues::tableName())
                                    ->where([
                                        'object_id' => $object->id,
                                        'property_static_value_id' => $psv
                                    ])
                                    ->groupBy('object_model_id')
                                    ->having(['count(object_model_id)' => count($psv)])
                            ],
                                'osvm.object_model_id = pc.object_model_id'
                            );
                        }

                        Yii::endProfile("ObjectIds for this category");

                        $ids = array_map('intval', $query->column());
                        $query = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                    } else {
                        $ids = ArrayHelper::getColumn($this->currentObjects, 'id');
                    }


                    Yii::beginProfile("all PSV ids");
                    $data['propertyStaticValueIds'] = [];
                    if (count($ids) !== 0) {
                        $q4psv = (new Query())
                            ->select('property_static_value_id')
                            ->from(ObjectStaticValues::tableName())
                            ->distinct()
                            ->where(['object_id' => $object->id])
                            ->andWhere('object_model_id in (' . implode(',', $ids) . ')');


                        $data['propertyStaticValueIds'] = array_map('intval', $q4psv->column());
                    }
                    Yii::endProfile("all PSV ids");


                    $ids = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

                    Yii::beginProfile("Property ids from PSV ids");
                    $data['propertyIds'] = [];
                    if (count($data['propertyStaticValueIds']) !== 0) {
                        $data['propertyIds'] = PropertyStaticValues::find()
                            ->select('property_id')
                            ->distinct()
                            ->where(['dont_filter' => 0])
                            ->andWhere('id IN (' . implode(',', $data['propertyStaticValueIds']) . ')')
                            ->asArray()
                            ->column();
                    }
                    Yii::endProfile("Property ids from PSV ids");

                    Yii::$app->cache->set(
                        $cacheKey,
                        $data,
                        86400,
                        new TagDependency([
                            'tags' => [
                                \devgroup\TagDependencyHelper\ActiveRecordHelper::getCommonTag($object->object_class)
                            ],
                        ])
                    );
                    $object = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                }
            }
            Yii::endProfile("onlyAvailableFilters");
        }

        $this->possibleSelections = [];

        $groups = PropertyGroup::getForObjectId($this->objectId);

        foreach ($groups as $group) {

            if ($this->onlyGroupsIds !== null) {
                if (in_array($group->id, $this->onlyGroupsIds) === false) {
                    // skip this group
                    continue;
                }
            }

            if ($group->is_internal) {
                continue;
            }
            $this->possibleSelections[$group->id] = [
                'group' => $group,
                'selections' => [],
                'static_selections' => [],
                'dynamic_selections' => [],
            ];
            $props = Property::getForGroupId($group->id);
            foreach ($props as $p) {

                if ($this->onlyAvailableFilters && !in_array($p->id, $data['propertyIds'])) {
                    if ($this->disableInsteadOfHide === false) {
                        continue;
                    }
                }
                if ($p->dont_filter) {
                    continue;
                }
                if ($p->has_static_values) {
                    $propertyStaticValues = PropertyStaticValues::getValuesForPropertyId($p->id);
                    foreach ($propertyStaticValues as $key => $propertyStaticValue) {

                        if ($propertyStaticValue['dont_filter']) {
                            unset($propertyStaticValues[$key]);
                        }
                    }
                    if ($this->onlyAvailableFilters) {
                        foreach ($propertyStaticValues as $key => $propertyStaticValue) {

                            if (!in_array($propertyStaticValue['id'], $data['propertyStaticValueIds'])) {
                                if ($this->disableInsteadOfHide === true) {
                                    $this->disabled_ids[]=$propertyStaticValue['id'];
                                } else {
                                    unset($propertyStaticValues[$key]);
                                }
                            }
                        }
                    }

                    $this->possibleSelections[$group->id]['static_selections'][$p->id] = $propertyStaticValues;
                } elseif ($p->is_column_type_stored && $p->value_type == 'NUMBER') {
                    $this->possibleSelections[$group->id]['dynamic_selections'][] = $p->id;
                }

            }
            if (count($this->possibleSelections[$group->id]) === 0) {
                unset($this->possibleSelections[$group->id]);
            }
        }
    }
}


1			<?php
2
3			namespace app\widgets\filter;
4
5			use app\models\BaseObject;
6			use app\models\ObjectStaticValues;
7			use app\models\Property;
8			use app\models\PropertyGroup;
9			use app\models\PropertyStaticValues;
10			use app\modules\Shop\models\Product;
11			use Yii;
12			use yii\base\Widget;
13			use yii\caching\TagDependency;
14			use yii\db\Query;
15			use yii\helpers\ArrayHelper;
16			use yii\helpers\Json;
17
18			class FilterWidget extends Widget
19			{
20			protected $possibleSelections = null;
21			public $categoryGroupId = 0;
22			public $currentSelections = [];
23			public $goBackAlignment = 'left';
24			public $objectId = null;
25			public $onlyAvailableFilters = true;
26			public $disableInsteadOfHide = false;
27			public $route = '/shop/product/list';
28			public $title = 'Filter';
29			public $viewFile = 'filterWidget';
30			protected $disabled_ids = [];
31			public $render_dynamic = true;
32			public $currentObjects = [];
33
34			/**
35			* @var null\|array Array of group ids to display in filter, null to display all available for Object
36			*/
37			public $onlyGroupsIds = null;
38
39			/**
40			* @var array Additional params passed to filter view
41			*/
42			public $additionalViewParams = [];
43
44			/**
45			* @inheritdoc
46			*/
47			public function run()
48			{
49			Yii::beginProfile("FilterWidget");
50
51			$view = $this->getView();
52			FilterWidgetAsset::register($view);
53			$view->registerJs(
54			"jQuery('#{$this->id}').getFilters();"
55			);
56
57			Yii::beginProfile("GetPossibleSelections");
58			$this->getPossibleSelections();
59			Yii::endProfile("GetPossibleSelections");
60
61			$result = $this->render(
62			$this->viewFile,
63			ArrayHelper::merge([
64			'id' => $this->id,
65			'current_selections' => $this->currentSelections,
66			'possible_selections' => $this->possibleSelections,
67			'object_id' => $this->objectId,
68			'title' => $this->title,
69			'go_back_alignment' => $this->goBackAlignment,
70			'route' => $this->route,
71			'category_group_id' => $this->categoryGroupId,
72			'disabled_ids' => $this->disabled_ids,
73			'render_dynamic' => $this->render_dynamic,
74			], $this->additionalViewParams)
75			);
76
77			Yii::endProfile("FilterWidget");
78
79			return $result;
80			}
81
82			public function getPossibleSelections()
83			{
84			$data = [
85			'propertyIds' => [],
86			'propertyStaticValueIds' => [],
87			];
88			if ($this->onlyAvailableFilters) {
89			Yii::beginProfile("onlyAvailableFilters");
90			$object = BaseObject::findById($this->objectId);
91			if (!is_null($object) && isset($this->currentSelections['last_category_id'])) {
92
93			$cacheKey = 'FilterWidget: ' . $object->id . ':' . $this->currentSelections['last_category_id'] . ':'
94			. Json::encode($this->currentSelections['properties']);
95			$data = Yii::$app->cache->get($cacheKey);
96			if ($data === false) {
97			$data = [];
98			Yii::beginProfile("ObjectIds for this category");
99			if (count($this->currentObjects) == 0) {
100			$psv = [];
101			array_walk_recursive($this->currentSelections['properties'], function ($item) use (&$psv) {
102			if (is_array($item) === false) {
103			$psv[] = $item;
104			}
105			});
106			$product = Yii::$container->get(Product::class);
107			$query = (new Query)
108			->select('pc.object_model_id')
109			->from($object->categories_table_name . ' pc')
110			->innerJoin($product::tableName() . ' product', 'product.id = pc.object_model_id')
111			->where([
112			'pc.category_id' => $this->currentSelections['last_category_id'],
113			'product.active' => 1,
114			]);
115
116			if (count($this->currentSelections['properties'])) {
117			$query->innerJoin([
118			'osvm' => (new Query)
119			->select('object_model_id')
120			->distinct()
121			->from(ObjectStaticValues::tableName())
122			->where([
123			'object_id' => $object->id,
124			'property_static_value_id' => $psv
125			])
126			->groupBy('object_model_id')
127			->having(['count(object_model_id)' => count($psv)])
128			],
129			'osvm.object_model_id = pc.object_model_id'
130			);
131			}
132
133			Yii::endProfile("ObjectIds for this category");
134
135			$ids = array_map('intval', $query->column());
136			$query = null;
			0 ignored issues – show Unused Code introduced 2017-04-24 14:58 UTC by Report Bug Copy Issue Report `$query` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
137			} else {
138			$ids = ArrayHelper::getColumn($this->currentObjects, 'id');
139			}
140
141
142			Yii::beginProfile("all PSV ids");
143			$data['propertyStaticValueIds'] = [];
144			if (count($ids) !== 0) {
145			$q4psv = (new Query())
146			->select('property_static_value_id')
147			->from(ObjectStaticValues::tableName())
148			->distinct()
149			->where(['object_id' => $object->id])
150			->andWhere('object_model_id in (' . implode(',', $ids) . ')');
151
152
153			$data['propertyStaticValueIds'] = array_map('intval', $q4psv->column());
154			}
155			Yii::endProfile("all PSV ids");
156
157
158			$ids = null;
			0 ignored issues – show Unused Code introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report `$ids` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
159
160			Yii::beginProfile("Property ids from PSV ids");
161			$data['propertyIds'] = [];
162			if (count($data['propertyStaticValueIds']) !== 0) {
163			$data['propertyIds'] = PropertyStaticValues::find()
164			->select('property_id')
165			->distinct()
166			->where(['dont_filter' => 0])
167			->andWhere('id IN (' . implode(',', $data['propertyStaticValueIds']) . ')')
168			->asArray()
169			->column();
170			}
171			Yii::endProfile("Property ids from PSV ids");
172
173			Yii::$app->cache->set(
174			$cacheKey,
175			$data,
176			86400,
177			new TagDependency([
178			'tags' => [
179			\devgroup\TagDependencyHelper\ActiveRecordHelper::getCommonTag($object->object_class)
180			],
181			])
182			);
183			$object = null;
			0 ignored issues – show Unused Code introduced 2015-12-02 18:30 UTC by Report Bug Copy Issue Report `$object` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
184			}
185			}
186			Yii::endProfile("onlyAvailableFilters");
187			}
188
189			$this->possibleSelections = [];
190
191			$groups = PropertyGroup::getForObjectId($this->objectId);
192
193			foreach ($groups as $group) {
194
195			if ($this->onlyGroupsIds !== null) {
196			if (in_array($group->id, $this->onlyGroupsIds) === false) {
197			// skip this group
198			continue;
199			}
200			}
201
202			if ($group->is_internal) {
203			continue;
204			}
205			$this->possibleSelections[$group->id] = [
206			'group' => $group,
207			'selections' => [],
208			'static_selections' => [],
209			'dynamic_selections' => [],
210			];
211			$props = Property::getForGroupId($group->id);
212			foreach ($props as $p) {
213
214			if ($this->onlyAvailableFilters && !in_array($p->id, $data['propertyIds'])) {
215			if ($this->disableInsteadOfHide === false) {
216			continue;
217			}
218			}
219			if ($p->dont_filter) {
220			continue;
221			}
222			if ($p->has_static_values) {
223			$propertyStaticValues = PropertyStaticValues::getValuesForPropertyId($p->id);
224			foreach ($propertyStaticValues as $key => $propertyStaticValue) {
225
226			if ($propertyStaticValue['dont_filter']) {
227			unset($propertyStaticValues[$key]);
228			}
229			}
230			if ($this->onlyAvailableFilters) {
231			foreach ($propertyStaticValues as $key => $propertyStaticValue) {
232
233			if (!in_array($propertyStaticValue['id'], $data['propertyStaticValueIds'])) {
234			if ($this->disableInsteadOfHide === true) {
235			$this->disabled_ids[]=$propertyStaticValue['id'];
236			} else {
237			unset($propertyStaticValues[$key]);
238			}
239			}
240			}
241			}
242
243			$this->possibleSelections[$group->id]['static_selections'][$p->id] = $propertyStaticValues;
244			} elseif ($p->is_column_type_stored && $p->value_type == 'NUMBER') {
245			$this->possibleSelections[$group->id]['dynamic_selections'][] = $p->id;
246			}
247
248			}
249			if (count($this->possibleSelections[$group->id]) === 0) {
250			unset($this->possibleSelections[$group->id]);
251			}
252			}
253			}
254			}
255

DevGroup-ru / dotplant2

GitHub Access Token became invalid

FilterWidget::run() A last analyzed 2020-02-16 09:05 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

FilterWidget::run() A
last analyzed 2020-02-16 09:05 UTC