GetImages::getImages() - Code Metrics - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

GetImages::getImages() A
last analyzed 2020-02-16 09:05 UTC

↳ Parent: GetImages

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.6666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace app\traits;

use app\modules\image\models\Image;

/**
 * Trait to create relation of images width object
 * Class GetImages
 * @package app\traits
 */
trait GetImages
{
    public function getImages()
    {
        /**
         * @var $object \app\models\BaseObject
         * @var $model \app\properties\HasProperties | \yii\db\ActiveRecord
         * @return \yii\db\ActiveQueryInterface
         */
        $model = $this;
        $object = $model->object;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        return $model->hasMany(Image::className(), ['object_model_id' => 'id'])->andWhere(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            ['object_id' => $object->id]
        )->addOrderBy(
            [
                'sort_order' => SORT_ASC,
                'id' => SORT_ASC
            ]
        );
    }

}


1			<?php
2
3			namespace app\traits;
4
5			use app\modules\image\models\Image;
6
7			/**
8			* Trait to create relation of images width object
9			* Class GetImages
10			* @package app\traits
11			*/
12			trait GetImages
13			{
14			public function getImages()
15			{
16			/**
17			* @var $object \app\models\BaseObject
18			* @var $model \app\properties\HasProperties \| \yii\db\ActiveRecord
19			* @return \yii\db\ActiveQueryInterface
20			*/
21			$model = $this;
22			$object = $model->object;
			0 ignored issues – show Documentation introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The property `$object` is declared private in `app\properties\HasProperties`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
23			return $model->hasMany(Image::className(), ['object_model_id' => 'id'])->andWhere(
			0 ignored issues – show Documentation Bug introduced 2016-01-12 14:56 UTC by Report Bug Copy Issue Report The method `hasMany` does not exist on `object<app\properties\HasProperties>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history... Deprecated Code introduced 2018-06-05 13:06 UTC by Report Bug Copy Issue Report The method `yii\base\BaseObject::className()` has been deprecated with message: since 2.0.14. On PHP >=5.5, use `::class` instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
24			['object_id' => $object->id]
25			)->addOrderBy(
26			[
27			'sort_order' => SORT_ASC,
28			'id' => SORT_ASC
29			]
30			);
31			}
32
33			}
34

DevGroup-ru / dotplant2

GitHub Access Token became invalid

GetImages::getImages() A last analyzed 2020-02-16 09:05 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

GetImages::getImages() A
last analyzed 2020-02-16 09:05 UTC