DeleteOne::init() - Code Metrics - DevGroup-ru/dotplant2 - Measure and Improve Code Quality continuously with Scrutinizer

DeleteOne::init() A
last analyzed 2020-02-16 09:05 UTC

↳ Parent: DeleteOne

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	9
Ratio	100 %

Importance

Changes

Metric	Value
dl	9
loc	9
rs	9.9666
c	0
b	0
f	0
cc	3
nc	3
nop	0

<?php

namespace app\backend\actions;

use app;
use yii;
use yii\base\Action;
use yii\base\InvalidConfigException;

/**
 * Action for deletion one model from backend grid
 * @package app\backend\actions
 */
class DeleteOne extends Action
{
    /**
     * @var string Model name, ie. `Product::className()`
     */
    public $modelName = null;

    /**
     * @var bool Mark as deleted instead of calling `delete()`
     */
    public $markAsDeleted = false;

    /**
     * @var string Attribute that stores deleted state
     */
    public $deletedMarkAttribute = 'is_active';

    /**
     * @var mixed Deleted state value(ie. 1 for is_deleted or 0 for is_active)
     */
    public $deletedMarkValue = 0;

    /**
     * @var array Route to redirect after deletion
     */
    public $redirect = ['index'];

    public function init()
    {
        if (!isset($this->modelName)) {
            throw new InvalidConfigException("Model name should be set in controller actions");
        }
        if (!class_exists($this->modelName)) {
            throw new InvalidConfigException("Model class does not exists");
        }
    }

    /**
     * @inheritdoc
     */
    public function run()
    {
        $modelName = $this->modelName;
        $id = Yii::$app->request->get('id', null);
        if (!empty($id)) {
            /** @var \yii\db\ActiveRecord $modelName fake type for PHPStorm (: */
            $item = $modelName::findOne($id);
            if ($item === null) {
                throw new yii\web\NotFoundHttpException;
            }

            if ($this->markAsDeleted === true) {
                $item->setAttribute($this->deletedMarkAttribute, $this->deletedMarkValue);
                $item->save();
            } else {
                $item->delete();
            }

        }

        Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
        return $this->controller->redirect($this->redirect);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1		<?php
2
3		namespace app\backend\actions;
4
5		use app;
6		use yii;
7		use yii\base\Action;
8		use yii\base\InvalidConfigException;
9
10		/**
11		* Action for deletion one model from backend grid
12		* @package app\backend\actions
13		*/
14		class DeleteOne extends Action
15		{
16		/**
17		* @var string Model name, ie. `Product::className()`
18		*/
19		public $modelName = null;
20
21		/**
22		* @var bool Mark as deleted instead of calling `delete()`
23		*/
24		public $markAsDeleted = false;
25
26		/**
27		* @var string Attribute that stores deleted state
28		*/
29		public $deletedMarkAttribute = 'is_active';
30
31		/**
32		* @var mixed Deleted state value(ie. 1 for is_deleted or 0 for is_active)
33		*/
34		public $deletedMarkValue = 0;
35
36		/**
37		* @var array Route to redirect after deletion
38		*/
39		public $redirect = ['index'];
40
41	View Code Duplication	public function init()
42		{
43		if (!isset($this->modelName)) {
44		throw new InvalidConfigException("Model name should be set in controller actions");
45		}
46		if (!class_exists($this->modelName)) {
47		throw new InvalidConfigException("Model class does not exists");
48		}
49		}
50
51		/**
52		* @inheritdoc
53		*/
54		public function run()
55		{
56		$modelName = $this->modelName;
57		$id = Yii::$app->request->get('id', null);
58		if (!empty($id)) {
59		/** @var \yii\db\ActiveRecord $modelName fake type for PHPStorm (: */
60		$item = $modelName::findOne($id);
61		if ($item === null) {
62		throw new yii\web\NotFoundHttpException;
63		}
64
65	View Code Duplication	if ($this->markAsDeleted === true) {
66		$item->setAttribute($this->deletedMarkAttribute, $this->deletedMarkValue);
67		$item->save();
68		} else {
69		$item->delete();
70		}
71
72		}
73
74		Yii::$app->session->setFlash('info', Yii::t('app', 'Object removed'));
75		return $this->controller->redirect($this->redirect);
		0 ignored issues – show Bug introduced 2018-06-05 13:06 UTC by Report Bug Copy Issue Report The method `redirect` does only exist in `yii\web\Controller`, but not in `yii\base\Controller and yii\console\Controller`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
76		}
77		}
78

DevGroup-ru / dotplant2

GitHub Access Token became invalid

DeleteOne::init() A last analyzed 2020-02-16 09:05 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

DeleteOne::init() A
last analyzed 2020-02-16 09:05 UTC